linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 04/19] PCI/MSI: Add hooks to populate the msi_domain field
Date: Tue, 28 Jul 2015 14:46:11 +0100	[thread overview]
Message-ID: <1438091186-10244-5-git-send-email-marc.zyngier@arm.com> (raw)
In-Reply-To: <1438091186-10244-1-git-send-email-marc.zyngier@arm.com>

In order to be able to populate the device msi_domain field,
add the necessary hooks to propagate the host bridge msi_domain
across secondary busses to devices.

So far, nobody populates the initial msi_domain.

Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
 drivers/pci/probe.c | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index cefd636..c03ecbf 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -661,6 +661,32 @@ static void pci_set_bus_speed(struct pci_bus *bus)
 	}
 }
 
+static struct irq_domain *pci_host_bridge_msi_domain(struct pci_bus *bus)
+{
+	/*
+	 * Any firmware interface that can resolve the msi_domain
+	 * should be called from here.
+	 */
+
+	return NULL;
+}
+
+static void pci_set_bus_msi_domain(struct pci_bus *bus)
+{
+	struct irq_domain *d;
+
+	/*
+	 * Either bus is the root, and we must obtain it from the
+	 * firmware, or we inherit it from the bridge device.
+	 */
+	if (pci_is_root_bus(bus))
+		d = pci_host_bridge_msi_domain(bus);
+	else
+		d = dev_get_msi_domain(&bus->self->dev);
+
+	dev_set_msi_domain(&bus->dev, d);
+}
+
 static struct pci_bus *pci_alloc_child_bus(struct pci_bus *parent,
 					   struct pci_dev *bridge, int busnr)
 {
@@ -714,6 +740,7 @@ static struct pci_bus *pci_alloc_child_bus(struct pci_bus *parent,
 	bridge->subordinate = child;
 
 add_dev:
+	pci_set_bus_msi_domain(child);
 	ret = device_register(&child->dev);
 	WARN_ON(ret < 0);
 
@@ -1544,6 +1571,17 @@ static void pci_init_capabilities(struct pci_dev *dev)
 	pci_enable_acs(dev);
 }
 
+static void pci_set_msi_domain(struct pci_dev *dev)
+{
+	/*
+	 * If no domain has been set through the pcibios_add_device
+	 * callback, inherit the default from the bus device.
+	 */
+	if (!dev_get_msi_domain(&dev->dev))
+		dev_set_msi_domain(&dev->dev,
+				   dev_get_msi_domain(&dev->bus->dev));
+}
+
 void pci_device_add(struct pci_dev *dev, struct pci_bus *bus)
 {
 	int ret;
@@ -1585,6 +1623,9 @@ void pci_device_add(struct pci_dev *dev, struct pci_bus *bus)
 	ret = pcibios_add_device(dev);
 	WARN_ON(ret < 0);
 
+	/* Setup MSI irq domain */
+	pci_set_msi_domain(dev);
+
 	/* Notifier could use PCI capabilities */
 	dev->match_driver = false;
 	ret = device_add(&dev->dev);
@@ -1975,6 +2016,7 @@ struct pci_bus *pci_create_root_bus(struct device *parent, int bus,
 	b->bridge = get_device(&bridge->dev);
 	device_enable_async_suspend(b->bridge);
 	pci_set_bus_of_node(b);
+	pci_set_bus_msi_domain(b);
 
 	if (!parent)
 		set_dev_node(b->bridge, pcibus_to_node(b));
-- 
2.1.4

  parent reply	other threads:[~2015-07-28 13:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28 13:46 [PATCH v6 00/19] Per-device MSI domain & platform MSI Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 01/19] genirq: irqdomain: Allow irq domain aliasing Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 02/19] PCI: MSI: Register irq domain with specific token Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 03/19] device core: Introduce per-device MSI domain pointer Marc Zyngier
2015-07-29 22:25   ` [tip:irq/core] " tip-bot for Marc Zyngier
2015-07-28 13:46 ` Marc Zyngier [this message]
2015-07-28 13:46 ` [PATCH v6 05/19] PCI/MSI: of: Add support for OF-provided msi_domain Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 06/19] PCI/MSI: of: Allow msi_domain lookup using the host bridge node Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 07/19] PCI/MSI: Let pci_msi_get_domain use struct device's msi_domain Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 08/19] platform: of: Assign MSI domain to platform device Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 09/19] drivers: base: Add MSI domain support for non-PCI devices Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 10/19] genirq: Add DOMAIN_BUS_NEXUS irqdomain property Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 11/19] irqchip: gicv3-its: Split PCI/MSI code from the core ITS driver Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 12/19] irqchip: gicv3-its: Register irq domain with NEXUS token Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 13/19] irqchip: gicv3-its: Get rid of struct msi_controller Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 14/19] irqchip: gicv3-its: Make the PCI/MSI code standalone Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 15/19] irqchip: gicv3-its: Add platform MSI support Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 16/19] irqchip: GICv2m: Get rid of struct msi_controller Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 17/19] irqchip: GICv2m: Add platform MSI support Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 18/19] PCI/MSI: pci-xgene-msi: Get rid of struct msi_controller Marc Zyngier
2015-07-28 13:46 ` [PATCH v6 19/19] PCI/MSI: Drop domain field from msi_controller Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438091186-10244-5-git-send-email-marc.zyngier@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).