From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] gpiolib-sysfs: Add gpio name parsing for sysfs export
Date: Tue, 4 Aug 2015 11:23:21 +0200 [thread overview]
Message-ID: <1438680203-13432-5-git-send-email-mpa@pengutronix.de> (raw)
In-Reply-To: <1438680203-13432-1-git-send-email-mpa@pengutronix.de>
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
drivers/gpio/gpiolib-sysfs.c | 47 ++++++++++++++++++++++++++++++++------------
1 file changed, 34 insertions(+), 13 deletions(-)
diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c
index b57ed8e55ab5..e22a86e31c90 100644
--- a/drivers/gpio/gpiolib-sysfs.c
+++ b/drivers/gpio/gpiolib-sysfs.c
@@ -443,18 +443,28 @@ static ssize_t export_store(struct class *class,
const char *buf, size_t len)
{
long gpio;
- struct gpio_desc *desc;
+ struct gpio_desc *desc = NULL;
int status;
status = kstrtol(buf, 0, &gpio);
- if (status < 0)
- goto done;
+ if (!status)
+ desc = gpio_to_desc(gpio);
- desc = gpio_to_desc(gpio);
- /* reject invalid GPIOs */
+ /* Fall back on detection by name */
if (!desc) {
- pr_warn("%s: invalid GPIO %ld\n", __func__, gpio);
- return -EINVAL;
+ char *gpio_name = kstrdup(buf, GFP_KERNEL);
+
+ if (!gpio_name)
+ return -ENOMEM;
+
+ desc = gpio_name_to_desc(strim(gpio_name));
+ kfree(gpio_name);
+
+ /* reject invalid GPIOs */
+ if (!desc) {
+ pr_warn("%s: invalid GPIO %s\n", __func__, buf);
+ return -EINVAL;
+ }
}
/* No extra locking here; FLAG_SYSFS just signifies that the
@@ -485,17 +495,28 @@ static ssize_t unexport_store(struct class *class,
const char *buf, size_t len)
{
long gpio;
- struct gpio_desc *desc;
+ struct gpio_desc *desc = NULL;
int status;
status = kstrtol(buf, 0, &gpio);
- if (status < 0)
- goto done;
+ if (!status)
+ desc = gpio_to_desc(gpio);
+
+ /* Fall back on detection by name */
+ if (!desc) {
+ char *gpio_name = kstrdup(buf, GFP_KERNEL);
+
+ if (!gpio_name)
+ return -ENOMEM;
+
+ desc = gpio_name_to_desc(strim(gpio_name));
+ kfree(gpio_name);
+ }
+
- desc = gpio_to_desc(gpio);
/* reject bogus commands (gpio_unexport ignores them) */
if (!desc) {
- pr_warn("%s: invalid GPIO %ld\n", __func__, gpio);
+ pr_warn("%s: invalid GPIO %s\n", __func__, buf);
return -EINVAL;
}
@@ -509,7 +530,7 @@ static ssize_t unexport_store(struct class *class,
status = 0;
gpiod_free(desc);
}
-done:
+
if (status)
pr_debug("%s: status %d\n", __func__, status);
return status ? : len;
--
2.1.4
next prev parent reply other threads:[~2015-08-04 9:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 9:23 [PATCH 0/6] gpiolib: Add GPIO name support Markus Pargmann
2015-08-04 9:23 ` [PATCH 1/6] gpiolib-of: Rename gpio_hog functions to be generic Markus Pargmann
2015-08-10 9:29 ` Linus Walleij
2015-08-13 13:14 ` Markus Pargmann
2015-08-04 9:23 ` [PATCH 2/6] gpio: Introduce gpio descriptor 'name' Markus Pargmann
2015-08-10 9:37 ` Linus Walleij
2015-08-13 13:28 ` Markus Pargmann
2015-08-25 14:25 ` Linus Walleij
2015-08-04 9:23 ` [PATCH 3/6] gpiolib-of: Reuse 'line-name' from DT as gpio descriptor name Markus Pargmann
2015-08-10 9:38 ` Linus Walleij
2015-08-04 9:23 ` Markus Pargmann [this message]
2015-08-10 9:40 ` [PATCH 4/6] gpiolib-sysfs: Add gpio name parsing for sysfs export Linus Walleij
2015-08-04 9:23 ` [PATCH 5/6] gpiolib-sysfs: Show gpio-name in /sys/class/gpio/gpio*/name Markus Pargmann
2015-08-10 9:50 ` Linus Walleij
2015-08-13 13:43 ` Markus Pargmann
2015-09-23 22:20 ` Johan Hovold
2015-08-04 9:23 ` [PATCH 6/6] gpiolib: Add gpio name information to /sys/kernel/debug/gpio Markus Pargmann
2015-08-10 10:02 ` Linus Walleij
2015-08-17 7:29 ` Alexandre Courbot
2015-08-25 14:34 ` Linus Walleij
2015-08-04 9:25 ` [PATCH 0/6 v2] gpiolib: Add GPIO name support Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438680203-13432-5-git-send-email-mpa@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).