linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] nvmem: imx-ocotp: Add i.MX6 OCOTP driver
Date: Thu, 06 Aug 2015 18:28:10 +0200	[thread overview]
Message-ID: <1438878490.3223.10.camel@pengutronix.de> (raw)
In-Reply-To: <55C38941.9090709@linaro.org>

Hi Srinivas,

Am Donnerstag, den 06.08.2015, 17:20 +0100 schrieb Srinivas Kandagatla:
> Few Nits..
> 
> On 04/08/15 14:02, Philipp Zabel wrote:
> > +#include <linux/clk.h>
> May be you can drop this?

Yes, that's a left-over and can be removed.

> BTW, who is taking care of the gated peripheral clock controlled for 
> this driver?

Nobody. I had initially copied the code that actually senses the fuses,
but since this happens during power-on reset anyway (all values are
stored in shadow registers), I didn't see the point and dropped it for
now.
The shadow registers are clocked directly by the ungated ipg_root clock.

[...]
> > +MODULE_LICENSE("GPL");
> 
> GPL v2 ?

Will do.

thanks
Philipp

  reply	other threads:[~2015-08-06 16:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-04 13:02 [PATCH 1/3] nvmem: Add i.MX6 OCOTP device tree binding documentation Philipp Zabel
2015-08-04 13:02 ` [PATCH 2/3] nvmem: imx-ocotp: Add i.MX6 OCOTP driver Philipp Zabel
2015-08-06 16:20   ` Srinivas Kandagatla
2015-08-06 16:28     ` Philipp Zabel [this message]
2015-08-06 19:36       ` Srinivas Kandagatla
2015-08-07  7:46         ` Philipp Zabel
2015-08-07  9:11           ` Srinivas Kandagatla
2015-08-04 13:02 ` [PATCH 3/3] ARM: imx6: Add clock to OCOTP node Philipp Zabel
2015-08-06 16:12 ` [PATCH 1/3] nvmem: Add i.MX6 OCOTP device tree binding documentation Srinivas Kandagatla
2015-08-06 16:33   ` Philipp Zabel
2015-08-06 19:34     ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438878490.3223.10.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).