From: al.stone@linaro.org (Al Stone)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] ACPI / IA64: remove usage of BAD_MADT_ENTRY
Date: Thu, 6 Aug 2015 14:59:28 -0600 [thread overview]
Message-ID: <1438894770-31163-4-git-send-email-al.stone@linaro.org> (raw)
In-Reply-To: <1438894770-31163-1-git-send-email-al.stone@linaro.org>
Now that we have introduced the bad_madt_entry() function, and that
function is being invoked in acpi_table_parse_madt() for us, there
is no longer any need to use the BAD_MADT_ENTRY macro.
Signed-off-by: Al Stone <al.stone@linaro.org>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
---
arch/ia64/kernel/acpi.c | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/arch/ia64/kernel/acpi.c b/arch/ia64/kernel/acpi.c
index b1698bc..efa3f0a 100644
--- a/arch/ia64/kernel/acpi.c
+++ b/arch/ia64/kernel/acpi.c
@@ -184,9 +184,6 @@ acpi_parse_lapic_addr_ovr(struct acpi_subtable_header * header,
lapic = (struct acpi_madt_local_apic_override *)header;
- if (BAD_MADT_ENTRY(lapic, end))
- return -EINVAL;
-
if (lapic->address) {
iounmap(ipi_base_addr);
ipi_base_addr = ioremap(lapic->address, 0);
@@ -201,8 +198,6 @@ acpi_parse_lsapic(struct acpi_subtable_header * header, const unsigned long end)
lsapic = (struct acpi_madt_local_sapic *)header;
- /*Skip BAD_MADT_ENTRY check, as lsapic size could vary */
-
if (lsapic->lapic_flags & ACPI_MADT_ENABLED) {
#ifdef CONFIG_SMP
smp_boot_data.cpu_phys_id[available_cpus] =
@@ -222,9 +217,6 @@ acpi_parse_lapic_nmi(struct acpi_subtable_header * header, const unsigned long e
lacpi_nmi = (struct acpi_madt_local_apic_nmi *)header;
- if (BAD_MADT_ENTRY(lacpi_nmi, end))
- return -EINVAL;
-
/* TBD: Support lapic_nmi entries */
return 0;
}
@@ -236,9 +228,6 @@ acpi_parse_iosapic(struct acpi_subtable_header * header, const unsigned long end
iosapic = (struct acpi_madt_io_sapic *)header;
- if (BAD_MADT_ENTRY(iosapic, end))
- return -EINVAL;
-
return iosapic_init(iosapic->address, iosapic->global_irq_base);
}
@@ -253,9 +242,6 @@ acpi_parse_plat_int_src(struct acpi_subtable_header * header,
plintsrc = (struct acpi_madt_interrupt_source *)header;
- if (BAD_MADT_ENTRY(plintsrc, end))
- return -EINVAL;
-
/*
* Get vector assignment for this interrupt, set attributes,
* and program the IOSAPIC routing table.
@@ -336,9 +322,6 @@ acpi_parse_int_src_ovr(struct acpi_subtable_header * header,
p = (struct acpi_madt_interrupt_override *)header;
- if (BAD_MADT_ENTRY(p, end))
- return -EINVAL;
-
iosapic_override_isa_irq(p->source_irq, p->global_irq,
((p->inti_flags & ACPI_MADT_POLARITY_MASK) ==
ACPI_MADT_POLARITY_ACTIVE_LOW) ?
@@ -356,9 +339,6 @@ acpi_parse_nmi_src(struct acpi_subtable_header * header, const unsigned long end
nmi_src = (struct acpi_madt_nmi_source *)header;
- if (BAD_MADT_ENTRY(nmi_src, end))
- return -EINVAL;
-
/* TBD: Support nimsrc entries */
return 0;
}
--
2.4.3
next prev parent reply other threads:[~2015-08-06 20:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 20:59 [PATCH 0/5] ACPI: Provide better MADT subtable sanity checks Al Stone
2015-08-06 20:59 ` [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro Al Stone
2015-08-12 22:35 ` [Linaro-acpi] " Timur Tabi
2015-08-13 9:30 ` Hanjun Guo
2015-08-13 15:43 ` Al Stone
2015-08-13 9:28 ` Hanjun Guo
2015-08-06 20:59 ` [PATCH 2/5] ACPI / ARM64: remove usage of BAD_MADT_ENTRY/BAD_MADT_GICC_ENTRY Al Stone
2015-08-07 9:04 ` Marc Zyngier
2015-08-07 16:57 ` Catalin Marinas
2015-08-06 20:59 ` Al Stone [this message]
2015-08-06 20:59 ` [PATCH 4/5] ACPI / X86: remove usage of BAD_MADT_ENTRY Al Stone
2015-08-06 20:59 ` [PATCH 5/5] ACPI: remove definition of BAD_MADT_ENTRY macro Al Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438894770-31163-4-git-send-email-al.stone@linaro.org \
--to=al.stone@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).