From: HenryC.Chen@mediatek.com (Henry Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mfd: mt6397: Implement wake handler and suspend/resume for mt6397-core.c
Date: Mon, 10 Aug 2015 20:23:21 +0800 [thread overview]
Message-ID: <1439209401.32674.16.camel@mtksdaap41> (raw)
In-Reply-To: <20150810114224.GD3249@x1>
Hi Jones,
On Mon, 2015-08-10 at 12:42 +0100, Lee Jones wrote:
> No need to mention the filename in the subject line. You already
> mentioned which driver is effected by the change.
Ok, it will be changed.
>
> > Register mt6393_irq as wake up source to pinctrl by flag "IRQF_NO_SUSPEND".
> > Implement .irq_set_wake() function of pmic to keep who is wakeup source,
> > and enable irq on .suspend()and restore irq on .resume().
> >
> > Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> > ---
> > drivers/mfd/mt6397-core.c | 49 ++++++++++++++++++++++++++++++++++++++++-
> > include/linux/mfd/mt6397/core.h | 1 +
> > 2 files changed, 49 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> > index 03929a6..aebdee5 100644
> > --- a/drivers/mfd/mt6397-core.c
> > +++ b/drivers/mfd/mt6397-core.c
>
> [...]
>
> > @@ -142,6 +161,7 @@ static int mt6397_irq_domain_map(struct irq_domain *d, unsigned int irq,
> > irq_set_chip_data(irq, mt6397);
> > irq_set_chip_and_handler(irq, &mt6397_irq_chip, handle_level_irq);
> > irq_set_nested_thread(irq, 1);
> > +
>
> Remainder of the patch looks okay, but this irrelevant change, which
> has nothing to do with the remainder of the patch will cause issues if
> I attempt to apply it. Please remove and re-submit.
>
Sorry, I will remove it, thanks.
Henry
> [...]
>
prev parent reply other threads:[~2015-08-10 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 15:07 [PATCH] mfd: mt6397: Implement wake handler and suspend/resume for mt6397-core.c Henry Chen
2015-08-10 11:42 ` Lee Jones
2015-08-10 12:23 ` Henry Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439209401.32674.16.camel@mtksdaap41 \
--to=henryc.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).