linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mpa@pengutronix.de (Markus Pargmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/9] gpio-sysfs: Use gpio descriptor name instead of gpiochip names array
Date: Fri, 14 Aug 2015 16:11:01 +0200	[thread overview]
Message-ID: <1439561466-14350-5-git-send-email-mpa@pengutronix.de> (raw)
In-Reply-To: <1439561466-14350-1-git-send-email-mpa@pengutronix.de>

The name is now stored in the gpio descriptor as well, for example to
allow to store names from DT. This patch changes the sysfs gpio files
to use the gpio descriptor name.

Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
 drivers/gpio/gpiolib-sysfs.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c
index b57ed8e55ab5..3e81f28e3aee 100644
--- a/drivers/gpio/gpiolib-sysfs.c
+++ b/drivers/gpio/gpiolib-sysfs.c
@@ -550,9 +550,7 @@ int gpiod_export(struct gpio_desc *desc, bool direction_may_change)
 	struct gpiod_data	*data;
 	unsigned long		flags;
 	int			status;
-	const char		*ioname = NULL;
 	struct device		*dev;
-	int			offset;
 
 	/* can't export until sysfs is available ... */
 	if (!gpio_class.p) {
@@ -601,13 +599,9 @@ int gpiod_export(struct gpio_desc *desc, bool direction_may_change)
 	else
 		data->direction_can_change = false;
 
-	offset = gpio_chip_hwgpio(desc);
-	if (chip->names && chip->names[offset])
-		ioname = chip->names[offset];
-
 	dev = device_create_with_groups(&gpio_class, chip->dev,
 					MKDEV(0, 0), data, gpio_groups,
-					ioname ? ioname : "gpio%u",
+					desc->name ? desc->name : "gpio%u",
 					desc_to_gpio(desc));
 	if (IS_ERR(dev)) {
 		status = PTR_ERR(dev);
-- 
2.4.6

  parent reply	other threads:[~2015-08-14 14:11 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14 14:10 [PATCH v3 0/9] gpiolib: Add GPIO name support Markus Pargmann
2015-08-14 14:10 ` [PATCH v3 1/9] gpiolib-of: Rename gpio_hog functions to be generic Markus Pargmann
2015-09-22  0:48   ` Linus Walleij
2015-08-14 14:10 ` [PATCH v3 2/9] gpio: Introduce gpio descriptor 'name' Markus Pargmann
2015-09-22  0:51   ` Linus Walleij
2015-08-14 14:11 ` [PATCH v3 3/9] gpiolib: Use GPIO name from names array for gpio descriptor Markus Pargmann
2015-09-22  0:56   ` Linus Walleij
2015-09-23 22:02   ` Johan Hovold
2015-09-24 21:50     ` Linus Walleij
2015-08-14 14:11 ` Markus Pargmann [this message]
2015-09-22  0:57   ` [PATCH v3 4/9] gpio-sysfs: Use gpio descriptor name instead of gpiochip names array Linus Walleij
2015-08-14 14:11 ` [PATCH v3 5/9] gpiolib: Add gpio name information to /sys/kernel/debug/gpio Markus Pargmann
2015-09-22  1:05   ` Linus Walleij
2015-08-14 14:11 ` [PATCH v3 6/9] gpiolib-sysfs: Show gpio-name in /sys/class/gpio/gpio*/name Markus Pargmann
2015-09-22  1:07   ` Linus Walleij
2015-09-24  7:14     ` Markus Pargmann
2015-08-14 14:11 ` [PATCH v3 7/9] gpiolib-sysfs: Add gpio name parsing for sysfs export Markus Pargmann
2015-09-22  1:09   ` Linus Walleij
2015-09-24  7:23     ` Markus Pargmann
2015-08-14 14:11 ` [PATCH v3 8/9] gpiolib-of: Reuse 'line-name' from DT as gpio descriptor name Markus Pargmann
2015-08-14 14:11 ` [PATCH v3 9/9] gpiolib-of: Use dev_warn instead of pr_warn Markus Pargmann
2015-09-21 10:58 ` [PATCH v3 0/9] gpiolib: Add GPIO name support Markus Pargmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439561466-14350-5-git-send-email-mpa@pengutronix.de \
    --to=mpa@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).