* [PATCH 5/5] MAINTAINERS: add entry for the Broadcom Northstar Plus SoCs
2015-08-25 23:42 ` Olof Johansson
@ 2015-08-26 17:17 ` Florian Fainelli
2015-08-26 18:20 ` Scott Branden
2015-08-26 19:00 ` Jon Mason
2 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2015-08-26 17:17 UTC (permalink / raw)
To: linux-arm-kernel
On 25/08/15 16:42, Olof Johansson wrote:
> On Thu, Aug 20, 2015 at 10:47 AM, Jon Mason <jonmason@broadcom.com> wrote:
>> Modify the iProc MAINTAINER to cover the Nortstar Plus SoCs, and add me
>> to the list of people responsible for it.
>
> That's not what this patch does. It removes CYGNUS from the
> description as well. Hmm?
>
> I'm also not a fan of the complex patterns, but that's more of a
> bikeshedding comment. Does Broadcom really not have a bit more
> systematic naming than this? :)
The naming conventions are fairly simple actually:
* BCM is just a common prefix for internal names/projects/whatever
* 9 indicates that this is a development/reference board
* 4 to 5 digits designate the chip identifier
Now, if you are trying to get some sense about how the chip ids are
actually chosen, I am afraid none of us have that knowledge ;)
>
>> Signed-off-by: Jon Mason <jonmason@broadcom.com>
>> Reviewed-by: Scott Branden <sbranden@broadcom.com>
>
> For maintainer updates, we usuallu like to see a public ack of this
> and not just a pre-acked patch. You _could_ have added it yourself
> without Scott's actual approval, after all.
>
>
> -Olof
>
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 5/5] MAINTAINERS: add entry for the Broadcom Northstar Plus SoCs
2015-08-25 23:42 ` Olof Johansson
2015-08-26 17:17 ` Florian Fainelli
@ 2015-08-26 18:20 ` Scott Branden
2015-08-26 19:00 ` Jon Mason
2 siblings, 0 replies; 6+ messages in thread
From: Scott Branden @ 2015-08-26 18:20 UTC (permalink / raw)
To: linux-arm-kernel
On 15-08-25 04:42 PM, Olof Johansson wrote:
> On Thu, Aug 20, 2015 at 10:47 AM, Jon Mason <jonmason@broadcom.com> wrote:
>> Modify the iProc MAINTAINER to cover the Nortstar Plus SoCs, and add me
>> to the list of people responsible for it.
>
> That's not what this patch does. It removes CYGNUS from the
> description as well. Hmm?
>
> I'm also not a fan of the complex patterns, but that's more of a
> bikeshedding comment. Does Broadcom really not have a bit more
> systematic naming than this? :)
>
>> Signed-off-by: Jon Mason <jonmason@broadcom.com>
>> Reviewed-by: Scott Branden <sbranden@broadcom.com>
Acked-by: Scott Branden <sbranden@broadcom.com>
>
> For maintainer updates, we usuallu like to see a public ack of this
> and not just a pre-acked patch. You _could_ have added it yourself
> without Scott's actual approval, after all.
>
>
> -Olof
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 5/5] MAINTAINERS: add entry for the Broadcom Northstar Plus SoCs
2015-08-25 23:42 ` Olof Johansson
2015-08-26 17:17 ` Florian Fainelli
2015-08-26 18:20 ` Scott Branden
@ 2015-08-26 19:00 ` Jon Mason
2015-08-26 20:02 ` Olof Johansson
2 siblings, 1 reply; 6+ messages in thread
From: Jon Mason @ 2015-08-26 19:00 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 25, 2015 at 04:42:42PM -0700, Olof Johansson wrote:
> On Thu, Aug 20, 2015 at 10:47 AM, Jon Mason <jonmason@broadcom.com> wrote:
> > Modify the iProc MAINTAINER to cover the Nortstar Plus SoCs, and add me
> > to the list of people responsible for it.
>
> That's not what this patch does. It removes CYGNUS from the
> description as well. Hmm?
iProc is a family of SoCs that includes Cygnus, Northstar (BCM5301X),
Northstar Plus, Northstar 2, and a number of other platforms. I
removed the "Cygnus" for that reason.
>
> I'm also not a fan of the complex patterns, but that's more of a
> bikeshedding comment. Does Broadcom really not have a bit more
> systematic naming than this? :)
Per Florian's comment, it's a bit of a mess internally.
>
> > Signed-off-by: Jon Mason <jonmason@broadcom.com>
> > Reviewed-by: Scott Branden <sbranden@broadcom.com>
>
> For maintainer updates, we usuallu like to see a public ack of this
> and not just a pre-acked patch. You _could_ have added it yourself
> without Scott's actual approval, after all.
Thanks,
Jon
>
>
> -Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 5/5] MAINTAINERS: add entry for the Broadcom Northstar Plus SoCs
2015-08-26 19:00 ` Jon Mason
@ 2015-08-26 20:02 ` Olof Johansson
0 siblings, 0 replies; 6+ messages in thread
From: Olof Johansson @ 2015-08-26 20:02 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Aug 26, 2015 at 12:00 PM, Jon Mason <jonmason@broadcom.com> wrote:
> On Tue, Aug 25, 2015 at 04:42:42PM -0700, Olof Johansson wrote:
>> On Thu, Aug 20, 2015 at 10:47 AM, Jon Mason <jonmason@broadcom.com> wrote:
>> > Modify the iProc MAINTAINER to cover the Nortstar Plus SoCs, and add me
>> > to the list of people responsible for it.
>>
>> That's not what this patch does. It removes CYGNUS from the
>> description as well. Hmm?
>
> iProc is a family of SoCs that includes Cygnus, Northstar (BCM5301X),
> Northstar Plus, Northstar 2, and a number of other platforms. I
> removed the "Cygnus" for that reason.
Ok, feel free to add that info to the commit message in case others
see the same and wonder what happened.
>> I'm also not a fan of the complex patterns, but that's more of a
>> bikeshedding comment. Does Broadcom really not have a bit more
>> systematic naming than this? :)
>
> Per Florian's comment, it's a bit of a mess internally.
Unfortunate. Hopefully the chaotic product naming doesn't have to leak
quite everywhere in the tree and things can be referred to by family,
etc. :)
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread