linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: msalter@redhat.com (Mark Salter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] efi/arm64: clean up efi_get_fdt_params() interface
Date: Wed, 26 Aug 2015 10:15:03 -0400	[thread overview]
Message-ID: <1440598503.13044.1.camel@redhat.com> (raw)
In-Reply-To: <CAKv+Gu9KwJfr6x8A607CsbAvpLUG2pqLPzcXsqhvmQnrcGy_ug@mail.gmail.com>

On Wed, 2015-08-26 at 16:04 +0200, Ard Biesheuvel wrote:
> On 26 August 2015 at 15:24, Leif Lindholm <leif.lindholm@linaro.org> 
> wrote:
> > As we now have a common debug infrastructure between core and arm64 
> > efi,
> > drop the bit of the interface passing verbose output flags around.
> > 
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> >  arch/arm64/kernel/efi.c    | 2 +-
> >  drivers/firmware/efi/efi.c | 6 ++----
> >  include/linux/efi.h        | 2 +-
> >  3 files changed, 4 insertions(+), 6 deletions(-)
> > 
> > diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c
> > index 612ad5e..ab5eeb6 100644
> > --- a/arch/arm64/kernel/efi.c
> > +++ b/arch/arm64/kernel/efi.c
> > @@ -201,7 +201,7 @@ void __init efi_init(void)
> >         struct efi_fdt_params params;
> > 
> 
> Actually, one nit: struct efi_fdt_params has a verbose field that was

No it doesn't. :)

> never used in the first place, but was added [supposedly] to convey
> the same as EFI_DBG that we have now. So I think you should remove
> that as well.
> 

  reply	other threads:[~2015-08-26 14:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-26 13:24 [PATCH 0/3] unify efi debug output across architectures Leif Lindholm
2015-08-26 13:24 ` [PATCH 1/3] efi/x86: move efi=debug option parsing to core Leif Lindholm
2015-08-26 17:25   ` Matt Fleming
2015-08-26 13:24 ` [PATCH 2/3] arm64: use core efi=debug instead of uefi_debug command line parameter Leif Lindholm
2015-08-26 17:24   ` Matt Fleming
2015-08-26 17:30     ` Leif Lindholm
2015-08-26 18:29       ` Ard Biesheuvel
2015-08-28 13:32   ` Matt Fleming
2015-08-26 13:24 ` [PATCH 3/3] efi/arm64: clean up efi_get_fdt_params() interface Leif Lindholm
2015-08-26 14:04   ` Ard Biesheuvel
2015-08-26 14:15     ` Mark Salter [this message]
2015-08-26 14:16       ` Ard Biesheuvel
2015-08-28 13:32   ` Matt Fleming
2015-08-26 13:46 ` [PATCH 0/3] unify efi debug output across architectures Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440598503.13044.1.camel@redhat.com \
    --to=msalter@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).