From: ryabinin.a.a@gmail.com (Andrey Ryabinin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] x86, efi, kasan: #undef memset/memcpy/memmove per arch.
Date: Fri, 28 Aug 2015 14:09:59 +0300 [thread overview]
Message-ID: <1440760199-18111-1-git-send-email-ryabinin.a.a@gmail.com> (raw)
In-Reply-To: <20150828062745.GB1928@gmail.com>
In not-instrumented code KASAN replaces instrumented
memset/memcpy/memmove with not-instrumented analogues
__memset/__memcpy/__memove.
However, on x86 the EFI stub is not linked with the kernel.
It uses not-instrumented mem*() functions from
arch/x86/boot/compressed/string.c
So we don't replace them with __mem*() variants in EFI stub.
On ARM64 the EFI stub is linked with the kernel, so we should
replace mem*() functions with __mem*(), because the EFI stub
runs before KASAN sets up early shadow.
So let's move these #undef mem* into arch's asm/efi.h which is
also included by the EFI stub.
Signed-off-by: Andrey Ryabinin <ryabinin.a.a@gmail.com>
---
arch/x86/include/asm/efi.h | 11 +++++++++++
drivers/firmware/efi/libstub/efistub.h | 4 ----
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/efi.h b/arch/x86/include/asm/efi.h
index 155162e..6862f11 100644
--- a/arch/x86/include/asm/efi.h
+++ b/arch/x86/include/asm/efi.h
@@ -25,6 +25,17 @@
#define EFI32_LOADER_SIGNATURE "EL32"
#define EFI64_LOADER_SIGNATURE "EL64"
+/*
+ * Sometimes we may redefine memset to __memset.
+ * The EFI stub doesn't have __memset() because it's not
+ * linked with the kernel. So we should use standard
+ * memset from arch/x86/boot/compressed/string.c
+ * The same applies to memcpy and memmove.
+ */
+#undef memcpy
+#undef memset
+#undef memmove
+
#ifdef CONFIG_X86_32
diff --git a/drivers/firmware/efi/libstub/efistub.h b/drivers/firmware/efi/libstub/efistub.h
index e334a01..6b6548f 100644
--- a/drivers/firmware/efi/libstub/efistub.h
+++ b/drivers/firmware/efi/libstub/efistub.h
@@ -5,10 +5,6 @@
/* error code which can't be mistaken for valid address */
#define EFI_ERROR (~0UL)
-#undef memcpy
-#undef memset
-#undef memmove
-
void efi_char16_printk(efi_system_table_t *, efi_char16_t *);
efi_status_t efi_open_volume(efi_system_table_t *sys_table_arg, void *__image,
--
2.4.6
next prev parent reply other threads:[~2015-08-28 11:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 16:15 [PATCH 0/4] KASAN/ARM64 EFI fixes Andrey Ryabinin
2015-08-26 16:15 ` [PATCH 1/4] x86, efi, kasan: #undef memset/memcpy/memmove per arch Andrey Ryabinin
2015-08-28 6:27 ` Ingo Molnar
2015-08-28 8:39 ` Leif Lindholm
2015-08-28 9:53 ` Ingo Molnar
2015-08-28 11:09 ` Andrey Ryabinin [this message]
2015-08-28 14:43 ` [PATCH v2] " Matt Fleming
2015-08-28 14:57 ` Andrey Ryabinin
2015-08-26 16:15 ` [PATCH 2/4] efi/runtime-wrappers, kasan: don't sanitize runtime wrappers Andrey Ryabinin
2015-08-26 16:15 ` [PATCH 3/4] arm64/efi-stub, kasan: don't instrument efi-stub Andrey Ryabinin
2015-08-26 16:15 ` [PATCH 4/4] libfdt, kasan: don't instrument libfdt Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440760199-18111-1-git-send-email-ryabinin.a.a@gmail.com \
--to=ryabinin.a.a@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).