[PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL

[PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL

[Guenter Roeck]

If ARM_MT8173_CPUFREQ is configured, and THERMAL is configured as module,
the following build error is seen for arm:allmodconfig and
arm64:allmodconfig.

drivers/built-in.o: In function `mtk_cpufreq_ready':
:(.text+0x32a20c): undefined reference to `of_cpufreq_cooling_register'
drivers/built-in.o: In function `mtk_cpufreq_exit':
:(.text+0x32a420): undefined reference to `cpufreq_cooling_unregister'

The fix is similar to CPUFREQ_DT, but more restrictive since
ARM_MT8173_CPUFREQ can not be built as module.

Fixes: 1453863fb02a ("cpufreq: mediatek: Add MT8173 cpufreq driver")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
It might also make sense to declare ARM_MT8173_CPUFREQ as tristate
and relax the conditions, but I don't know if that is feasible.

 drivers/cpufreq/Kconfig.arm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index 77aa34eae92c..c4c6200be435 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -133,6 +133,7 @@ config ARM_KIRKWOOD_CPUFREQ
 config ARM_MT8173_CPUFREQ
 	bool "Mediatek MT8173 CPUFreq support"
 	depends on ARCH_MEDIATEK && REGULATOR
+	depends on !CPU_THERMAL || THERMAL=y
 	select PM_OPP
 	help
 	  This adds the CPUFreq driver support for Mediatek MT8173 SoC.
-- 
2.1.4

[PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL

[Viresh Kumar]

On 03-09-15, 08:20, Guenter Roeck wrote:
> If ARM_MT8173_CPUFREQ is configured, and THERMAL is configured as module,
> the following build error is seen for arm:allmodconfig and
> arm64:allmodconfig.
> 
> drivers/built-in.o: In function `mtk_cpufreq_ready':
> :(.text+0x32a20c): undefined reference to `of_cpufreq_cooling_register'
> drivers/built-in.o: In function `mtk_cpufreq_exit':
> :(.text+0x32a420): undefined reference to `cpufreq_cooling_unregister'
> 
> The fix is similar to CPUFREQ_DT, but more restrictive since
> ARM_MT8173_CPUFREQ can not be built as module.
> 
> Fixes: 1453863fb02a ("cpufreq: mediatek: Add MT8173 cpufreq driver")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> It might also make sense to declare ARM_MT8173_CPUFREQ as tristate
> and relax the conditions, but I don't know if that is feasible.
> 
>  drivers/cpufreq/Kconfig.arm | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

[PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL

[Olof Johansson]

On Thu, Sep 3, 2015 at 8:50 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 03-09-15, 08:20, Guenter Roeck wrote:
>> If ARM_MT8173_CPUFREQ is configured, and THERMAL is configured as module,
>> the following build error is seen for arm:allmodconfig and
>> arm64:allmodconfig.
>>
>> drivers/built-in.o: In function `mtk_cpufreq_ready':
>> :(.text+0x32a20c): undefined reference to `of_cpufreq_cooling_register'
>> drivers/built-in.o: In function `mtk_cpufreq_exit':
>> :(.text+0x32a420): undefined reference to `cpufreq_cooling_unregister'
>>
>> The fix is similar to CPUFREQ_DT, but more restrictive since
>> ARM_MT8173_CPUFREQ can not be built as module.
>>
>> Fixes: 1453863fb02a ("cpufreq: mediatek: Add MT8173 cpufreq driver")
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> It might also make sense to declare ARM_MT8173_CPUFREQ as tristate
>> and relax the conditions, but I don't know if that is feasible.
>>
>>  drivers/cpufreq/Kconfig.arm | 1 +
>>  1 file changed, 1 insertion(+)
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Who's applying and sending this up to avoid extended period of build breakage?


-Olof

[PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL

[Guenter Roeck]

On 09/04/2015 12:01 PM, Olof Johansson wrote:
> On Thu, Sep 3, 2015 at 8:50 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> On 03-09-15, 08:20, Guenter Roeck wrote:
>>> If ARM_MT8173_CPUFREQ is configured, and THERMAL is configured as module,
>>> the following build error is seen for arm:allmodconfig and
>>> arm64:allmodconfig.
>>>
>>> drivers/built-in.o: In function `mtk_cpufreq_ready':
>>> :(.text+0x32a20c): undefined reference to `of_cpufreq_cooling_register'
>>> drivers/built-in.o: In function `mtk_cpufreq_exit':
>>> :(.text+0x32a420): undefined reference to `cpufreq_cooling_unregister'
>>>
>>> The fix is similar to CPUFREQ_DT, but more restrictive since
>>> ARM_MT8173_CPUFREQ can not be built as module.
>>>
>>> Fixes: 1453863fb02a ("cpufreq: mediatek: Add MT8173 cpufreq driver")
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>> ---
>>> It might also make sense to declare ARM_MT8173_CPUFREQ as tristate
>>> and relax the conditions, but I don't know if that is feasible.
>>>
>>>   drivers/cpufreq/Kconfig.arm | 1 +
>>>   1 file changed, 1 insertion(+)
>>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Who's applying and sending this up to avoid extended period of build breakage?
>

Good question.

This one isn't really bad (yet), but there are other build and qemu test breakages
which have been in -next, sometimes for a long period of time, with patches
submitted but ignored by the maintainers. Those are creeping into mainline now.

Wonder if I (or someone else) should just collect those patches and send
a pull request to Linus right after (or even before) -rc1.

Guenter

[PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL

[Rafael J. Wysocki]

Hi,

On Fri, Sep 4, 2015 at 9:01 PM, Olof Johansson <olof@lixom.net> wrote:
> On Thu, Sep 3, 2015 at 8:50 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> On 03-09-15, 08:20, Guenter Roeck wrote:
>>> If ARM_MT8173_CPUFREQ is configured, and THERMAL is configured as module,
>>> the following build error is seen for arm:allmodconfig and
>>> arm64:allmodconfig.
>>>
>>> drivers/built-in.o: In function `mtk_cpufreq_ready':
>>> :(.text+0x32a20c): undefined reference to `of_cpufreq_cooling_register'
>>> drivers/built-in.o: In function `mtk_cpufreq_exit':
>>> :(.text+0x32a420): undefined reference to `cpufreq_cooling_unregister'
>>>
>>> The fix is similar to CPUFREQ_DT, but more restrictive since
>>> ARM_MT8173_CPUFREQ can not be built as module.
>>>
>>> Fixes: 1453863fb02a ("cpufreq: mediatek: Add MT8173 cpufreq driver")
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>> ---
>>> It might also make sense to declare ARM_MT8173_CPUFREQ as tristate
>>> and relax the conditions, but I don't know if that is feasible.
>>>
>>>  drivers/cpufreq/Kconfig.arm | 1 +
>>>  1 file changed, 1 insertion(+)
>>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Who's applying and sending this up to avoid extended period of build breakage?

I'll queue up this particular one.

Thanks,
Rafael