From mboxrd@z Thu Jan 1 00:00:00 1970 From: bayi.cheng@mediatek.com (bayi.cheng) Date: Fri, 11 Sep 2015 17:49:55 +0800 Subject: [PATCH 3/3] arm64: dts: mt8173: Add nor flash node In-Reply-To: References: <1441705796-11365-1-git-send-email-bayi.cheng@mediatek.com> <1441705796-11365-4-git-send-email-bayi.cheng@mediatek.com> Message-ID: <1441964995.23394.6.camel@mhfsdcap03> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2015-09-08 at 12:18 -0300, Ezequiel Garcia wrote: > On 8 September 2015 at 08:53, Jagan Teki wrote: > > On 8 September 2015 at 15:19, Bayi Cheng wrote: > >> Add Mediatek nor flash node > >> > >> Signed-off-by: Bayi Cheng > >> --- > >> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 10 ++++++++++ > >> 1 file changed, 10 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > >> index d18ee42..a14f005 100644 > >> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > >> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > >> @@ -365,6 +365,16 @@ > >> status = "disabled"; > >> }; > >> > >> + nor_flash: nor at 1100d000 { > > > > Based on the comments from 1/3 - this notation needs to be change something like > > qspi0: quadspi at 1100d000 > > > > Actually, to follow ePAPR recomendations it should be named as flash at 1100d000. > (See ePAPR, 2.2.2 Generic Names Recommendation). > > I believe the phandle name choice can be more descriptive. Thanks for your instruct, I will fix it in the next patch !