From: bayi.cheng@mediatek.com (bayi.cheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] doc: dt: add documentation for Mediatek spi-nor controller
Date: Tue, 15 Sep 2015 14:53:41 +0800 [thread overview]
Message-ID: <1442300021.27250.10.camel@mhfsdcap03> (raw)
In-Reply-To: <20150911214907.GE11487@google.com>
On Fri, 2015-09-11 at 14:49 -0700, Brian Norris wrote:
> One more thing:
>
> On Tue, Sep 08, 2015 at 05:49:54PM +0800, Bayi Cheng wrote:
> > +- clocks: spi nor source clock
>
> ^^ you only list one clock here
>
Ok, I will add other clocks
> > +- clock-names: "spi_clk", "axi_clk", "mux_clk", "sf_clk"
>
> But you have 4 names here.
>
> ...
> > + clocks = <&pericfg CLK_PERI_SPI>,
> > + <&topckgen CLK_TOP_AXI_SEL>,
> > + <&topckgen CLK_TOP_UNIVPLL2_D8>,
> > + <&topckgen CLK_TOP_SPINFI_IFR_SEL>;
>
> And you provide 4 clocks.
>
> > + clock-names = "spi_clk", "axi_clk", "mux_clk", "sf_clk";
>
> Please list all 4 under the "clocks" property, not just under the
> "clock-names" property.
>
OK, Thanks for your remind!
> Brian
next prev parent reply other threads:[~2015-09-15 6:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 9:49 [PATCH 0/3] Mediatek SPI-NOR flash driver Bayi Cheng
2015-09-08 9:49 ` [PATCH 1/3] doc: dt: add documentation for Mediatek spi-nor controller Bayi Cheng
2015-09-08 11:34 ` Jagan Teki
2015-09-15 6:49 ` bayi.cheng
2015-09-09 5:47 ` Sascha Hauer
2015-09-15 6:39 ` bayi.cheng
2015-09-11 21:47 ` Brian Norris
2015-09-11 21:49 ` Brian Norris
2015-09-15 6:53 ` bayi.cheng [this message]
2015-09-08 9:49 ` [PATCH 2/3] mtd: mtk-nor: mtk serial flash controller driver Bayi Cheng
2015-09-09 6:37 ` Sascha Hauer
2015-09-09 13:00 ` Lothar Waßmann
2015-09-15 16:37 ` bayi.cheng
2015-09-15 16:23 ` bayi.cheng
2015-09-08 9:49 ` [PATCH 3/3] arm64: dts: mt8173: Add nor flash node Bayi Cheng
2015-09-08 11:53 ` Jagan Teki
2015-09-08 15:18 ` Ezequiel Garcia
2015-09-08 23:46 ` Rob Herring
2015-09-11 9:51 ` bayi.cheng
2015-09-11 21:56 ` Brian Norris
2015-09-11 9:49 ` bayi.cheng
2015-09-11 9:47 ` bayi.cheng
-- strict thread matches above, loose matches on Subject: below --
2015-09-17 8:36 [PATCH 1/3] doc: dt: add documentation for Mediatek spi-nor controller Bayi Cheng
2015-09-17 9:02 ` bayi.cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442300021.27250.10.camel@mhfsdcap03 \
--to=bayi.cheng@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).