linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 6/7] clocksource/arm_arch_timer: Convert to ACPI probing
Date: Mon, 28 Sep 2015 15:49:17 +0100	[thread overview]
Message-ID: <1443451758-22717-7-git-send-email-marc.zyngier@arm.com> (raw)
In-Reply-To: <1443451758-22717-1-git-send-email-marc.zyngier@arm.com>

It is now absolutely trivial to convert the arch timer driver to
use ACPI probing, just like its DT counterpart.

Let's enjoy another crapectomy.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
 arch/arm64/kernel/time.c             |  6 ------
 drivers/clocksource/Kconfig          |  1 +
 drivers/clocksource/arm_arch_timer.c | 10 +---------
 include/linux/clocksource.h          |  6 ------
 4 files changed, 2 insertions(+), 21 deletions(-)

diff --git a/arch/arm64/kernel/time.c b/arch/arm64/kernel/time.c
index 149151f..819a105 100644
--- a/arch/arm64/kernel/time.c
+++ b/arch/arm64/kernel/time.c
@@ -71,12 +71,6 @@ void __init time_init(void)
 
 	tick_setup_hrtimer_broadcast();
 
-	/*
-	 * Since ACPI or FDT will only one be available in the system,
-	 * we can use acpi_generic_timer_init() here safely
-	 */
-	acpi_generic_timer_init();
-
 	arch_timer_rate = arch_timer_get_rate();
 	if (!arch_timer_rate)
 		panic("Unable to initialise architected timer.\n");
diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index fefedf1..1a9c5dc 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -131,6 +131,7 @@ config CLKSRC_STM32
 config ARM_ARCH_TIMER
 	bool
 	select CLKSRC_OF if OF
+	select CLKSRC_ACPI if ACPI
 
 config ARM_ARCH_TIMER_EVTSTREAM
 	bool "Support for ARM architected timer event stream generation"
diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index d6e3e49..c64d543 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -864,13 +864,5 @@ static int __init arch_timer_acpi_init(struct acpi_table_header *table)
 	arch_timer_init();
 	return 0;
 }
-
-/* Initialize all the generic timers presented in GTDT */
-void __init acpi_generic_timer_init(void)
-{
-	if (acpi_disabled)
-		return;
-
-	acpi_table_parse(ACPI_SIG_GTDT, arch_timer_acpi_init);
-}
+CLOCKSOURCE_ACPI_DECLARE(arch_timer, ACPI_SIG_GTDT, arch_timer_acpi_init);
 #endif
diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
index 6eab6ab..116645f 100644
--- a/include/linux/clocksource.h
+++ b/include/linux/clocksource.h
@@ -252,12 +252,6 @@ extern void clocksource_of_init(void);
 static inline void clocksource_of_init(void) {}
 #endif
 
-#ifdef CONFIG_ACPI
-void acpi_generic_timer_init(void);
-#else
-static inline void acpi_generic_timer_init(void) { }
-#endif
-
 #define CLOCKSOURCE_ACPI_DECLARE(name, table_id, fn)		\
 	ACPI_DECLARE_PROBE_ENTRY(clksrc, name, table_id, 0, NULL, 0, fn)
 
-- 
2.1.4

  parent reply	other threads:[~2015-09-28 14:49 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28 14:49 [PATCH v3 0/7] Early ACPI probing infrastructure Marc Zyngier
2015-09-28 14:49 ` [PATCH v3 1/7] acpi: Add early device " Marc Zyngier
2015-09-29  4:30   ` Daniel Lezcano
2015-09-29  7:29     ` Marc Zyngier
2015-09-29 12:17       ` Daniel Lezcano
2015-09-29 11:05   ` Lorenzo Pieralisi
2015-09-29 14:41   ` Hanjun Guo
2015-10-02 21:06   ` Wei Huang
2015-10-03 10:04     ` Marc Zyngier
2015-10-05 17:07       ` Wei Huang
2015-09-28 14:49 ` [PATCH v3 2/7] irqchip/acpi: Add probing infrastructure for ACPI-based irqchips Marc Zyngier
2015-09-29 10:19   ` Catalin Marinas
2015-09-29 14:42   ` Hanjun Guo
2015-09-28 14:49 ` [PATCH v3 3/7] irqchip/gic: Convert the GIC driver to ACPI probing Marc Zyngier
2015-09-29 10:20   ` Catalin Marinas
2015-09-29 15:01   ` Hanjun Guo
2015-09-28 14:49 ` [PATCH v3 4/7] clocksource/acpi: Add probing infrastructure for ACPI-based clocksources Marc Zyngier
2015-09-28 14:49 ` [PATCH v3 5/7] clocksource: Add new CLKSRC_{PROBE, ACPI} config symbols Marc Zyngier
2015-09-28 14:49 ` Marc Zyngier [this message]
2015-09-29 10:26   ` [PATCH v3 6/7] clocksource/arm_arch_timer: Convert to ACPI probing Catalin Marinas
2015-09-28 14:49 ` [PATCH v3 7/7] clocksource: cosmetic: Drop OF 'dependency' from symbols Marc Zyngier
2015-09-29 10:27   ` Catalin Marinas
2015-09-29 15:14   ` Hanjun Guo
2015-09-28 22:46 ` [PATCH v3 0/7] Early ACPI probing infrastructure Rafael J. Wysocki
2015-09-30 10:44   ` Thomas Gleixner
2015-10-05 13:37     ` Rafael J. Wysocki
2015-09-29 15:25 ` Hanjun Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443451758-22717-7-git-send-email-marc.zyngier@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).