From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v2 2/2] ARM: imx6: change default burst size for USB
Date: Wed, 30 Sep 2015 10:52:39 +0200 [thread overview]
Message-ID: <1443603159.3185.5.camel@pengutronix.de> (raw)
In-Reply-To: <1443579437-845-2-git-send-email-peter.chen@freescale.com>
Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
> It can improve the USB performance when choosing larger
> burst size at some systems (bus size is larger), there is
> no side effect if this burst size is larger than bus size.
>
Just for the record, as it seems too late to stop the train now:
I am _NOT_ happy that the extended binding has been accepted into the
USB tree despite outstanding review comments from me not being addressed
or even answered.
> Signed-off-by: Peter Chen <peter.chen@freescale.com>
> ---
>
> Changes for v2:
> - Applies changes for imx6ul
>
> arch/arm/boot/dts/imx6qdl.dtsi | 8 ++++++++
> arch/arm/boot/dts/imx6sl.dtsi | 6 ++++++
> arch/arm/boot/dts/imx6sx.dtsi | 6 ++++++
> arch/arm/boot/dts/imx6ul.dtsi | 4 ++++
> 4 files changed, 24 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 3d04a17..92c5cc0 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -907,6 +907,8 @@
> fsl,usbphy = <&usbphy1>;
> fsl,usbmisc = <&usbmisc 0>;
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> @@ -919,6 +921,8 @@
> fsl,usbmisc = <&usbmisc 1>;
> dr_mode = "host";
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> @@ -930,6 +934,8 @@
> fsl,usbmisc = <&usbmisc 2>;
> dr_mode = "host";
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> @@ -941,6 +947,8 @@
> fsl,usbmisc = <&usbmisc 3>;
> dr_mode = "host";
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 057b1d4..2c0faeb 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -690,6 +690,8 @@
> fsl,usbphy = <&usbphy1>;
> fsl,usbmisc = <&usbmisc 0>;
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> @@ -701,6 +703,8 @@
> fsl,usbphy = <&usbphy2>;
> fsl,usbmisc = <&usbmisc 1>;
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> @@ -712,6 +716,8 @@
> fsl,usbmisc = <&usbmisc 2>;
> dr_mode = "host";
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 70a7c4f..01191c0 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -784,6 +784,8 @@
> fsl,usbmisc = <&usbmisc 0>;
> fsl,anatop = <&anatop>;
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> @@ -795,6 +797,8 @@
> fsl,usbphy = <&usbphy2>;
> fsl,usbmisc = <&usbmisc 1>;
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> @@ -808,6 +812,8 @@
> fsl,anatop = <&anatop>;
> dr_mode = "host";
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index 654009f..28dcd68 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -536,6 +536,8 @@
> fsl,usbmisc = <&usbmisc 0>;
> fsl,anatop = <&anatop>;
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> @@ -547,6 +549,8 @@
> fsl,usbphy = <&usbphy2>;
> fsl,usbmisc = <&usbmisc 1>;
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-09-30 8:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 2:17 [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 for USB Peter Chen
2015-09-30 2:17 ` [RESEND PATCH v2 2/2] ARM: imx6: change default burst size " Peter Chen
2015-09-30 8:52 ` Lucas Stach [this message]
2015-09-30 13:37 ` Shawn Guo
2015-10-20 7:07 ` Peter Chen
2015-10-20 8:41 ` Lucas Stach
2015-11-18 8:33 ` Peter Chen
2015-10-01 8:13 ` Peter Chen
2015-10-01 8:42 ` Lucas Stach
2015-10-01 10:51 ` Peter Chen
2015-09-30 5:24 ` [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 " Shawn Guo
2015-11-23 0:53 ` Shawn Guo
2015-11-23 1:57 ` Peter Chen
2015-11-23 6:24 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443603159.3185.5.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).