From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v2 2/2] ARM: imx6: change default burst size for USB
Date: Thu, 01 Oct 2015 10:42:30 +0200 [thread overview]
Message-ID: <1443688950.8574.7.camel@pengutronix.de> (raw)
In-Reply-To: <CAL411-p-V=p8g9ckxewNzZ7kG+ChbgewSn8V8n1kmw7DqU0hZw@mail.gmail.com>
Am Donnerstag, den 01.10.2015, 16:13 +0800 schrieb Peter Chen:
> On Wed, Sep 30, 2015 at 4:52 PM, Lucas Stach <l.stach@pengutronix.de> wrote:
> > Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
> >> It can improve the USB performance when choosing larger
> >> burst size at some systems (bus size is larger), there is
> >> no side effect if this burst size is larger than bus size.
> >>
> > Just for the record, as it seems too late to stop the train now:
> >
> > I am _NOT_ happy that the extended binding has been accepted into the
> > USB tree despite outstanding review comments from me not being addressed
> > or even answered.
> >
>
> I sent patch for review at Aug 7th, queued this patches at Aug 13th
> [1], and sent pull
> request at Aug 14th, I am curious why you did not give comments
> between this period utill
> I complained one ethernet patch breaks i.mx ethernet function for v4.2
> tree [2] at Aug 14th.
>
What do the USB changes have to do with any ethernet changes?
The comments I'm referring to are from Aug 14th
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/364396.html
So you are telling me that giving reviewers not even a week before
sending the pull request is appropriate? And that sending the pull
despite there being open review comments is ok? Think again.
> I will consider your comments, and send patch for improving it if possible.
>
As I said it may be too late now. By sending the pull request including
the binding change you forced everyone to now either accept the (in my
opinion not really perfect) binding, or hurry to change it in the
current RC phase, something which I'm not comfortable with. The damage
has been done.
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/364352.html
> [2] http://marc.info/?l=linux-netdev&m=143954500409636&w=2
>
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2015-10-01 8:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 2:17 [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 for USB Peter Chen
2015-09-30 2:17 ` [RESEND PATCH v2 2/2] ARM: imx6: change default burst size " Peter Chen
2015-09-30 8:52 ` Lucas Stach
2015-09-30 13:37 ` Shawn Guo
2015-10-20 7:07 ` Peter Chen
2015-10-20 8:41 ` Lucas Stach
2015-11-18 8:33 ` Peter Chen
2015-10-01 8:13 ` Peter Chen
2015-10-01 8:42 ` Lucas Stach [this message]
2015-10-01 10:51 ` Peter Chen
2015-09-30 5:24 ` [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 " Shawn Guo
2015-11-23 0:53 ` Shawn Guo
2015-11-23 1:57 ` Peter Chen
2015-11-23 6:24 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443688950.8574.7.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).