* [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 for USB
@ 2015-09-30 2:17 Peter Chen
2015-09-30 2:17 ` [RESEND PATCH v2 2/2] ARM: imx6: change default burst size " Peter Chen
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Peter Chen @ 2015-09-30 2:17 UTC (permalink / raw)
To: linux-arm-kernel
After setting ahb burst configuration as 0, we can increase tx/rx
burst size, it will improve the USB performance
Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
Changes for v2:
- Applies changes for imx6ul
arch/arm/boot/dts/imx6qdl.dtsi | 4 ++++
arch/arm/boot/dts/imx6sl.dtsi | 3 +++
arch/arm/boot/dts/imx6sx.dtsi | 3 +++
arch/arm/boot/dts/imx6ul.dtsi | 2 ++
4 files changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index e716e6f..3d04a17 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -906,6 +906,7 @@
clocks = <&clks IMX6QDL_CLK_USBOH3>;
fsl,usbphy = <&usbphy1>;
fsl,usbmisc = <&usbmisc 0>;
+ ahb-burst-config = <0x0>;
status = "disabled";
};
@@ -917,6 +918,7 @@
fsl,usbphy = <&usbphy2>;
fsl,usbmisc = <&usbmisc 1>;
dr_mode = "host";
+ ahb-burst-config = <0x0>;
status = "disabled";
};
@@ -927,6 +929,7 @@
clocks = <&clks IMX6QDL_CLK_USBOH3>;
fsl,usbmisc = <&usbmisc 2>;
dr_mode = "host";
+ ahb-burst-config = <0x0>;
status = "disabled";
};
@@ -937,6 +940,7 @@
clocks = <&clks IMX6QDL_CLK_USBOH3>;
fsl,usbmisc = <&usbmisc 3>;
dr_mode = "host";
+ ahb-burst-config = <0x0>;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
index 320a27f..057b1d4 100644
--- a/arch/arm/boot/dts/imx6sl.dtsi
+++ b/arch/arm/boot/dts/imx6sl.dtsi
@@ -689,6 +689,7 @@
clocks = <&clks IMX6SL_CLK_USBOH3>;
fsl,usbphy = <&usbphy1>;
fsl,usbmisc = <&usbmisc 0>;
+ ahb-burst-config = <0x0>;
status = "disabled";
};
@@ -699,6 +700,7 @@
clocks = <&clks IMX6SL_CLK_USBOH3>;
fsl,usbphy = <&usbphy2>;
fsl,usbmisc = <&usbmisc 1>;
+ ahb-burst-config = <0x0>;
status = "disabled";
};
@@ -709,6 +711,7 @@
clocks = <&clks IMX6SL_CLK_USBOH3>;
fsl,usbmisc = <&usbmisc 2>;
dr_mode = "host";
+ ahb-burst-config = <0x0>;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index c94f2ea..70a7c4f 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/arm/boot/dts/imx6sx.dtsi
@@ -783,6 +783,7 @@
fsl,usbphy = <&usbphy1>;
fsl,usbmisc = <&usbmisc 0>;
fsl,anatop = <&anatop>;
+ ahb-burst-config = <0x0>;
status = "disabled";
};
@@ -793,6 +794,7 @@
clocks = <&clks IMX6SX_CLK_USBOH3>;
fsl,usbphy = <&usbphy2>;
fsl,usbmisc = <&usbmisc 1>;
+ ahb-burst-config = <0x0>;
status = "disabled";
};
@@ -805,6 +807,7 @@
phy_type = "hsic";
fsl,anatop = <&anatop>;
dr_mode = "host";
+ ahb-burst-config = <0x0>;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
index 09edbed..654009f 100644
--- a/arch/arm/boot/dts/imx6ul.dtsi
+++ b/arch/arm/boot/dts/imx6ul.dtsi
@@ -535,6 +535,7 @@
fsl,usbphy = <&usbphy1>;
fsl,usbmisc = <&usbmisc 0>;
fsl,anatop = <&anatop>;
+ ahb-burst-config = <0x0>;
status = "disabled";
};
@@ -545,6 +546,7 @@
clocks = <&clks IMX6UL_CLK_USBOH3>;
fsl,usbphy = <&usbphy2>;
fsl,usbmisc = <&usbmisc 1>;
+ ahb-burst-config = <0x0>;
status = "disabled";
};
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [RESEND PATCH v2 2/2] ARM: imx6: change default burst size for USB
2015-09-30 2:17 [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 for USB Peter Chen
@ 2015-09-30 2:17 ` Peter Chen
2015-09-30 8:52 ` Lucas Stach
2015-09-30 5:24 ` [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 " Shawn Guo
2015-11-23 0:53 ` Shawn Guo
2 siblings, 1 reply; 14+ messages in thread
From: Peter Chen @ 2015-09-30 2:17 UTC (permalink / raw)
To: linux-arm-kernel
It can improve the USB performance when choosing larger
burst size at some systems (bus size is larger), there is
no side effect if this burst size is larger than bus size.
Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
Changes for v2:
- Applies changes for imx6ul
arch/arm/boot/dts/imx6qdl.dtsi | 8 ++++++++
arch/arm/boot/dts/imx6sl.dtsi | 6 ++++++
arch/arm/boot/dts/imx6sx.dtsi | 6 ++++++
arch/arm/boot/dts/imx6ul.dtsi | 4 ++++
4 files changed, 24 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index 3d04a17..92c5cc0 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -907,6 +907,8 @@
fsl,usbphy = <&usbphy1>;
fsl,usbmisc = <&usbmisc 0>;
ahb-burst-config = <0x0>;
+ tx-burst-size-dword = <0x10>;
+ rx-burst-size-dword = <0x10>;
status = "disabled";
};
@@ -919,6 +921,8 @@
fsl,usbmisc = <&usbmisc 1>;
dr_mode = "host";
ahb-burst-config = <0x0>;
+ tx-burst-size-dword = <0x10>;
+ rx-burst-size-dword = <0x10>;
status = "disabled";
};
@@ -930,6 +934,8 @@
fsl,usbmisc = <&usbmisc 2>;
dr_mode = "host";
ahb-burst-config = <0x0>;
+ tx-burst-size-dword = <0x10>;
+ rx-burst-size-dword = <0x10>;
status = "disabled";
};
@@ -941,6 +947,8 @@
fsl,usbmisc = <&usbmisc 3>;
dr_mode = "host";
ahb-burst-config = <0x0>;
+ tx-burst-size-dword = <0x10>;
+ rx-burst-size-dword = <0x10>;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
index 057b1d4..2c0faeb 100644
--- a/arch/arm/boot/dts/imx6sl.dtsi
+++ b/arch/arm/boot/dts/imx6sl.dtsi
@@ -690,6 +690,8 @@
fsl,usbphy = <&usbphy1>;
fsl,usbmisc = <&usbmisc 0>;
ahb-burst-config = <0x0>;
+ tx-burst-size-dword = <0x10>;
+ rx-burst-size-dword = <0x10>;
status = "disabled";
};
@@ -701,6 +703,8 @@
fsl,usbphy = <&usbphy2>;
fsl,usbmisc = <&usbmisc 1>;
ahb-burst-config = <0x0>;
+ tx-burst-size-dword = <0x10>;
+ rx-burst-size-dword = <0x10>;
status = "disabled";
};
@@ -712,6 +716,8 @@
fsl,usbmisc = <&usbmisc 2>;
dr_mode = "host";
ahb-burst-config = <0x0>;
+ tx-burst-size-dword = <0x10>;
+ rx-burst-size-dword = <0x10>;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index 70a7c4f..01191c0 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/arm/boot/dts/imx6sx.dtsi
@@ -784,6 +784,8 @@
fsl,usbmisc = <&usbmisc 0>;
fsl,anatop = <&anatop>;
ahb-burst-config = <0x0>;
+ tx-burst-size-dword = <0x10>;
+ rx-burst-size-dword = <0x10>;
status = "disabled";
};
@@ -795,6 +797,8 @@
fsl,usbphy = <&usbphy2>;
fsl,usbmisc = <&usbmisc 1>;
ahb-burst-config = <0x0>;
+ tx-burst-size-dword = <0x10>;
+ rx-burst-size-dword = <0x10>;
status = "disabled";
};
@@ -808,6 +812,8 @@
fsl,anatop = <&anatop>;
dr_mode = "host";
ahb-burst-config = <0x0>;
+ tx-burst-size-dword = <0x10>;
+ rx-burst-size-dword = <0x10>;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
index 654009f..28dcd68 100644
--- a/arch/arm/boot/dts/imx6ul.dtsi
+++ b/arch/arm/boot/dts/imx6ul.dtsi
@@ -536,6 +536,8 @@
fsl,usbmisc = <&usbmisc 0>;
fsl,anatop = <&anatop>;
ahb-burst-config = <0x0>;
+ tx-burst-size-dword = <0x10>;
+ rx-burst-size-dword = <0x10>;
status = "disabled";
};
@@ -547,6 +549,8 @@
fsl,usbphy = <&usbphy2>;
fsl,usbmisc = <&usbmisc 1>;
ahb-burst-config = <0x0>;
+ tx-burst-size-dword = <0x10>;
+ rx-burst-size-dword = <0x10>;
status = "disabled";
};
--
1.9.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [RESEND PATCH v2 2/2] ARM: imx6: change default burst size for USB
2015-09-30 2:17 ` [RESEND PATCH v2 2/2] ARM: imx6: change default burst size " Peter Chen
@ 2015-09-30 8:52 ` Lucas Stach
2015-09-30 13:37 ` Shawn Guo
2015-10-01 8:13 ` Peter Chen
0 siblings, 2 replies; 14+ messages in thread
From: Lucas Stach @ 2015-09-30 8:52 UTC (permalink / raw)
To: linux-arm-kernel
Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
> It can improve the USB performance when choosing larger
> burst size at some systems (bus size is larger), there is
> no side effect if this burst size is larger than bus size.
>
Just for the record, as it seems too late to stop the train now:
I am _NOT_ happy that the extended binding has been accepted into the
USB tree despite outstanding review comments from me not being addressed
or even answered.
> Signed-off-by: Peter Chen <peter.chen@freescale.com>
> ---
>
> Changes for v2:
> - Applies changes for imx6ul
>
> arch/arm/boot/dts/imx6qdl.dtsi | 8 ++++++++
> arch/arm/boot/dts/imx6sl.dtsi | 6 ++++++
> arch/arm/boot/dts/imx6sx.dtsi | 6 ++++++
> arch/arm/boot/dts/imx6ul.dtsi | 4 ++++
> 4 files changed, 24 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 3d04a17..92c5cc0 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -907,6 +907,8 @@
> fsl,usbphy = <&usbphy1>;
> fsl,usbmisc = <&usbmisc 0>;
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> @@ -919,6 +921,8 @@
> fsl,usbmisc = <&usbmisc 1>;
> dr_mode = "host";
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> @@ -930,6 +934,8 @@
> fsl,usbmisc = <&usbmisc 2>;
> dr_mode = "host";
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> @@ -941,6 +947,8 @@
> fsl,usbmisc = <&usbmisc 3>;
> dr_mode = "host";
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 057b1d4..2c0faeb 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -690,6 +690,8 @@
> fsl,usbphy = <&usbphy1>;
> fsl,usbmisc = <&usbmisc 0>;
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> @@ -701,6 +703,8 @@
> fsl,usbphy = <&usbphy2>;
> fsl,usbmisc = <&usbmisc 1>;
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> @@ -712,6 +716,8 @@
> fsl,usbmisc = <&usbmisc 2>;
> dr_mode = "host";
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 70a7c4f..01191c0 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -784,6 +784,8 @@
> fsl,usbmisc = <&usbmisc 0>;
> fsl,anatop = <&anatop>;
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> @@ -795,6 +797,8 @@
> fsl,usbphy = <&usbphy2>;
> fsl,usbmisc = <&usbmisc 1>;
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> @@ -808,6 +812,8 @@
> fsl,anatop = <&anatop>;
> dr_mode = "host";
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index 654009f..28dcd68 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -536,6 +536,8 @@
> fsl,usbmisc = <&usbmisc 0>;
> fsl,anatop = <&anatop>;
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
> @@ -547,6 +549,8 @@
> fsl,usbphy = <&usbphy2>;
> fsl,usbmisc = <&usbmisc 1>;
> ahb-burst-config = <0x0>;
> + tx-burst-size-dword = <0x10>;
> + rx-burst-size-dword = <0x10>;
> status = "disabled";
> };
>
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 14+ messages in thread
* [RESEND PATCH v2 2/2] ARM: imx6: change default burst size for USB
2015-09-30 8:52 ` Lucas Stach
@ 2015-09-30 13:37 ` Shawn Guo
2015-10-20 7:07 ` Peter Chen
2015-10-01 8:13 ` Peter Chen
1 sibling, 1 reply; 14+ messages in thread
From: Shawn Guo @ 2015-09-30 13:37 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 30, 2015 at 10:52:39AM +0200, Lucas Stach wrote:
> Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
> > It can improve the USB performance when choosing larger
> > burst size at some systems (bus size is larger), there is
> > no side effect if this burst size is larger than bus size.
> >
> Just for the record, as it seems too late to stop the train now:
>
> I am _NOT_ happy that the extended binding has been accepted into the
> USB tree despite outstanding review comments from me not being addressed
> or even answered.
Okay. I'm not aware of this. I'm dropping the patches until everyone
agrees with it.
Shawn
^ permalink raw reply [flat|nested] 14+ messages in thread
* [RESEND PATCH v2 2/2] ARM: imx6: change default burst size for USB
2015-09-30 13:37 ` Shawn Guo
@ 2015-10-20 7:07 ` Peter Chen
2015-10-20 8:41 ` Lucas Stach
0 siblings, 1 reply; 14+ messages in thread
From: Peter Chen @ 2015-10-20 7:07 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 30, 2015 at 09:37:12PM +0800, Shawn Guo wrote:
> On Wed, Sep 30, 2015 at 10:52:39AM +0200, Lucas Stach wrote:
> > Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
> > > It can improve the USB performance when choosing larger
> > > burst size at some systems (bus size is larger), there is
> > > no side effect if this burst size is larger than bus size.
> > >
> > Just for the record, as it seems too late to stop the train now:
> >
> > I am _NOT_ happy that the extended binding has been accepted into the
> > USB tree despite outstanding review comments from me not being addressed
> > or even answered.
>
> Okay. I'm not aware of this. I'm dropping the patches until everyone
> agrees with it.
>
Hi Shawn & Lucas, I sent the improvement patch for dt description following
Lucas's comment one week ago at below:
https://www.spinics.net/lists/linux-usb/msg131150.html
If no more comments, queue my dts patches please.
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 14+ messages in thread
* [RESEND PATCH v2 2/2] ARM: imx6: change default burst size for USB
2015-10-20 7:07 ` Peter Chen
@ 2015-10-20 8:41 ` Lucas Stach
2015-11-18 8:33 ` Peter Chen
0 siblings, 1 reply; 14+ messages in thread
From: Lucas Stach @ 2015-10-20 8:41 UTC (permalink / raw)
To: linux-arm-kernel
Hi Shawn,
Am Dienstag, den 20.10.2015, 15:07 +0800 schrieb Peter Chen:
> On Wed, Sep 30, 2015 at 09:37:12PM +0800, Shawn Guo wrote:
> > On Wed, Sep 30, 2015 at 10:52:39AM +0200, Lucas Stach wrote:
> > > Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
> > > > It can improve the USB performance when choosing larger
> > > > burst size at some systems (bus size is larger), there is
> > > > no side effect if this burst size is larger than bus size.
> > > >
> > > Just for the record, as it seems too late to stop the train now:
> > >
> > > I am _NOT_ happy that the extended binding has been accepted into the
> > > USB tree despite outstanding review comments from me not being addressed
> > > or even answered.
> >
> > Okay. I'm not aware of this. I'm dropping the patches until everyone
> > agrees with it.
> >
>
> Hi Shawn & Lucas, I sent the improvement patch for dt description following
> Lucas's comment one week ago at below:
>
> https://www.spinics.net/lists/linux-usb/msg131150.html
>
> If no more comments, queue my dts patches please.
>
While the binding hasn't received a good review in time it is already in
a released kernel and I'm not going to argue to change it now after the
fact (violating the DT stability rules) just to satisfy my rather minor
comments. I want to make clear that I was not happy by how this stuff
has been handled with the USB tree and it is my hope that this can be
improved for future binding changes.
But please don't hold those DTS patches any longer. The binding is in,
there is no point in not applying the corresponding patches.
Regards,
Lucas
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 14+ messages in thread
* [RESEND PATCH v2 2/2] ARM: imx6: change default burst size for USB
2015-10-20 8:41 ` Lucas Stach
@ 2015-11-18 8:33 ` Peter Chen
0 siblings, 0 replies; 14+ messages in thread
From: Peter Chen @ 2015-11-18 8:33 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 20, 2015 at 10:41:49AM +0200, Lucas Stach wrote:
> Hi Shawn,
>
> Am Dienstag, den 20.10.2015, 15:07 +0800 schrieb Peter Chen:
> > On Wed, Sep 30, 2015 at 09:37:12PM +0800, Shawn Guo wrote:
> > > On Wed, Sep 30, 2015 at 10:52:39AM +0200, Lucas Stach wrote:
> > > > Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
> > > > > It can improve the USB performance when choosing larger
> > > > > burst size at some systems (bus size is larger), there is
> > > > > no side effect if this burst size is larger than bus size.
> > > > >
> > > > Just for the record, as it seems too late to stop the train now:
> > > >
> > > > I am _NOT_ happy that the extended binding has been accepted into the
> > > > USB tree despite outstanding review comments from me not being addressed
> > > > or even answered.
> > >
> > > Okay. I'm not aware of this. I'm dropping the patches until everyone
> > > agrees with it.
> > >
> >
> > Hi Shawn & Lucas, I sent the improvement patch for dt description following
> > Lucas's comment one week ago at below:
> >
> > https://www.spinics.net/lists/linux-usb/msg131150.html
> >
> > If no more comments, queue my dts patches please.
> >
> While the binding hasn't received a good review in time it is already in
> a released kernel and I'm not going to argue to change it now after the
> fact (violating the DT stability rules) just to satisfy my rather minor
> comments. I want to make clear that I was not happy by how this stuff
> has been handled with the USB tree and it is my hope that this can be
> improved for future binding changes.
>
> But please don't hold those DTS patches any longer. The binding is in,
> there is no point in not applying the corresponding patches.
>
> Regards,
> Lucas
>
Ping...
Shawn, I still not see these dt changes in your tree
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 14+ messages in thread
* [RESEND PATCH v2 2/2] ARM: imx6: change default burst size for USB
2015-09-30 8:52 ` Lucas Stach
2015-09-30 13:37 ` Shawn Guo
@ 2015-10-01 8:13 ` Peter Chen
2015-10-01 8:42 ` Lucas Stach
1 sibling, 1 reply; 14+ messages in thread
From: Peter Chen @ 2015-10-01 8:13 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 30, 2015 at 4:52 PM, Lucas Stach <l.stach@pengutronix.de> wrote:
> Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
>> It can improve the USB performance when choosing larger
>> burst size at some systems (bus size is larger), there is
>> no side effect if this burst size is larger than bus size.
>>
> Just for the record, as it seems too late to stop the train now:
>
> I am _NOT_ happy that the extended binding has been accepted into the
> USB tree despite outstanding review comments from me not being addressed
> or even answered.
>
I sent patch for review at Aug 7th, queued this patches at Aug 13th
[1], and sent pull
request at Aug 14th, I am curious why you did not give comments
between this period utill
I complained one ethernet patch breaks i.mx ethernet function for v4.2
tree [2] at Aug 14th.
I will consider your comments, and send patch for improving it if possible.
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/364352.html
[2] http://marc.info/?l=linux-netdev&m=143954500409636&w=2
>> Signed-off-by: Peter Chen <peter.chen@freescale.com>
>> ---
>>
>> Changes for v2:
>> - Applies changes for imx6ul
>>
>> arch/arm/boot/dts/imx6qdl.dtsi | 8 ++++++++
>> arch/arm/boot/dts/imx6sl.dtsi | 6 ++++++
>> arch/arm/boot/dts/imx6sx.dtsi | 6 ++++++
>> arch/arm/boot/dts/imx6ul.dtsi | 4 ++++
>> 4 files changed, 24 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
>> index 3d04a17..92c5cc0 100644
>> --- a/arch/arm/boot/dts/imx6qdl.dtsi
>> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
>> @@ -907,6 +907,8 @@
>> fsl,usbphy = <&usbphy1>;
>> fsl,usbmisc = <&usbmisc 0>;
>> ahb-burst-config = <0x0>;
>> + tx-burst-size-dword = <0x10>;
>> + rx-burst-size-dword = <0x10>;
>> status = "disabled";
>> };
>>
>> @@ -919,6 +921,8 @@
>> fsl,usbmisc = <&usbmisc 1>;
>> dr_mode = "host";
>> ahb-burst-config = <0x0>;
>> + tx-burst-size-dword = <0x10>;
>> + rx-burst-size-dword = <0x10>;
>> status = "disabled";
>> };
>>
>> @@ -930,6 +934,8 @@
>> fsl,usbmisc = <&usbmisc 2>;
>> dr_mode = "host";
>> ahb-burst-config = <0x0>;
>> + tx-burst-size-dword = <0x10>;
>> + rx-burst-size-dword = <0x10>;
>> status = "disabled";
>> };
>>
>> @@ -941,6 +947,8 @@
>> fsl,usbmisc = <&usbmisc 3>;
>> dr_mode = "host";
>> ahb-burst-config = <0x0>;
>> + tx-burst-size-dword = <0x10>;
>> + rx-burst-size-dword = <0x10>;
>> status = "disabled";
>> };
>>
>> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
>> index 057b1d4..2c0faeb 100644
>> --- a/arch/arm/boot/dts/imx6sl.dtsi
>> +++ b/arch/arm/boot/dts/imx6sl.dtsi
>> @@ -690,6 +690,8 @@
>> fsl,usbphy = <&usbphy1>;
>> fsl,usbmisc = <&usbmisc 0>;
>> ahb-burst-config = <0x0>;
>> + tx-burst-size-dword = <0x10>;
>> + rx-burst-size-dword = <0x10>;
>> status = "disabled";
>> };
>>
>> @@ -701,6 +703,8 @@
>> fsl,usbphy = <&usbphy2>;
>> fsl,usbmisc = <&usbmisc 1>;
>> ahb-burst-config = <0x0>;
>> + tx-burst-size-dword = <0x10>;
>> + rx-burst-size-dword = <0x10>;
>> status = "disabled";
>> };
>>
>> @@ -712,6 +716,8 @@
>> fsl,usbmisc = <&usbmisc 2>;
>> dr_mode = "host";
>> ahb-burst-config = <0x0>;
>> + tx-burst-size-dword = <0x10>;
>> + rx-burst-size-dword = <0x10>;
>> status = "disabled";
>> };
>>
>> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
>> index 70a7c4f..01191c0 100644
>> --- a/arch/arm/boot/dts/imx6sx.dtsi
>> +++ b/arch/arm/boot/dts/imx6sx.dtsi
>> @@ -784,6 +784,8 @@
>> fsl,usbmisc = <&usbmisc 0>;
>> fsl,anatop = <&anatop>;
>> ahb-burst-config = <0x0>;
>> + tx-burst-size-dword = <0x10>;
>> + rx-burst-size-dword = <0x10>;
>> status = "disabled";
>> };
>>
>> @@ -795,6 +797,8 @@
>> fsl,usbphy = <&usbphy2>;
>> fsl,usbmisc = <&usbmisc 1>;
>> ahb-burst-config = <0x0>;
>> + tx-burst-size-dword = <0x10>;
>> + rx-burst-size-dword = <0x10>;
>> status = "disabled";
>> };
>>
>> @@ -808,6 +812,8 @@
>> fsl,anatop = <&anatop>;
>> dr_mode = "host";
>> ahb-burst-config = <0x0>;
>> + tx-burst-size-dword = <0x10>;
>> + rx-burst-size-dword = <0x10>;
>> status = "disabled";
>> };
>>
>> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
>> index 654009f..28dcd68 100644
>> --- a/arch/arm/boot/dts/imx6ul.dtsi
>> +++ b/arch/arm/boot/dts/imx6ul.dtsi
>> @@ -536,6 +536,8 @@
>> fsl,usbmisc = <&usbmisc 0>;
>> fsl,anatop = <&anatop>;
>> ahb-burst-config = <0x0>;
>> + tx-burst-size-dword = <0x10>;
>> + rx-burst-size-dword = <0x10>;
>> status = "disabled";
>> };
>>
>> @@ -547,6 +549,8 @@
>> fsl,usbphy = <&usbphy2>;
>> fsl,usbmisc = <&usbmisc 1>;
>> ahb-burst-config = <0x0>;
>> + tx-burst-size-dword = <0x10>;
>> + rx-burst-size-dword = <0x10>;
>> status = "disabled";
>> };
>>
>
> --
> Pengutronix e.K. | Lucas Stach |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
BR,
Peter Chen
^ permalink raw reply [flat|nested] 14+ messages in thread
* [RESEND PATCH v2 2/2] ARM: imx6: change default burst size for USB
2015-10-01 8:13 ` Peter Chen
@ 2015-10-01 8:42 ` Lucas Stach
2015-10-01 10:51 ` Peter Chen
0 siblings, 1 reply; 14+ messages in thread
From: Lucas Stach @ 2015-10-01 8:42 UTC (permalink / raw)
To: linux-arm-kernel
Am Donnerstag, den 01.10.2015, 16:13 +0800 schrieb Peter Chen:
> On Wed, Sep 30, 2015 at 4:52 PM, Lucas Stach <l.stach@pengutronix.de> wrote:
> > Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
> >> It can improve the USB performance when choosing larger
> >> burst size at some systems (bus size is larger), there is
> >> no side effect if this burst size is larger than bus size.
> >>
> > Just for the record, as it seems too late to stop the train now:
> >
> > I am _NOT_ happy that the extended binding has been accepted into the
> > USB tree despite outstanding review comments from me not being addressed
> > or even answered.
> >
>
> I sent patch for review at Aug 7th, queued this patches at Aug 13th
> [1], and sent pull
> request at Aug 14th, I am curious why you did not give comments
> between this period utill
> I complained one ethernet patch breaks i.mx ethernet function for v4.2
> tree [2] at Aug 14th.
>
What do the USB changes have to do with any ethernet changes?
The comments I'm referring to are from Aug 14th
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/364396.html
So you are telling me that giving reviewers not even a week before
sending the pull request is appropriate? And that sending the pull
despite there being open review comments is ok? Think again.
> I will consider your comments, and send patch for improving it if possible.
>
As I said it may be too late now. By sending the pull request including
the binding change you forced everyone to now either accept the (in my
opinion not really perfect) binding, or hurry to change it in the
current RC phase, something which I'm not comfortable with. The damage
has been done.
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/364352.html
> [2] http://marc.info/?l=linux-netdev&m=143954500409636&w=2
>
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 14+ messages in thread
* [RESEND PATCH v2 2/2] ARM: imx6: change default burst size for USB
2015-10-01 8:42 ` Lucas Stach
@ 2015-10-01 10:51 ` Peter Chen
0 siblings, 0 replies; 14+ messages in thread
From: Peter Chen @ 2015-10-01 10:51 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 1, 2015 at 4:42 PM, Lucas Stach <l.stach@pengutronix.de> wrote:
> Am Donnerstag, den 01.10.2015, 16:13 +0800 schrieb Peter Chen:
>> On Wed, Sep 30, 2015 at 4:52 PM, Lucas Stach <l.stach@pengutronix.de> wrote:
>> > Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
>> >> It can improve the USB performance when choosing larger
>> >> burst size at some systems (bus size is larger), there is
>> >> no side effect if this burst size is larger than bus size.
>> >>
>> > Just for the record, as it seems too late to stop the train now:
>> >
>> > I am _NOT_ happy that the extended binding has been accepted into the
>> > USB tree despite outstanding review comments from me not being addressed
>> > or even answered.
>> >
>>
>> I sent patch for review at Aug 7th, queued this patches at Aug 13th
>> [1], and sent pull
>> request at Aug 14th, I am curious why you did not give comments
>> between this period utill
>> I complained one ethernet patch breaks i.mx ethernet function for v4.2
>> tree [2] at Aug 14th.
>>
> What do the USB changes have to do with any ethernet changes?
>
> The comments I'm referring to are from Aug 14th
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/364396.html
>
> So you are telling me that giving reviewers not even a week before
> sending the pull request is appropriate? And that sending the pull
> despite there being open review comments is ok? Think again.
>
Comments are welcome at anytime, but why you are __NOT__ happy it
was accepted and your comments were delayed. If you think this binding
description is not ok, patch is welcome.
>> I will consider your comments, and send patch for improving it if possible.
>>
> As I said it may be too late now. By sending the pull request including
> the binding change you forced everyone to now either accept the (in my
> opinion not really perfect) binding, or hurry to change it in the
> current RC phase, something which I'm not comfortable with. The damage
> has been done.
>
Again, I waited one week, and your comments were late. I do not want
to dispute more at our holidays. Let's stop here.
--
BR,
Peter Chen
^ permalink raw reply [flat|nested] 14+ messages in thread
* [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 for USB
2015-09-30 2:17 [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 for USB Peter Chen
2015-09-30 2:17 ` [RESEND PATCH v2 2/2] ARM: imx6: change default burst size " Peter Chen
@ 2015-09-30 5:24 ` Shawn Guo
2015-11-23 0:53 ` Shawn Guo
2 siblings, 0 replies; 14+ messages in thread
From: Shawn Guo @ 2015-09-30 5:24 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 30, 2015 at 10:17:16AM +0800, Peter Chen wrote:
> After setting ahb burst configuration as 0, we can increase tx/rx
> burst size, it will improve the USB performance
>
> Signed-off-by: Peter Chen <peter.chen@freescale.com>
Applied both, thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 for USB
2015-09-30 2:17 [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 for USB Peter Chen
2015-09-30 2:17 ` [RESEND PATCH v2 2/2] ARM: imx6: change default burst size " Peter Chen
2015-09-30 5:24 ` [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 " Shawn Guo
@ 2015-11-23 0:53 ` Shawn Guo
2015-11-23 1:57 ` Peter Chen
2 siblings, 1 reply; 14+ messages in thread
From: Shawn Guo @ 2015-11-23 0:53 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 30, 2015 at 10:17:16AM +0800, Peter Chen wrote:
> After setting ahb burst configuration as 0, we can increase tx/rx
> burst size, it will improve the USB performance
>
> Signed-off-by: Peter Chen <peter.chen@freescale.com>
Should I queue these patches for v4.4-rc as fixes or v4.5-rc1 as
improvement?
Shawn
^ permalink raw reply [flat|nested] 14+ messages in thread
* [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 for USB
2015-11-23 0:53 ` Shawn Guo
@ 2015-11-23 1:57 ` Peter Chen
2015-11-23 6:24 ` Shawn Guo
0 siblings, 1 reply; 14+ messages in thread
From: Peter Chen @ 2015-11-23 1:57 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Nov 23, 2015 at 08:53:04AM +0800, Shawn Guo wrote:
> On Wed, Sep 30, 2015 at 10:17:16AM +0800, Peter Chen wrote:
> > After setting ahb burst configuration as 0, we can increase tx/rx
> > burst size, it will improve the USB performance
> >
> > Signed-off-by: Peter Chen <peter.chen@freescale.com>
>
> Should I queue these patches for v4.4-rc as fixes or v4.5-rc1 as
> improvement?
>
Queue them for v4.5-rc1 please.
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 14+ messages in thread
* [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 for USB
2015-11-23 1:57 ` Peter Chen
@ 2015-11-23 6:24 ` Shawn Guo
0 siblings, 0 replies; 14+ messages in thread
From: Shawn Guo @ 2015-11-23 6:24 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Nov 23, 2015 at 09:57:46AM +0800, Peter Chen wrote:
> On Mon, Nov 23, 2015 at 08:53:04AM +0800, Shawn Guo wrote:
> > On Wed, Sep 30, 2015 at 10:17:16AM +0800, Peter Chen wrote:
> > > After setting ahb burst configuration as 0, we can increase tx/rx
> > > burst size, it will improve the USB performance
> > >
> > > Signed-off-by: Peter Chen <peter.chen@freescale.com>
> >
> > Should I queue these patches for v4.4-rc as fixes or v4.5-rc1 as
> > improvement?
> >
>
> Queue them for v4.5-rc1 please.
Applied, thanks.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2015-11-23 6:24 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-30 2:17 [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 for USB Peter Chen
2015-09-30 2:17 ` [RESEND PATCH v2 2/2] ARM: imx6: change default burst size " Peter Chen
2015-09-30 8:52 ` Lucas Stach
2015-09-30 13:37 ` Shawn Guo
2015-10-20 7:07 ` Peter Chen
2015-10-20 8:41 ` Lucas Stach
2015-11-18 8:33 ` Peter Chen
2015-10-01 8:13 ` Peter Chen
2015-10-01 8:42 ` Lucas Stach
2015-10-01 10:51 ` Peter Chen
2015-09-30 5:24 ` [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 " Shawn Guo
2015-11-23 0:53 ` Shawn Guo
2015-11-23 1:57 ` Peter Chen
2015-11-23 6:24 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).