From: sudipm.mukherjee@gmail.com (Sudip Mukherjee)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] thermal: exynos: fix register read in TMU
Date: Thu, 1 Oct 2015 17:09:59 +0530 [thread overview]
Message-ID: <1443699599-9693-1-git-send-email-sudipm.mukherjee@gmail.com> (raw)
The value of emul_con was getting overwritten if the selected soc is
SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong
register in the case of SOC_ARCH_EXYNOS5260.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/thermal/samsung/exynos_tmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 0bae8cc..ca920b0 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct exynos_tmu_data *data,
if (data->soc == SOC_ARCH_EXYNOS5260)
emul_con = EXYNOS5260_EMUL_CON;
- if (data->soc == SOC_ARCH_EXYNOS5433)
+ else if (data->soc == SOC_ARCH_EXYNOS5433)
emul_con = EXYNOS5433_TMU_EMUL_CON;
else if (data->soc == SOC_ARCH_EXYNOS7)
emul_con = EXYNOS7_TMU_REG_EMUL_CON;
--
1.9.1
next reply other threads:[~2015-10-01 11:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 11:39 Sudip Mukherjee [this message]
2015-10-01 13:18 ` [PATCH] thermal: exynos: fix register read in TMU Krzysztof Kozlowski
2015-10-01 14:12 ` Sudip Mukherjee
2015-10-01 23:43 ` Krzysztof Kozlowski
2015-10-08 14:21 ` Sudip Mukherjee
2015-10-09 11:35 ` Krzysztof Kozlowski
2015-10-09 12:07 ` Lukasz Majewski
2015-10-10 4:36 ` Krzysztof Kozlowski
2015-10-02 0:03 ` Chanwoo Choi
-- strict thread matches above, loose matches on Subject: below --
2015-10-12 23:51 [PATCH] thermal: exynos: Fix " Krzysztof Kozlowski
2015-10-16 23:20 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443699599-9693-1-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).