linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] Broadcom defconfig changes for v4.4
@ 2015-10-02 22:20 Florian Fainelli
  2015-10-02 22:20 ` [GIT PULL] Broadcom devicetree " Florian Fainelli
                   ` (3 more replies)
  0 siblings, 4 replies; 16+ messages in thread
From: Florian Fainelli @ 2015-10-02 22:20 UTC (permalink / raw)
  To: linux-arm-kernel


The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f:

  Linux 4.3-rc1 (2015-09-12 16:35:56 -0700)

are available in the git repository at:

  http://github.com/Broadcom/stblinux.git tags/arm-soc/for-4.4/defconfig

for you to fetch changes up to de0d542338bc507d2fc21bfca2be540f17fc874a:

  ARM: multi_v7_defconfig: Add NSP to defconfig (2015-09-14 16:15:08 -0700)

----------------------------------------------------------------
This pull request contains the following changes for the multi_v7_defconfig:

- Jon adds support for the NorthStar Plus SocS to the multi_v7_defconfig file

----------------------------------------------------------------
Jon Mason (1):
      ARM: multi_v7_defconfig: Add NSP to defconfig

 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [GIT PULL] Broadcom devicetree changes for v4.4
  2015-10-02 22:20 [GIT PULL] Broadcom defconfig changes for v4.4 Florian Fainelli
@ 2015-10-02 22:20 ` Florian Fainelli
  2015-10-09 15:22   ` Arnd Bergmann
  2015-10-02 22:20 ` [GIT PULL] Broadcom maintainers " Florian Fainelli
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 16+ messages in thread
From: Florian Fainelli @ 2015-10-02 22:20 UTC (permalink / raw)
  To: linux-arm-kernel


The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f:

  Linux 4.3-rc1 (2015-09-12 16:35:56 -0700)

are available in the git repository at:

  http://github.com/Broadcom/stblinux.git tags/arm-soc/for-4.4/devicetree

for you to fetch changes up to eef228e3191de0b62ef5913be216f25ba6b23a4c:

  ARM: dts: move aliases back to .dts in Cygnus (2015-09-24 18:30:10 -0700)

----------------------------------------------------------------
This pull requests contains the following Broadcom SoCs Device Tree changes:

- Brian Norris documents the BCM7445 SoCs Power Management controllers and
  hardware and updates the reference BCM7445 Device Tree with these nodes

- Florian Fainelli documents the BCM7xxx write-pairing feature in the top-level
  BCM7xxx binding document

- Hauke Merthens enables the NAND controller for the Asus RT-AC87U and adds the
  GPIO pin controlling the USB power supply on Netgear R6250

- Jon Mason adds support for the NorthStar Plus SoC by providing a top-level
  binding document and the minimalist device tree skeleton for these SoCs

- Rafal Milecki adds support for the Netgear R7000 (BCM5301x SoC)

- Ray Jui provides a set of Cygnus DT changes that make the Device Tree clearer
  and more correct with respect to how the hardware is designed. He also enables
  the NAND controller on the bcm911360_entphn design, enables a bunch of
  peripherals on the bcm958305k evaluation board, and adds a skeleton .dtsi file
  for the touchscreen extansion board(s)

----------------------------------------------------------------
Brian Norris (2):
      Documentation: dt: brcmstb: add system PM bindings
      ARM: dts: brcmstb: add BCM7445 system PM DT nodes

Florian Fainelli (1):
      Documentation: bindings: brcmstb: Document write-pairing

Hauke Mehrtens (2):
      ARM: BCM5301X: add NAND flash chip description for Asus RT-AC87U
      ARM: BCM5301X: Netgear R6250 add USB GPIO

Jon Mason (2):
      dt-bindings: Create Documentation for NSP DT bindings
      ARM: NSP: add minimal Northstar Plus device tree

Rafa? Mi?ecki (1):
      ARM: BCM5301X: Add DT for Netgear R7000

Ray Jui (10):
      ARM: dts: consolidate aliases for Cygnus dt files
      ARM: dts: Use label for device nodes in Cygnus dts
      ARM: dts: Put Cygnus core components under core bus
      ARM: dts: Move all Cygnus peripherals into axi bus
      ARM: dts: Reorder Cygnus peripherals
      ARM: dts: Enable various peripherals on bcm958305k
      ARM: dts: Enable NAND support on bcm911360_entphn
      ARM: dts: enable touchscreen support on Cygnus
      ARM: dts: fix Cygnus nand device node
      ARM: dts: move aliases back to .dts in Cygnus

 .../devicetree/bindings/arm/bcm/brcm,brcmstb.txt   | 162 +++++++++-
 .../devicetree/bindings/arm/bcm/brcm,nsp.txt       |  34 +++
 arch/arm/boot/dts/Makefile                         |   3 +
 arch/arm/boot/dts/bcm-cygnus.dtsi                  | 334 +++++++++++----------
 arch/arm/boot/dts/bcm-nsp.dtsi                     | 119 ++++++++
 arch/arm/boot/dts/bcm4708-netgear-r6250.dts        |  11 +
 arch/arm/boot/dts/bcm4709-asus-rt-ac87u.dts        |   1 +
 arch/arm/boot/dts/bcm4709-netgear-r7000.dts        | 106 +++++++
 arch/arm/boot/dts/bcm7445.dtsi                     |  84 ++++++
 arch/arm/boot/dts/bcm911360_entphn.dts             |  28 +-
 arch/arm/boot/dts/bcm911360k.dts                   |   9 +-
 arch/arm/boot/dts/bcm958300k.dts                   |  44 +--
 arch/arm/boot/dts/bcm958305k.dts                   |  40 ++-
 arch/arm/boot/dts/bcm958625k.dts                   |  57 ++++
 arch/arm/boot/dts/bcm9hmidc.dtsi                   |  42 +++
 15 files changed, 874 insertions(+), 200 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,nsp.txt
 create mode 100644 arch/arm/boot/dts/bcm-nsp.dtsi
 create mode 100644 arch/arm/boot/dts/bcm4709-netgear-r7000.dts
 create mode 100644 arch/arm/boot/dts/bcm958625k.dts
 create mode 100644 arch/arm/boot/dts/bcm9hmidc.dtsi

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [GIT PULL] Broadcom maintainers changes for v4.4
  2015-10-02 22:20 [GIT PULL] Broadcom defconfig changes for v4.4 Florian Fainelli
  2015-10-02 22:20 ` [GIT PULL] Broadcom devicetree " Florian Fainelli
@ 2015-10-02 22:20 ` Florian Fainelli
  2015-10-09 15:24   ` Arnd Bergmann
  2015-10-02 22:20 ` [GIT PULL] Broadcom soc " Florian Fainelli
  2015-10-06 14:04 ` [GIT PULL] Broadcom defconfig changes for v4.4 Arnd Bergmann
  3 siblings, 1 reply; 16+ messages in thread
From: Florian Fainelli @ 2015-10-02 22:20 UTC (permalink / raw)
  To: linux-arm-kernel


The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f:

  Linux 4.3-rc1 (2015-09-12 16:35:56 -0700)

are available in the git repository at:

  http://github.com/Broadcom/stblinux.git tags/arm-soc/for-4.4/maintainers

for you to fetch changes up to 63f37ddf5c221c5a86ea9e45625bd0381feabc13:

  MAINTAINERS: add entry for the Broadcom Northstar Plus SoCs (2015-09-14 16:11:36 -0700)

----------------------------------------------------------------
This pull request contains the following changes to the MAINTAINERS file:

- Jon Mason lists the NorthStar Plus SoC under the existing Cygnus/iProc section, and by
  doing so, slightly rephrases the title to make it clear that it spans many more chips now

----------------------------------------------------------------
Jon Mason (1):
      MAINTAINERS: add entry for the Broadcom Northstar Plus SoCs

 MAINTAINERS | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [GIT PULL] Broadcom soc changes for v4.4
  2015-10-02 22:20 [GIT PULL] Broadcom defconfig changes for v4.4 Florian Fainelli
  2015-10-02 22:20 ` [GIT PULL] Broadcom devicetree " Florian Fainelli
  2015-10-02 22:20 ` [GIT PULL] Broadcom maintainers " Florian Fainelli
@ 2015-10-02 22:20 ` Florian Fainelli
  2015-10-09 15:46   ` Arnd Bergmann
  2015-10-10 18:40   ` [GIT PULL] Broadcom soc changes for v4.4 (try 2) Florian Fainelli
  2015-10-06 14:04 ` [GIT PULL] Broadcom defconfig changes for v4.4 Arnd Bergmann
  3 siblings, 2 replies; 16+ messages in thread
From: Florian Fainelli @ 2015-10-02 22:20 UTC (permalink / raw)
  To: linux-arm-kernel


The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f:

  Linux 4.3-rc1 (2015-09-12 16:35:56 -0700)

are available in the git repository at:

  http://github.com/Broadcom/stblinux.git tags/arm-soc/for-4.4/soc

for you to fetch changes up to 7333ecdcd71fbbed1e2cab675fd129ab99f4db41:

  ARM: brcmstb: Setup BIU control registers during boot (2015-09-18 12:21:17 -0700)

----------------------------------------------------------------
This pull request contains the following Broadcom SoC platform and driver changes:

- Brian Norris create a drivers/soc/brcmstb/ stub and then adds support for S2/S3/S5
  suspend/resume modes for the Broadcom BCM7xxx Set Top Box SoCs

- Florian Fainelli adds support for configuring the BCM7xxx SoCs Bus Interface Unit
  with their specific write-pairing setting, which must be saved and restored during
  system-wide suspend/resume, and consequently updates the brcmstb machine code to
  initialize the BIU

- Jon Mason adds support for the Northstar Plus SoCs by introducing a custom machine
  descriptor matching their compatible string and setting up the PL310 L2 cache and
  enabling the relevant ARM errata for their Cortex-A9

----------------------------------------------------------------
Brian Norris (2):
      soc: add stubs for brcmstb SoC's
      soc: brcmstb: add PM suspend/resume support (S2/S3/S5)

Florian Fainelli (2):
      soc: brcmstb: Add Bus Interface Unit control setup
      ARM: brcmstb: Setup BIU control registers during boot

Jon Mason (1):
      ARM: NSP: Add basic support for Broadcom Northstar Plus SoC

 arch/arm/mach-bcm/Kconfig           |  15 ++
 arch/arm/mach-bcm/Makefile          |   5 +-
 arch/arm/mach-bcm/bcm_nsp.c         |  25 ++
 arch/arm/mach-bcm/brcmstb.c         |   9 +
 drivers/soc/Kconfig                 |   1 +
 drivers/soc/Makefile                |   1 +
 drivers/soc/brcmstb/Kconfig         |  19 ++
 drivers/soc/brcmstb/Makefile        |   3 +
 drivers/soc/brcmstb/biuctrl.c       | 116 ++++++++
 drivers/soc/brcmstb/common.c        |  33 +++
 drivers/soc/brcmstb/pm/Makefile     |   2 +
 drivers/soc/brcmstb/pm/aon_defs.h   |  85 ++++++
 drivers/soc/brcmstb/pm/pm.c         | 512 ++++++++++++++++++++++++++++++++++++
 drivers/soc/brcmstb/pm/pm.h         |  40 +++
 drivers/soc/brcmstb/pm/s2.S         |  73 +++++
 include/linux/soc/brcmstb/brcmstb.h |  10 +
 include/soc/brcmstb/common.h        |  15 ++
 17 files changed, 963 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/mach-bcm/bcm_nsp.c
 create mode 100644 drivers/soc/brcmstb/Kconfig
 create mode 100644 drivers/soc/brcmstb/Makefile
 create mode 100644 drivers/soc/brcmstb/biuctrl.c
 create mode 100644 drivers/soc/brcmstb/common.c
 create mode 100644 drivers/soc/brcmstb/pm/Makefile
 create mode 100644 drivers/soc/brcmstb/pm/aon_defs.h
 create mode 100644 drivers/soc/brcmstb/pm/pm.c
 create mode 100644 drivers/soc/brcmstb/pm/pm.h
 create mode 100644 drivers/soc/brcmstb/pm/s2.S
 create mode 100644 include/linux/soc/brcmstb/brcmstb.h
 create mode 100644 include/soc/brcmstb/common.h

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [GIT PULL] Broadcom defconfig changes for v4.4
  2015-10-02 22:20 [GIT PULL] Broadcom defconfig changes for v4.4 Florian Fainelli
                   ` (2 preceding siblings ...)
  2015-10-02 22:20 ` [GIT PULL] Broadcom soc " Florian Fainelli
@ 2015-10-06 14:04 ` Arnd Bergmann
  2015-10-08 17:23   ` Florian Fainelli
  3 siblings, 1 reply; 16+ messages in thread
From: Arnd Bergmann @ 2015-10-06 14:04 UTC (permalink / raw)
  To: linux-arm-kernel

On Friday 02 October 2015 15:20:55 Florian Fainelli wrote:
> This pull request contains the following changes for the multi_v7_defconfig:
> 
> - Jon adds support for the NorthStar Plus SocS to the multi_v7_defconfig file
> 
> 

Merged into next/defconfig, thanks!

	Arnd

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [GIT PULL] Broadcom defconfig changes for v4.4
  2015-10-06 14:04 ` [GIT PULL] Broadcom defconfig changes for v4.4 Arnd Bergmann
@ 2015-10-08 17:23   ` Florian Fainelli
  2015-10-08 18:38     ` Arnd Bergmann
  0 siblings, 1 reply; 16+ messages in thread
From: Florian Fainelli @ 2015-10-08 17:23 UTC (permalink / raw)
  To: linux-arm-kernel

On 06/10/15 07:04, Arnd Bergmann wrote:
> On Friday 02 October 2015 15:20:55 Florian Fainelli wrote:
>> This pull request contains the following changes for the multi_v7_defconfig:
>>
>> - Jon adds support for the NorthStar Plus SocS to the multi_v7_defconfig file
>>
>>
> 
> Merged into next/defconfig, thanks!

There are 3 other pull requests for Device Tree, SoC/driver and
MAINTAINERS file updates, is the threading confusing?

Thanks!
-- 
Florian

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [GIT PULL] Broadcom defconfig changes for v4.4
  2015-10-08 17:23   ` Florian Fainelli
@ 2015-10-08 18:38     ` Arnd Bergmann
  2015-10-08 22:49       ` Florian Fainelli
  0 siblings, 1 reply; 16+ messages in thread
From: Arnd Bergmann @ 2015-10-08 18:38 UTC (permalink / raw)
  To: linux-arm-kernel

On Thursday 08 October 2015 10:23:10 Florian Fainelli wrote:
> On 06/10/15 07:04, Arnd Bergmann wrote:
> > On Friday 02 October 2015 15:20:55 Florian Fainelli wrote:
> >> This pull request contains the following changes for the multi_v7_defconfig:
> >>
> >> - Jon adds support for the NorthStar Plus SocS to the multi_v7_defconfig file
> >>
> >>
> > 
> > Merged into next/defconfig, thanks!
> 
> There are 3 other pull requests for Device Tree, SoC/driver and
> MAINTAINERS file updates, is the threading confusing?

Yes, I guess I was confused by that.

I see now that I moved the entire mail thread into my 'done' folder.
Some other maintainers post all patches in the series as replies to
the git pull mail, and I must have assumed you did the same, or I
just didn't look when moving this thread.

I think it would help if you change the subject line to [GIT PULL 1/4],
which makes it a bit more obvious in the future.

Thanks for the report, I've now put them back into my todo folder and
should get to it by tomorrow at the latest.

	Arnd

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [GIT PULL] Broadcom defconfig changes for v4.4
  2015-10-08 18:38     ` Arnd Bergmann
@ 2015-10-08 22:49       ` Florian Fainelli
  0 siblings, 0 replies; 16+ messages in thread
From: Florian Fainelli @ 2015-10-08 22:49 UTC (permalink / raw)
  To: linux-arm-kernel

On 08/10/15 11:38, Arnd Bergmann wrote:
> On Thursday 08 October 2015 10:23:10 Florian Fainelli wrote:
>> On 06/10/15 07:04, Arnd Bergmann wrote:
>>> On Friday 02 October 2015 15:20:55 Florian Fainelli wrote:
>>>> This pull request contains the following changes for the multi_v7_defconfig:
>>>>
>>>> - Jon adds support for the NorthStar Plus SocS to the multi_v7_defconfig file
>>>>
>>>>
>>>
>>> Merged into next/defconfig, thanks!
>>
>> There are 3 other pull requests for Device Tree, SoC/driver and
>> MAINTAINERS file updates, is the threading confusing?
> 
> Yes, I guess I was confused by that.
> 
> I see now that I moved the entire mail thread into my 'done' folder.
> Some other maintainers post all patches in the series as replies to
> the git pull mail, and I must have assumed you did the same, or I
> just didn't look when moving this thread.

Not a problem.

> 
> I think it would help if you change the subject line to [GIT PULL 1/4],
> which makes it a bit more obvious in the future.

Will do, just updated my script to do that.

> 
> Thanks for the report, I've now put them back into my todo folder and
> should get to it by tomorrow at the latest.

Thanks, let me know how things go ;)
-- 
Florian

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [GIT PULL] Broadcom devicetree changes for v4.4
  2015-10-02 22:20 ` [GIT PULL] Broadcom devicetree " Florian Fainelli
@ 2015-10-09 15:22   ` Arnd Bergmann
  0 siblings, 0 replies; 16+ messages in thread
From: Arnd Bergmann @ 2015-10-09 15:22 UTC (permalink / raw)
  To: linux-arm-kernel

On Friday 02 October 2015 15:20:56 Florian Fainelli wrote:
> This pull requests contains the following Broadcom SoCs Device Tree changes:
> 
> - Brian Norris documents the BCM7445 SoCs Power Management controllers and
>   hardware and updates the reference BCM7445 Device Tree with these nodes
> 
> - Florian Fainelli documents the BCM7xxx write-pairing feature in the top-level
>   BCM7xxx binding document
> 
> - Hauke Merthens enables the NAND controller for the Asus RT-AC87U and adds the
>   GPIO pin controlling the USB power supply on Netgear R6250
> 
> - Jon Mason adds support for the NorthStar Plus SoC by providing a top-level
>   binding document and the minimalist device tree skeleton for these SoCs
> 
> - Rafal Milecki adds support for the Netgear R7000 (BCM5301x SoC)
> 
> - Ray Jui provides a set of Cygnus DT changes that make the Device Tree clearer
>   and more correct with respect to how the hardware is designed. He also enables
>   the NAND controller on the bcm911360_entphn design, enables a bunch of
>   peripherals on the bcm958305k evaluation board, and adds a skeleton .dtsi file
>   for the touchscreen extansion board(s)
> 
> 

Merged into next/dt, thanks!

	Arnd

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [GIT PULL] Broadcom maintainers changes for v4.4
  2015-10-02 22:20 ` [GIT PULL] Broadcom maintainers " Florian Fainelli
@ 2015-10-09 15:24   ` Arnd Bergmann
  0 siblings, 0 replies; 16+ messages in thread
From: Arnd Bergmann @ 2015-10-09 15:24 UTC (permalink / raw)
  To: linux-arm-kernel

On Friday 02 October 2015 15:20:57 Florian Fainelli wrote:
> This pull request contains the following changes to the MAINTAINERS file:
> 
> - Jon Mason lists the NorthStar Plus SoC under the existing Cygnus/iProc section, and by
>   doing so, slightly rephrases the title to make it clear that it spans many more chips now
> 

Merged into next/fixes-non-critical, thanks!

	Arnd

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [GIT PULL] Broadcom soc changes for v4.4
  2015-10-02 22:20 ` [GIT PULL] Broadcom soc " Florian Fainelli
@ 2015-10-09 15:46   ` Arnd Bergmann
  2015-10-09 17:01     ` Florian Fainelli
  2015-10-10 18:40   ` [GIT PULL] Broadcom soc changes for v4.4 (try 2) Florian Fainelli
  1 sibling, 1 reply; 16+ messages in thread
From: Arnd Bergmann @ 2015-10-09 15:46 UTC (permalink / raw)
  To: linux-arm-kernel

On Friday 02 October 2015 15:20:58 Florian Fainelli wrote:
> This pull request contains the following Broadcom SoC platform and driver changes:
> 
> - Brian Norris create a drivers/soc/brcmstb/ stub and then adds support for S2/S3/S5
>   suspend/resume modes for the Broadcom BCM7xxx Set Top Box SoCs

I'm not overly happy with this part of the code (sorry Brian):

- it looks like it should be a cpuidle driver. Not completely sure about this,
  but I'd like to see at least an Ack from the cpuidle maintainers to confirm
  that they want it to be done in drivers/soc

- any code here that is not going into a cpuidle driver for this part looks
  like it's better suited to go to arch/arm/mach-bcm, as the code doesn't
  feel like a driver. This is of course a gray area, and can be debated.

- it's clearly not endian-safe. There really is no reason to use __raw
  mmio accessors here, or to define the interface to the firmware in terms
  of native endianess when the registers and firmware is known to be
  little-endian.

Sorry for not noticing the driver earlier when it was discussed on the list,
but I think the above is reason enough to do another revision.
Can you submit a new pull request without the suspend/resume handling?

	Arnd

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [GIT PULL] Broadcom soc changes for v4.4
  2015-10-09 15:46   ` Arnd Bergmann
@ 2015-10-09 17:01     ` Florian Fainelli
  2015-10-09 18:23       ` Arnd Bergmann
  0 siblings, 1 reply; 16+ messages in thread
From: Florian Fainelli @ 2015-10-09 17:01 UTC (permalink / raw)
  To: linux-arm-kernel

On 09/10/15 08:46, Arnd Bergmann wrote:
> On Friday 02 October 2015 15:20:58 Florian Fainelli wrote:
>> This pull request contains the following Broadcom SoC platform and driver changes:
>>
>> - Brian Norris create a drivers/soc/brcmstb/ stub and then adds support for S2/S3/S5
>>   suspend/resume modes for the Broadcom BCM7xxx Set Top Box SoCs
> 
> I'm not overly happy with this part of the code (sorry Brian):
> 
> - it looks like it should be a cpuidle driver. Not completely sure about this,
>   but I'd like to see at least an Ack from the cpuidle maintainers to confirm
>   that they want it to be done in drivers/soc

Could you clarify how you think this should be fitting in the cpuidle
framework? This is system-wide S2/S3/S5 states we are talking about
here, and that comes with specific constraints, like moving code from
DRAM execution to SRAM execution for instance, not sure where cpuidle
can help with that. And if it does, how we coordinate with that framework.

> 
> - any code here that is not going into a cpuidle driver for this part looks
>   like it's better suited to go to arch/arm/mach-bcm, as the code doesn't
>   feel like a driver. This is of course a gray area, and can be debated.

There are some large portions of this code that are shared between SoCs,
past, current and future chips, with the exception of the small assembly
part which needs to be architecture specific for obvious reasons.

For instance, the power state machine code is fairly SoC-independant,
and to some extent, the DDR controller code is as well, that is what
motivated putting that code here, so it can be re-used in the future
when we submit support for new chips as well.

> 
> - it's clearly not endian-safe. There really is no reason to use __raw
>   mmio accessors here, or to define the interface to the firmware in terms
>   of native endianess when the registers and firmware is known to be
>   little-endian.

Ok, that one is one me, I should have made sure it was.

> 
> Sorry for not noticing the driver earlier when it was discussed on the list,
> but I think the above is reason enough to do another revision.
> Can you submit a new pull request without the suspend/resume handling?

I can do that, but then I am really expecting someone to take a deep
look at the implementation and make some educated recommendations about
how this should be pieced together to achieve the expected ACPI-like
suspend states.

Thanks
-- 
Florian

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [GIT PULL] Broadcom soc changes for v4.4
  2015-10-09 17:01     ` Florian Fainelli
@ 2015-10-09 18:23       ` Arnd Bergmann
  0 siblings, 0 replies; 16+ messages in thread
From: Arnd Bergmann @ 2015-10-09 18:23 UTC (permalink / raw)
  To: linux-arm-kernel

On Friday 09 October 2015 10:01:39 Florian Fainelli wrote:
> On 09/10/15 08:46, Arnd Bergmann wrote:
> > On Friday 02 October 2015 15:20:58 Florian Fainelli wrote:
> >> This pull request contains the following Broadcom SoC platform and driver changes:
> >>
> >> - Brian Norris create a drivers/soc/brcmstb/ stub and then adds support for S2/S3/S5
> >>   suspend/resume modes for the Broadcom BCM7xxx Set Top Box SoCs
> > 
> > I'm not overly happy with this part of the code (sorry Brian):
> > 
> > - it looks like it should be a cpuidle driver. Not completely sure about this,
> >   but I'd like to see at least an Ack from the cpuidle maintainers to confirm
> >   that they want it to be done in drivers/soc
> 
> Could you clarify how you think this should be fitting in the cpuidle
> framework? This is system-wide S2/S3/S5 states we are talking about
> here, and that comes with specific constraints, like moving code from
> DRAM execution to SRAM execution for instance, not sure where cpuidle
> can help with that. And if it does, how we coordinate with that framework.

Ok, I see. So probably not cpuidle then, but I'd still have a better
feeling if this was reviewed by someone who understands power management
and is outside of the brcmstb team.

Maybe just send it to linux-pm to get feedback from the suspend maintainers?

> > - any code here that is not going into a cpuidle driver for this part looks
> >   like it's better suited to go to arch/arm/mach-bcm, as the code doesn't
> >   feel like a driver. This is of course a gray area, and can be debated.
> 
> There are some large portions of this code that are shared between SoCs,
> past, current and future chips, with the exception of the small assembly
> part which needs to be architecture specific for obvious reasons.
> 
> For instance, the power state machine code is fairly SoC-independant,
> and to some extent, the DDR controller code is as well, that is what
> motivated putting that code here, so it can be re-used in the future
> when we submit support for new chips as well.

Maybe drivers/firmware/broadcom/ then? That directory already
exists and the main parts seem to be for a firmware interface.

The DDR controller stuff probably better fits into drivers/memory/,
which already has similar bits from other platforms. Of course
that implies restructuring the code a bit to separate the two.

	Arnd

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [GIT PULL] Broadcom soc changes for v4.4 (try 2)
  2015-10-02 22:20 ` [GIT PULL] Broadcom soc " Florian Fainelli
  2015-10-09 15:46   ` Arnd Bergmann
@ 2015-10-10 18:40   ` Florian Fainelli
  2015-10-15 20:16     ` Arnd Bergmann
  1 sibling, 1 reply; 16+ messages in thread
From: Florian Fainelli @ 2015-10-10 18:40 UTC (permalink / raw)
  To: linux-arm-kernel


The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f:

  Linux 4.3-rc1 (2015-09-12 16:35:56 -0700)

are available in the git repository at:

  http://github.com/Broadcom/stblinux.git tags/arm-soc/for-4.4/soc

for you to fetch changes up to c4a8ea9e0698945b182ba1e1063a0981b1f35139:

  ARM: brcmstb: Setup BIU control registers during boot (2015-10-09 13:42:18 -0700)

----------------------------------------------------------------
This pull request contains the following Broadcom SoC platform and driver changes:

- Brian Norris create a drivers/soc/brcmstb/ stub as a place holder for SoC-specific
  code which is coming next

- Florian Fainelli adds support for configuring the BCM7xxx SoCs Bus Interface Unit
  with their specific write-pairing setting, which must be saved and restored during
  system-wide suspend/resume, and consequently updates the brcmstb machine code to
  initialize the BIU

- Jon Mason adds support for the Northstar Plus SoCs by introducing a custom machine
  descriptor matching their compatible string and setting up the PL310 L2 cache and
  enabling the relevant ARM errata for their Cortex-A9

----------------------------------------------------------------
Brian Norris (1):
      soc: add stubs for brcmstb SoC's

Florian Fainelli (2):
      soc: brcmstb: Add Bus Interface Unit control setup
      ARM: brcmstb: Setup BIU control registers during boot

Jon Mason (1):
      ARM: NSP: Add basic support for Broadcom Northstar Plus SoC

 arch/arm/mach-bcm/Kconfig           |  15 +++++
 arch/arm/mach-bcm/Makefile          |   5 +-
 arch/arm/mach-bcm/bcm_nsp.c         |  25 ++++++++
 arch/arm/mach-bcm/brcmstb.c         |   9 +++
 drivers/soc/Kconfig                 |   1 +
 drivers/soc/Makefile                |   1 +
 drivers/soc/brcmstb/Kconfig         |   9 +++
 drivers/soc/brcmstb/Makefile        |   1 +
 drivers/soc/brcmstb/biuctrl.c       | 116 ++++++++++++++++++++++++++++++++++++
 drivers/soc/brcmstb/common.c        |  33 ++++++++++
 include/linux/soc/brcmstb/brcmstb.h |  10 ++++
 include/soc/brcmstb/common.h        |  15 +++++
 12 files changed, 239 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/mach-bcm/bcm_nsp.c
 create mode 100644 drivers/soc/brcmstb/Kconfig
 create mode 100644 drivers/soc/brcmstb/Makefile
 create mode 100644 drivers/soc/brcmstb/biuctrl.c
 create mode 100644 drivers/soc/brcmstb/common.c
 create mode 100644 include/linux/soc/brcmstb/brcmstb.h
 create mode 100644 include/soc/brcmstb/common.h

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [GIT PULL] Broadcom soc changes for v4.4 (try 2)
  2015-10-10 18:40   ` [GIT PULL] Broadcom soc changes for v4.4 (try 2) Florian Fainelli
@ 2015-10-15 20:16     ` Arnd Bergmann
  2015-10-15 20:23       ` Florian Fainelli
  0 siblings, 1 reply; 16+ messages in thread
From: Arnd Bergmann @ 2015-10-15 20:16 UTC (permalink / raw)
  To: linux-arm-kernel

On Saturday 10 October 2015 11:40:29 Florian Fainelli wrote:
> 
> The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f:
> 
>   Linux 4.3-rc1 (2015-09-12 16:35:56 -0700)
> 
> are available in the git repository at:
> 
>   http://github.com/Broadcom/stblinux.git tags/arm-soc/for-4.4/soc
> 
> for you to fetch changes up to c4a8ea9e0698945b182ba1e1063a0981b1f35139:
> 
>   ARM: brcmstb: Setup BIU control registers during boot (2015-10-09 13:42:18 -0700)
> 
> ----------------------------------------------------------------
> This pull request contains the following Broadcom SoC platform and driver changes:
> 
> - Brian Norris create a drivers/soc/brcmstb/ stub as a place holder for SoC-specific
>   code which is coming next

I should have been clearer with my complaint last week. I really mean both
of Brian's patches should be removed, although I mainly talked about the
other one. This patch goes to great length to introduce a soc_is_brcmstb()
function, but I'd rather see this never being used anywhere.

Drivers should not have to check the compatible property of the root node
(in some cases we do, but that is because the initial binding was broken
and we could not change it).

> - Florian Fainelli adds support for configuring the BCM7xxx SoCs Bus Interface Unit
>   with their specific write-pairing setting, which must be saved and restored during
>   system-wide suspend/resume, and consequently updates the brcmstb machine code to
>   initialize the BIU
> 
> - Jon Mason adds support for the Northstar Plus SoCs by introducing a custom machine
>   descriptor matching their compatible string and setting up the PL310 L2 cache and
>   enabling the relevant ARM errata for their Cortex-A9

I've merged all of the series anyway, since it's not a big enough
problem to make you do another iteration, and I've already pushed
back once.

Let's talk about this again when you add users of this function, so
we can ideally come up with a better solution and remove the two files
again.

Pulled into next/soc. Thanks for your patience and for respinning
the series so quickly!

	Arnd

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [GIT PULL] Broadcom soc changes for v4.4 (try 2)
  2015-10-15 20:16     ` Arnd Bergmann
@ 2015-10-15 20:23       ` Florian Fainelli
  0 siblings, 0 replies; 16+ messages in thread
From: Florian Fainelli @ 2015-10-15 20:23 UTC (permalink / raw)
  To: linux-arm-kernel

On 15/10/15 13:16, Arnd Bergmann wrote:
> On Saturday 10 October 2015 11:40:29 Florian Fainelli wrote:
>>
>> The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f:
>>
>>   Linux 4.3-rc1 (2015-09-12 16:35:56 -0700)
>>
>> are available in the git repository at:
>>
>>   http://github.com/Broadcom/stblinux.git tags/arm-soc/for-4.4/soc
>>
>> for you to fetch changes up to c4a8ea9e0698945b182ba1e1063a0981b1f35139:
>>
>>   ARM: brcmstb: Setup BIU control registers during boot (2015-10-09 13:42:18 -0700)
>>
>> ----------------------------------------------------------------
>> This pull request contains the following Broadcom SoC platform and driver changes:
>>
>> - Brian Norris create a drivers/soc/brcmstb/ stub as a place holder for SoC-specific
>>   code which is coming next
> 
> I should have been clearer with my complaint last week. I really mean both
> of Brian's patches should be removed, although I mainly talked about the
> other one. This patch goes to great length to introduce a soc_is_brcmstb()
> function, but I'd rather see this never being used anywhere.
> 
> Drivers should not have to check the compatible property of the root node
> (in some cases we do, but that is because the initial binding was broken
> and we could not change it).

I admit I did not quite understand your initial comment was about both
patches, look back at this, the biuctrl code really does not need this
soc_is_brcmstb() thing at all, since it matches its own compatible
strings... whoops.

> 
>> - Florian Fainelli adds support for configuring the BCM7xxx SoCs Bus Interface Unit
>>   with their specific write-pairing setting, which must be saved and restored during
>>   system-wide suspend/resume, and consequently updates the brcmstb machine code to
>>   initialize the BIU
>>
>> - Jon Mason adds support for the Northstar Plus SoCs by introducing a custom machine
>>   descriptor matching their compatible string and setting up the PL310 L2 cache and
>>   enabling the relevant ARM errata for their Cortex-A9
> 
> I've merged all of the series anyway, since it's not a big enough
> problem to make you do another iteration, and I've already pushed
> back once.
> 
> Let's talk about this again when you add users of this function, so
> we can ideally come up with a better solution and remove the two files
> again.
> 
> Pulled into next/soc. Thanks for your patience and for respinning
> the series so quickly!

Sounds good, thanks!
-- 
Florian

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2015-10-15 20:23 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-02 22:20 [GIT PULL] Broadcom defconfig changes for v4.4 Florian Fainelli
2015-10-02 22:20 ` [GIT PULL] Broadcom devicetree " Florian Fainelli
2015-10-09 15:22   ` Arnd Bergmann
2015-10-02 22:20 ` [GIT PULL] Broadcom maintainers " Florian Fainelli
2015-10-09 15:24   ` Arnd Bergmann
2015-10-02 22:20 ` [GIT PULL] Broadcom soc " Florian Fainelli
2015-10-09 15:46   ` Arnd Bergmann
2015-10-09 17:01     ` Florian Fainelli
2015-10-09 18:23       ` Arnd Bergmann
2015-10-10 18:40   ` [GIT PULL] Broadcom soc changes for v4.4 (try 2) Florian Fainelli
2015-10-15 20:16     ` Arnd Bergmann
2015-10-15 20:23       ` Florian Fainelli
2015-10-06 14:04 ` [GIT PULL] Broadcom defconfig changes for v4.4 Arnd Bergmann
2015-10-08 17:23   ` Florian Fainelli
2015-10-08 18:38     ` Arnd Bergmann
2015-10-08 22:49       ` Florian Fainelli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).