From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t
Date: Tue, 06 Oct 2015 23:53:02 -0700 [thread overview]
Message-ID: <1444200782.26237.8.camel@perches.com> (raw)
In-Reply-To: <30258520.VaA2vDyUiY@wuerfel>
On Tue, 2015-10-06 at 23:47 +0200, Arnd Bergmann wrote:
> The recently added mlxsw driver produces warnings in ARM
> allmodconfig:
>
> drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec':
> drivers/net/ethernet/mellanox/mlxsw/pci.c:1585:59: warning: right shift count >= width of type [-Wshift-count-overflow]
> linux/byteorder/big_endian.h:38:51: note: in definition of macro '__cpu_to_be32'
> drivers/net/ethernet/mellanox/mlxsw/pci.c:76:2: note: in expansion of macro 'iowrite32be'
>
> This changes the type of the local variable to u64, which gets rid of the
> warning and seems nicer than adding #ifdefs.
Using upper_32_bits instead of the shift might be
nicer than changing the type.
next prev parent reply other threads:[~2015-10-07 6:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 21:47 [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t Arnd Bergmann
2015-10-07 6:43 ` Jiri Pirko
2015-10-07 6:53 ` Joe Perches [this message]
2015-10-07 6:56 ` Jiri Pirko
2015-10-07 6:58 ` [PATCH v2] " Arnd Bergmann
2015-10-07 7:00 ` Jiri Pirko
2015-10-08 12:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444200782.26237.8.camel@perches.com \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).