From: mathieu.poirier@linaro.org (Mathieu Poirier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] coresight: etm3x: making error message unambiguous
Date: Wed, 7 Oct 2015 09:26:43 -0600 [thread overview]
Message-ID: <1444231603-26676-7-git-send-email-mathieu.poirier@linaro.org> (raw)
In-Reply-To: <1444231603-26676-1-git-send-email-mathieu.poirier@linaro.org>
By adding the function name at the beginning of the error
message there is no doubt as to where the failing condition
occurred.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
drivers/hwtracing/coresight/coresight-etm3x.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x.c
index 87374b3388ad..d630b7ece735 100644
--- a/drivers/hwtracing/coresight/coresight-etm3x.c
+++ b/drivers/hwtracing/coresight/coresight-etm3x.c
@@ -191,7 +191,8 @@ static void etm_set_prog(struct etm_drvdata *drvdata)
isb();
if (coresight_timeout_etm(drvdata, ETMSR, ETMSR_PROG_BIT, 1)) {
dev_err(drvdata->dev,
- "timeout observed when probing at offset %#x\n", ETMSR);
+ "%s: timeout observed when probing at offset %#x\n",
+ __func__, ETMSR);
}
}
@@ -209,7 +210,8 @@ static void etm_clr_prog(struct etm_drvdata *drvdata)
isb();
if (coresight_timeout_etm(drvdata, ETMSR, ETMSR_PROG_BIT, 0)) {
dev_err(drvdata->dev,
- "timeout observed when probing at offset %#x\n", ETMSR);
+ "%s: timeout observed when probing at offset %#x\n",
+ __func__, ETMSR);
}
}
--
1.9.1
prev parent reply other threads:[~2015-10-07 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 15:26 [PATCH 0/6] coresight: next v4.3-rc4 Mathieu Poirier
2015-10-07 15:26 ` [PATCH 1/6] Coresight: ETMv4: Prevent TRCRSCTLR0&1 from being accessed Mathieu Poirier
2015-10-07 15:26 ` [PATCH 2/6] coresight: fixing typographical error Mathieu Poirier
2015-10-07 15:26 ` [PATCH 3/6] coresight: adding comments to remove ambiguity Mathieu Poirier
2015-10-07 15:26 ` [PATCH 4/6] coresight: etm3x: adding cpu affinity to sysFS interface Mathieu Poirier
2015-10-07 16:53 ` Greg KH
2015-10-07 15:26 ` [PATCH 5/6] coresight: etm3x: breaking down sysFS status interface Mathieu Poirier
2015-10-07 16:53 ` Greg KH
2015-10-07 15:26 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444231603-26676-7-git-send-email-mathieu.poirier@linaro.org \
--to=mathieu.poirier@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).