From: takahiro.akashi@linaro.org (AKASHI Takahiro)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/7] arm64: ftrace: fix incorrect output from stack tracer
Date: Thu, 8 Oct 2015 19:01:37 +0900 [thread overview]
Message-ID: <1444298504-10392-1-git-send-email-takahiro.akashi@linaro.org> (raw)
This is the third patch series for fixing stack tracer on arm64.
The original issue was reported by Jungseok[1], and then I found more
issues[2].
(Steven, Jungseok, sorry for not replying to your comments directly.)
I address here all the issues and implement fixes described in [2] except
for interrupt-triggered problems, ie. II-3). Recent discussions[3] about
introducing a dedicated interrupt stack suggests that we may avoid walking
through from an interrupt stack to a process stack.
(So interrupt-stack patch is a prerequisite.)
Basically,
patch1 corresponds to the original issue.
patch2 is a proactive improvement of function_graph tracer.
patch3 corresponds to II-4(functions under function_graph tracer).
patch4 corresponds to II-5(leaf function).
patch5, 6 and 7 correspond to II-1(slurping stack) and II-2(differences
between x86 and arm64).
Each fix can be applied independently, but if patch5, 6 and 7 are
acceptable, patch1 is not necessary because patch7 replaces a default
stack tracer.
I tested the code with v4.3-rc3 + Jungseok's patch v3[4].
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/354126.html
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/355920.html
[3] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/368003.html
[4] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-September/371451.html
AKASHI Takahiro (7):
arm64: ftrace: adjust callsite addresses examined by stack tracer
arm64: ftrace: modify a stack frame in a safe way
arm64: ftrace: fix a stack tracer's output under function graph
tracer
arm64: ftrace: allow for tracing leaf functions
ftrace: allow arch-specific stack tracer
arm64: insn: add instruction decoders for ldp/stp and add/sub
arm64: ftrace: add arch-specific stack tracer
arch/arm64/Makefile | 5 +
arch/arm64/include/asm/ftrace.h | 7 +-
arch/arm64/include/asm/insn.h | 18 +++
arch/arm64/include/asm/stacktrace.h | 1 +
arch/arm64/kernel/ftrace.c | 77 +++++++++++--
arch/arm64/kernel/insn.c | 102 +++++++++++++++++
arch/arm64/kernel/stacktrace.c | 213 ++++++++++++++++++++++++++++++++++-
include/linux/ftrace.h | 17 +++
kernel/trace/trace_stack.c | 27 +++--
9 files changed, 442 insertions(+), 25 deletions(-)
--
1.7.9.5
next reply other threads:[~2015-10-08 10:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 10:01 AKASHI Takahiro [this message]
2015-10-08 10:01 ` [PATCH v3 1/7] arm64: ftrace: adjust callsite addresses examined by stack tracer AKASHI Takahiro
2015-10-13 15:15 ` Jungseok Lee
2015-10-13 15:37 ` Steven Rostedt
2015-10-14 5:09 ` AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 2/7] arm64: ftrace: modify a stack frame in a safe way AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 3/7] arm64: ftrace: fix a stack tracer's output under function graph tracer AKASHI Takahiro
2015-10-09 6:46 ` kbuild test robot
2015-10-13 15:24 ` Jungseok Lee
2015-10-14 5:03 ` AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 4/7] arm64: ftrace: allow for tracing leaf functions AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 5/7] ftrace: allow arch-specific stack tracer AKASHI Takahiro
2015-10-13 15:45 ` Steven Rostedt
2015-10-08 10:01 ` [PATCH v3 6/7] arm64: insn: add instruction decoders for ldp/stp and add/sub AKASHI Takahiro
2015-10-08 10:01 ` [PATCH v3 7/7] arm64: ftrace: add arch-specific stack tracer AKASHI Takahiro
2015-10-09 6:41 ` kbuild test robot
2015-10-08 14:45 ` [PATCH v3 0/7] arm64: ftrace: fix incorrect output from " Jungseok Lee
2015-10-22 14:05 ` Jungseok Lee
2015-10-28 15:23 ` Will Deacon
2015-10-29 5:24 ` AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444298504-10392-1-git-send-email-takahiro.akashi@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).