From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT properties
Date: Fri, 16 Oct 2015 15:08:39 +0200 [thread overview]
Message-ID: <1445000919.3541.11.camel@pengutronix.de> (raw)
In-Reply-To: <1444997709-57293-1-git-send-email-ck.hu@mediatek.com>
Hi CK,
there is a typo in the subject: s/Dcumentation/Documentation/.
Am Freitag, den 16.10.2015, 20:15 +0800 schrieb CK Hu:
> From: Jitao Shi <jitao.shi@mediatek.com>
>
> Add documentation for DT properties supported by ps8640
> DSI-eDP converter.
>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
[...]
> + - ps8640-1v2-supply: OF device-tree regulator specification for 1v2.
> + - ps8640-3v3-supply: OF device-tree regulator specification for 3v3.
The ps8640- part of the regulator supply property names is redundant.
The PS8622 driver uses vdd12-supply as its regulator. Should we strive
for consistency here? Or if you have access to the datasheet, how are
these inputs called there?
> +
> +Optional properties:
> + - video interfaces: Device node can contain video interface port
> + nodes for panel according to [1].
> +
> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
It should be documented here that port at 0 is the input port and port at 1 is
the output port.
best regards
Philipp
next prev parent reply other threads:[~2015-10-16 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 12:15 [RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT properties CK Hu
2015-10-16 12:15 ` [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge CK Hu
2015-10-16 13:06 ` Mark Rutland
2015-10-16 13:27 ` Rob Herring
2015-10-16 13:52 ` kbuild test robot
2015-10-16 13:52 ` [PATCH] drm/bridge: fix platform_no_drv_owner.cocci warnings kbuild test robot
2015-10-16 18:14 ` [RFC 2/2] drm/bridge: Add I2C based driver for ps8640 bridge kbuild test robot
2015-10-16 13:04 ` [RFC 1/2] Dcumentation: bridge: Add documentation for ps8640 DT properties Mark Rutland
2015-10-16 13:08 ` Philipp Zabel [this message]
2015-10-16 13:21 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445000919.3541.11.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).