* [PATCH] spi: atmel: Fix DMA-setup for transfers with more than 8 bits per word.
@ 2015-10-19 20:48 David Mosberger-Tang
0 siblings, 0 replies; 5+ messages in thread
From: David Mosberger-Tang @ 2015-10-19 20:48 UTC (permalink / raw)
To: linux-arm-kernel
The DMA-slave configuration depends on the whether <= 8 or > 8 bits
are transferred per word, so we need to call
atmel_spi_dma_slave_config() with the correct value.
Signed-off-by: David Mosberger <davidm@egauge.net>
---
drivers/spi/spi-atmel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index 04e48e5..855cc56 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -758,7 +758,8 @@ static int atmel_spi_next_xfer_dma_submit(struct spi_master *master,
*plen = len;
- if (atmel_spi_dma_slave_config(as, &slave_config, 8))
+ if (atmel_spi_dma_slave_config(as, &slave_config,
+ xfer->bits_per_word))
goto err_exit;
/* Send both scatterlists */
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] spi: atmel: Fix DMA-setup for transfers with more than 8 bits per word.
@ 2015-10-19 20:54 David Mosberger-Tang
2015-10-20 10:22 ` Nicolas Ferre
0 siblings, 1 reply; 5+ messages in thread
From: David Mosberger-Tang @ 2015-10-19 20:54 UTC (permalink / raw)
To: linux-arm-kernel
The DMA-slave configuration depends on the whether <= 8 or > 8 bits
are transferred per word, so we need to call
atmel_spi_dma_slave_config() with the correct value.
Signed-off-by: David Mosberger <davidm@egauge.net>
---
drivers/spi/spi-atmel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index 04e48e5..855cc56 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -758,7 +758,8 @@ static int atmel_spi_next_xfer_dma_submit(struct spi_master *master,
*plen = len;
- if (atmel_spi_dma_slave_config(as, &slave_config, 8))
+ if (atmel_spi_dma_slave_config(as, &slave_config,
+ xfer->bits_per_word))
goto err_exit;
/* Send both scatterlists */
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] spi: atmel: Fix DMA-setup for transfers with more than 8 bits per word.
2015-10-19 20:54 David Mosberger-Tang
@ 2015-10-20 10:22 ` Nicolas Ferre
2015-10-20 10:27 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Ferre @ 2015-10-20 10:22 UTC (permalink / raw)
To: linux-arm-kernel
Le 19/10/2015 22:54, David Mosberger-Tang a ?crit :
> The DMA-slave configuration depends on the whether <= 8 or > 8 bits
> are transferred per word, so we need to call
> atmel_spi_dma_slave_config() with the correct value.
>
> Signed-off-by: David Mosberger <davidm@egauge.net>
Thanks for having rewritten this patch! It's much more simple like this ;-)
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
For Mark, here is the patchwork entry which can be handy:
https://patchwork.kernel.org/patch/7439931/
Best regards,
> ---
> drivers/spi/spi-atmel.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 04e48e5..855cc56 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -758,7 +758,8 @@ static int atmel_spi_next_xfer_dma_submit(struct spi_master *master,
>
> *plen = len;
>
> - if (atmel_spi_dma_slave_config(as, &slave_config, 8))
> + if (atmel_spi_dma_slave_config(as, &slave_config,
> + xfer->bits_per_word))
> goto err_exit;
>
> /* Send both scatterlists */
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] spi: atmel: Fix DMA-setup for transfers with more than 8 bits per word.
2015-10-20 10:22 ` Nicolas Ferre
@ 2015-10-20 10:27 ` Mark Brown
2015-10-20 12:26 ` Nicolas Ferre
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2015-10-20 10:27 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 20, 2015 at 12:22:25PM +0200, Nicolas Ferre wrote:
> Thanks for having rewritten this patch! It's much more simple like this ;-)
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> For Mark, here is the patchwork entry which can be handy:
> https://patchwork.kernel.org/patch/7439931/
No, please submit the patch via e-mail as covered in SubmittingPatches
and as I said yesterday.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151020/c11a2ef5/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] spi: atmel: Fix DMA-setup for transfers with more than 8 bits per word.
2015-10-20 10:27 ` Mark Brown
@ 2015-10-20 12:26 ` Nicolas Ferre
0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Ferre @ 2015-10-20 12:26 UTC (permalink / raw)
To: linux-arm-kernel
Le 20/10/2015 12:27, Mark Brown a ?crit :
> On Tue, Oct 20, 2015 at 12:22:25PM +0200, Nicolas Ferre wrote:
>
>> Thanks for having rewritten this patch! It's much more simple like this ;-)
>
>> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
>> For Mark, here is the patchwork entry which can be handy:
>> https://patchwork.kernel.org/patch/7439931/
>
> No, please submit the patch via e-mail as covered in SubmittingPatches
> and as I said yesterday.
Done right now ;-)
Thanks, bye,
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-20 12:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-19 20:48 [PATCH] spi: atmel: Fix DMA-setup for transfers with more than 8 bits per word David Mosberger-Tang
-- strict thread matches above, loose matches on Subject: below --
2015-10-19 20:54 David Mosberger-Tang
2015-10-20 10:22 ` Nicolas Ferre
2015-10-20 10:27 ` Mark Brown
2015-10-20 12:26 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).