linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] ARM: imx: add platform irq type setting in gpc
Date: Tue, 20 Oct 2015 10:34:42 +0200	[thread overview]
Message-ID: <1445330082.3716.1.camel@pengutronix.de> (raw)
In-Reply-To: <1445337859-19111-1-git-send-email-Anson.Huang@freescale.com>

Am Dienstag, den 20.10.2015, 18:44 +0800 schrieb Anson Huang:
> From: Anson Huang <b20788@freescale.com>
> 
> GPC irq domain is a child domain of GIC, now all of platform irqs
> are inside GPC domain, during the module populate, all devices irq
> should have correct type setting in GIC, however, there is no
> .irq_set_type callback setting in GPC, so the irq_set_type will be
> skipped and cause all irqs' type in /proc/interrupt are "edge" which
> mismatch with irq type setting in dtb file. Since GPC has no irq
> type setting, so just tell kernel to use irq_chip_set_type_parent.
> 
> Signed-off-by: Anson Huang <Anson.Huang@freescale.com>

Cc: <stable@vger.kernel.org> # 4.1+
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

> ---
> change from V1:
> 	improve commit message.
>  arch/arm/mach-imx/gpc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c
> index 10bf715..b3a7a74 100644
> --- a/arch/arm/mach-imx/gpc.c
> +++ b/arch/arm/mach-imx/gpc.c
> @@ -176,6 +176,7 @@ static struct irq_chip imx_gpc_chip = {
>  	.irq_unmask		= imx_gpc_irq_unmask,
>  	.irq_retrigger		= irq_chip_retrigger_hierarchy,
>  	.irq_set_wake		= imx_gpc_irq_set_wake,
> +	.irq_set_type           = irq_chip_set_type_parent,
>  #ifdef CONFIG_SMP
>  	.irq_set_affinity	= irq_chip_set_affinity_parent,
>  #endif

-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |

  reply	other threads:[~2015-10-20  8:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20 10:44 [PATCH V2] ARM: imx: add platform irq type setting in gpc Anson Huang
2015-10-20  8:34 ` Lucas Stach [this message]
2015-11-23  5:13 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445330082.3716.1.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).