[PATCH V2] ARM: imx: add platform irq type setting in gpc

[PATCH V2] ARM: imx: add platform irq type setting in gpc

[Lucas Stach]

Am Dienstag, den 20.10.2015, 18:44 +0800 schrieb Anson Huang:
> From: Anson Huang <b20788@freescale.com>
> 
> GPC irq domain is a child domain of GIC, now all of platform irqs
> are inside GPC domain, during the module populate, all devices irq
> should have correct type setting in GIC, however, there is no
> .irq_set_type callback setting in GPC, so the irq_set_type will be
> skipped and cause all irqs' type in /proc/interrupt are "edge" which
> mismatch with irq type setting in dtb file. Since GPC has no irq
> type setting, so just tell kernel to use irq_chip_set_type_parent.
> 
> Signed-off-by: Anson Huang <Anson.Huang@freescale.com>

Cc: <stable@vger.kernel.org> # 4.1+
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

> ---
> change from V1:
> 	improve commit message.
>  arch/arm/mach-imx/gpc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c
> index 10bf715..b3a7a74 100644
> --- a/arch/arm/mach-imx/gpc.c
> +++ b/arch/arm/mach-imx/gpc.c
> @@ -176,6 +176,7 @@ static struct irq_chip imx_gpc_chip = {
>  	.irq_unmask		= imx_gpc_irq_unmask,
>  	.irq_retrigger		= irq_chip_retrigger_hierarchy,
>  	.irq_set_wake		= imx_gpc_irq_set_wake,
> +	.irq_set_type           = irq_chip_set_type_parent,
>  #ifdef CONFIG_SMP
>  	.irq_set_affinity	= irq_chip_set_affinity_parent,
>  #endif

-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |

[PATCH V2] ARM: imx: add platform irq type setting in gpc

[Anson Huang]

From: Anson Huang <b20788@freescale.com>

GPC irq domain is a child domain of GIC, now all of platform irqs
are inside GPC domain, during the module populate, all devices irq
should have correct type setting in GIC, however, there is no
.irq_set_type callback setting in GPC, so the irq_set_type will be
skipped and cause all irqs' type in /proc/interrupt are "edge" which
mismatch with irq type setting in dtb file. Since GPC has no irq
type setting, so just tell kernel to use irq_chip_set_type_parent.

Signed-off-by: Anson Huang <Anson.Huang@freescale.com>
---
change from V1:
	improve commit message.
 arch/arm/mach-imx/gpc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c
index 10bf715..b3a7a74 100644
--- a/arch/arm/mach-imx/gpc.c
+++ b/arch/arm/mach-imx/gpc.c
@@ -176,6 +176,7 @@ static struct irq_chip imx_gpc_chip = {
 	.irq_unmask		= imx_gpc_irq_unmask,
 	.irq_retrigger		= irq_chip_retrigger_hierarchy,
 	.irq_set_wake		= imx_gpc_irq_set_wake,
+	.irq_set_type           = irq_chip_set_type_parent,
 #ifdef CONFIG_SMP
 	.irq_set_affinity	= irq_chip_set_affinity_parent,
 #endif
-- 
1.9.1

[PATCH V2] ARM: imx: add platform irq type setting in gpc

[Shawn Guo]

On Tue, Oct 20, 2015 at 06:44:19PM +0800, Anson Huang wrote:
> From: Anson Huang <b20788@freescale.com>
> 
> GPC irq domain is a child domain of GIC, now all of platform irqs
> are inside GPC domain, during the module populate, all devices irq
> should have correct type setting in GIC, however, there is no
> .irq_set_type callback setting in GPC, so the irq_set_type will be
> skipped and cause all irqs' type in /proc/interrupt are "edge" which
> mismatch with irq type setting in dtb file. Since GPC has no irq
> type setting, so just tell kernel to use irq_chip_set_type_parent.
> 
> Signed-off-by: Anson Huang <Anson.Huang@freescale.com>

Applied, thanks.