linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v2 2/2] ARM: imx6: change default burst size for USB
Date: Tue, 20 Oct 2015 10:41:49 +0200	[thread overview]
Message-ID: <1445330509.3716.8.camel@pengutronix.de> (raw)
In-Reply-To: <20151020070718.GC7203@shlinux2>

Hi Shawn,

Am Dienstag, den 20.10.2015, 15:07 +0800 schrieb Peter Chen:
> On Wed, Sep 30, 2015 at 09:37:12PM +0800, Shawn Guo wrote:
> > On Wed, Sep 30, 2015 at 10:52:39AM +0200, Lucas Stach wrote:
> > > Am Mittwoch, den 30.09.2015, 10:17 +0800 schrieb Peter Chen:
> > > > It can improve the USB performance when choosing larger
> > > > burst size at some systems (bus size is larger), there is
> > > > no side effect if this burst size is larger than bus size.
> > > > 
> > > Just for the record, as it seems too late to stop the train now:
> > > 
> > > I am _NOT_ happy that the extended binding has been accepted into the
> > > USB tree despite outstanding review comments from me not being addressed
> > > or even answered.
> > 
> > Okay.  I'm not aware of this.  I'm dropping the patches until everyone
> > agrees with it.
> > 
> 
> Hi Shawn & Lucas, I sent the improvement patch for dt description following 
> Lucas's comment one week ago at below:
> 
> https://www.spinics.net/lists/linux-usb/msg131150.html
> 
> If no more comments, queue my dts patches please.
> 
While the binding hasn't received a good review in time it is already in
a released kernel and I'm not going to argue to change it now after the
fact (violating the DT stability rules) just to satisfy my rather minor
comments. I want to make clear that I was not happy by how this stuff
has been handled with the USB tree and it is my hope that this can be
improved for future binding changes.

But please don't hold those DTS patches any longer. The binding is in,
there is no point in not applying the corresponding patches.

Regards,
Lucas

-- 
Pengutronix e.K.             | Lucas Stach                 |
Industrial Linux Solutions   | http://www.pengutronix.de/  |

  reply	other threads:[~2015-10-20  8:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30  2:17 [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 for USB Peter Chen
2015-09-30  2:17 ` [RESEND PATCH v2 2/2] ARM: imx6: change default burst size " Peter Chen
2015-09-30  8:52   ` Lucas Stach
2015-09-30 13:37     ` Shawn Guo
2015-10-20  7:07       ` Peter Chen
2015-10-20  8:41         ` Lucas Stach [this message]
2015-11-18  8:33           ` Peter Chen
2015-10-01  8:13     ` Peter Chen
2015-10-01  8:42       ` Lucas Stach
2015-10-01 10:51         ` Peter Chen
2015-09-30  5:24 ` [RESEND PATCH v2 1/2] ARM: imx6: set ahb-burst-config as 0 " Shawn Guo
2015-11-23  0:53 ` Shawn Guo
2015-11-23  1:57   ` Peter Chen
2015-11-23  6:24     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445330509.3716.8.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).