linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL 3/6] KVM: arm: use GIC support unconditionally
Date: Tue, 20 Oct 2015 18:19:04 +0200	[thread overview]
Message-ID: <1445357947-6022-4-git-send-email-christoffer.dall@linaro.org> (raw)
In-Reply-To: <1445357947-6022-1-git-send-email-christoffer.dall@linaro.org>

From: Arnd Bergmann <arnd@arndb.de>

The vgic code on ARM is built for all configurations that enable KVM,
but the parent_data field that it references is only present when
CONFIG_IRQ_DOMAIN_HIERARCHY is set:

virt/kvm/arm/vgic.c: In function 'kvm_vgic_map_phys_irq':
virt/kvm/arm/vgic.c:1781:13: error: 'struct irq_data' has no member named 'parent_data'

This flag is implied by the GIC driver, and indeed the VGIC code only
makes sense if a GIC is present. This changes the CONFIG_KVM symbol
to always select GIC, which avoids the issue.

Fixes: 662d9715840 ("arm/arm64: KVM: Kill CONFIG_KVM_ARM_{VGIC,TIMER}")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
---
 arch/arm/kvm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/kvm/Kconfig b/arch/arm/kvm/Kconfig
index 210ecca..356970f 100644
--- a/arch/arm/kvm/Kconfig
+++ b/arch/arm/kvm/Kconfig
@@ -21,6 +21,7 @@ config KVM
 	depends on MMU && OF
 	select PREEMPT_NOTIFIERS
 	select ANON_INODES
+	select ARM_GIC
 	select HAVE_KVM_CPU_RELAX_INTERCEPT
 	select HAVE_KVM_ARCH_TLB_FLUSH_ALL
 	select KVM_MMIO
-- 
2.1.2.330.g565301e.dirty

  parent reply	other threads:[~2015-10-20 16:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20 16:19 [GIT PULL 0/6] A handful of fixes for KVM/ARM for v4.3-rc7 Christoffer Dall
2015-10-20 16:19 ` [GIT PULL 1/6] KVM: arm/arm64: Do not inject spurious interrupts Christoffer Dall
2015-10-20 16:19 ` [GIT PULL 2/6] KVM: arm/arm64: Fix memory leak if timer initialization fails Christoffer Dall
2015-10-20 16:19 ` Christoffer Dall [this message]
     [not found]   ` <672714208.55851501.1445370665940.JavaMail.zimbra@zmail13.collab.prod.int.phx2.redhat.com>
2015-10-21 13:20     ` [GIT PULL 3/6] KVM: arm: use GIC support unconditionally Christoffer Dall
2015-10-21 13:45     ` Arnd Bergmann
2015-10-21 13:58       ` Christoffer Dall
2015-10-21 14:15         ` Arnd Bergmann
2015-10-21 14:50       ` Pavel Fedin
2015-10-20 16:19 ` [GIT PULL 4/6] arm/arm64: KVM: Fix arch timer behavior for disabled interrupts Christoffer Dall
2015-10-20 16:19 ` [GIT PULL 5/6] arm/arm64: KVM: Clear map->active on pend/active clear Christoffer Dall
2015-10-20 16:19 ` [GIT PULL 6/6] arm/arm64: KVM: Fix disabled distributor operation Christoffer Dall
2015-10-21 15:47 ` [GIT PULL 0/6] A handful of fixes for KVM/ARM for v4.3-rc7 Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445357947-6022-4-git-send-email-christoffer.dall@linaro.org \
    --to=christoffer.dall@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).