linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ddaney.cavm@gmail.com (David Daney)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] net: thunderx: Remove PF soft reset.
Date: Fri, 23 Oct 2015 17:14:07 -0700	[thread overview]
Message-ID: <1445645650-17328-2-git-send-email-ddaney.cavm@gmail.com> (raw)
In-Reply-To: <1445645650-17328-1-git-send-email-ddaney.cavm@gmail.com>

From: Sunil Goutham <sgoutham@cavium.com>

In some silicon revisions, the soft reset clobbers PCI config space,
so quit doing the reset.

Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
Signed-off-by: David Daney <david.daney@cavium.com>
---
 drivers/net/ethernet/cavium/thunder/nic_main.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c b/drivers/net/ethernet/cavium/thunder/nic_main.c
index b3a5947..d6e3219 100644
--- a/drivers/net/ethernet/cavium/thunder/nic_main.c
+++ b/drivers/net/ethernet/cavium/thunder/nic_main.c
@@ -305,9 +305,6 @@ static void nic_init_hw(struct nicpf *nic)
 {
 	int i;
 
-	/* Reset NIC, in case the driver is repeatedly inserted and removed */
-	nic_reg_write(nic, NIC_PF_SOFT_RESET, 1);
-
 	/* Enable NIC HW block */
 	nic_reg_write(nic, NIC_PF_CFG, 0x3);
 
-- 
1.8.3.1

  reply	other threads:[~2015-10-24  0:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-24  0:14 [PATCH 0/4] net: thunderx: Support pass-2 revision hardware David Daney
2015-10-24  0:14 ` David Daney [this message]
2015-10-24  0:14 ` [PATCH 2/4] net: thunderx: Fix incorrect subsystem devid of VF on pass2 silicon David Daney
2015-10-24  0:14 ` [PATCH 3/4] net: thunderx: Rewrite silicon revision tests David Daney
2015-10-24  0:14 ` [PATCH 4/4] net: thunderx: Incorporate pass2 silicon CPI index configuration changes David Daney
2015-10-26  1:16 ` [PATCH 0/4] net: thunderx: Support pass-2 revision hardware David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445645650-17328-2-git-send-email-ddaney.cavm@gmail.com \
    --to=ddaney.cavm@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).