From: eric.auger@linaro.org (Eric Auger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 7/8] vfio: platform: add dev_info on device reset
Date: Tue, 3 Nov 2015 18:12:18 +0000 [thread overview]
Message-ID: <1446574339-1843-8-git-send-email-eric.auger@linaro.org> (raw)
In-Reply-To: <1446574339-1843-1-git-send-email-eric.auger@linaro.org>
It might be helpful for the end-user to check the device reset
function was found by the vfio platform reset framework.
Lets store a pointer to the struct device in vfio_platform_device
and trace when the reset function is called or not found.
Signed-off-by: Eric Auger <eric.auger@linaro.org>
---
v3: creation
---
drivers/vfio/platform/vfio_platform_common.c | 14 ++++++++++++--
drivers/vfio/platform/vfio_platform_private.h | 1 +
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
index f74836a..376d289 100644
--- a/drivers/vfio/platform/vfio_platform_common.c
+++ b/drivers/vfio/platform/vfio_platform_common.c
@@ -144,8 +144,12 @@ static void vfio_platform_release(void *device_data)
mutex_lock(&driver_lock);
if (!(--vdev->refcnt)) {
- if (vdev->reset)
+ if (vdev->reset) {
+ dev_info(vdev->device, "reset\n");
vdev->reset(vdev);
+ } else {
+ dev_warn(vdev->device, "no reset function found!\n");
+ }
vfio_platform_regions_cleanup(vdev);
vfio_platform_irq_cleanup(vdev);
}
@@ -174,8 +178,12 @@ static int vfio_platform_open(void *device_data)
if (ret)
goto err_irq;
- if (vdev->reset)
+ if (vdev->reset) {
+ dev_info(vdev->device, "reset\n");
vdev->reset(vdev);
+ } else {
+ dev_warn(vdev->device, "no reset function found!\n");
+ }
}
vdev->refcnt++;
@@ -551,6 +559,8 @@ int vfio_platform_probe_common(struct vfio_platform_device *vdev,
return -EINVAL;
}
+ vdev->device = dev;
+
group = iommu_group_get(dev);
if (!group) {
pr_err("VFIO: No IOMMU group for device %s\n", vdev->name);
diff --git a/drivers/vfio/platform/vfio_platform_private.h b/drivers/vfio/platform/vfio_platform_private.h
index d1b0668..42816dd 100644
--- a/drivers/vfio/platform/vfio_platform_private.h
+++ b/drivers/vfio/platform/vfio_platform_private.h
@@ -59,6 +59,7 @@ struct vfio_platform_device {
struct module *parent_module;
const char *compat;
struct module *reset_module;
+ struct device *device;
/*
* These fields should be filled by the bus specific binder
--
1.9.1
next prev parent reply other threads:[~2015-11-03 18:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 18:12 [PATCH v6 0/8] VFIO platform reset module rework Eric Auger
2015-11-03 18:12 ` [PATCH v6 1/8] vfio: platform: introduce vfio-platform-base module Eric Auger
2015-11-03 18:12 ` [PATCH v6 2/8] vfio: platform: add capability to register a reset function Eric Auger
2015-11-03 18:12 ` [PATCH v6 3/8] vfio: platform: introduce module_vfio_reset_handler macro Eric Auger
2015-11-03 18:12 ` [PATCH v6 4/8] vfio: platform: reset: calxedaxgmac: add reset function registration Eric Auger
2015-11-03 18:12 ` [PATCH v6 5/8] vfio: platform: add compat in vfio_platform_device Eric Auger
2015-11-03 18:12 ` [PATCH v6 6/8] vfio: platform: use list of registered reset function Eric Auger
2015-11-03 18:12 ` Eric Auger [this message]
2015-11-03 18:12 ` [PATCH v6 8/8] vfio: platform: reset: calxedaxgmac: fix ioaddr leak Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446574339-1843-8-git-send-email-eric.auger@linaro.org \
--to=eric.auger@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).