linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: soren.brinkmann@xilinx.com (Soren Brinkmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/9] tty: xuartps: Beautify read-modify writes
Date: Tue, 3 Nov 2015 16:20:42 -0800	[thread overview]
Message-ID: <1446596450-20918-2-git-send-email-soren.brinkmann@xilinx.com> (raw)
In-Reply-To: <1446596450-20918-1-git-send-email-soren.brinkmann@xilinx.com>

Non-functional, formatting changes to ease reading the code.

Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
 drivers/tty/serial/xilinx_uartps.c | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 009e0dbc12d2..50d4082d2354 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -515,12 +515,14 @@ static void cdns_uart_start_tx(struct uart_port *port)
 	if (uart_circ_empty(&port->state->xmit) || uart_tx_stopped(port))
 		return;
 
-	status = readl(port->membase + CDNS_UART_CR_OFFSET);
-	/* Set the TX enable bit and clear the TX disable bit to enable the
+	/*
+	 * Set the TX enable bit and clear the TX disable bit to enable the
 	 * transmitter.
 	 */
-	writel((status & ~CDNS_UART_CR_TX_DIS) | CDNS_UART_CR_TX_EN,
-			port->membase + CDNS_UART_CR_OFFSET);
+	status = readl(port->membase + CDNS_UART_CR_OFFSET);
+	status &= ~CDNS_UART_CR_TX_DIS;
+	status |= CDNS_UART_CR_TX_EN;
+	writel(status, port->membase + CDNS_UART_CR_OFFSET);
 
 	while (numbytes-- && ((readl(port->membase + CDNS_UART_SR_OFFSET) &
 				CDNS_UART_SR_TXFULL)) != CDNS_UART_SR_TXFULL) {
@@ -1123,8 +1125,9 @@ static void cdns_uart_console_write(struct console *co, const char *s,
 	 * clear the TX disable bit to enable the transmitter.
 	 */
 	ctrl = readl(port->membase + CDNS_UART_CR_OFFSET);
-	writel((ctrl & ~CDNS_UART_CR_TX_DIS) | CDNS_UART_CR_TX_EN,
-			port->membase + CDNS_UART_CR_OFFSET);
+	ctrl &= ~CDNS_UART_CR_TX_DIS;
+	ctrl |= CDNS_UART_CR_TX_EN;
+	writel(ctrl, port->membase + CDNS_UART_CR_OFFSET);
 
 	uart_console_write(port, s, count, cdns_uart_console_putchar);
 	cdns_uart_console_wait_tx(port);
-- 
2.6.2.3.ga463a5b

  reply	other threads:[~2015-11-04  0:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04  0:20 [PATCH 0/9] tty: xuartps: Fix lock ups Soren Brinkmann
2015-11-04  0:20 ` Soren Brinkmann [this message]
2015-11-04  0:20 ` [PATCH 2/9] tty: xuartps: Use spinlock to serialize HW access Soren Brinkmann
2015-11-04  0:52   ` kbuild test robot
2015-11-04  0:20 ` [PATCH 3/9] tty: xuartps: Always enable transmitter in start_tx Soren Brinkmann
2015-11-04  0:20 ` [PATCH 4/9] tty: xuartps: Clear interrupt status register in shutdown Soren Brinkmann
2015-11-04  0:20 ` [PATCH 5/9] tty: xuartps: Improve startup function Soren Brinkmann
2015-11-04  0:20 ` [PATCH 6/9] tty: xuartps: Keep lock for whole ISR Soren Brinkmann
2015-11-04  0:20 ` [PATCH 7/9] tty: xuartps: Acquire port lock for shutdown Soren Brinkmann
2015-11-04  0:20 ` [PATCH 8/9] tty: xuartps: Move RX path into helper function Soren Brinkmann
2015-11-04  0:20 ` [PATCH 9/9] tty: xuartps: Only handle RX IRQs when RX is enabled Soren Brinkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446596450-20918-2-git-send-email-soren.brinkmann@xilinx.com \
    --to=soren.brinkmann@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).