linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: soren.brinkmann@xilinx.com (Soren Brinkmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/9] tty: xuartps: Keep lock for whole ISR
Date: Tue, 3 Nov 2015 16:20:47 -0800	[thread overview]
Message-ID: <1446596450-20918-7-git-send-email-soren.brinkmann@xilinx.com> (raw)
In-Reply-To: <1446596450-20918-1-git-send-email-soren.brinkmann@xilinx.com>

The RX path in the interrupt handler released a lock unnecessarily.

Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
 drivers/tty/serial/xilinx_uartps.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index b189e600d4ab..544ea13e2e93 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -265,9 +265,7 @@ static irqreturn_t cdns_uart_isr(int irq, void *dev_id)
 			uart_insert_char(port, isrstatus, CDNS_UART_IXR_OVERRUN,
 					data, status);
 		}
-		spin_unlock(&port->lock);
 		tty_flip_buffer_push(&port->state->port);
-		spin_lock(&port->lock);
 	}
 
 	/* Dispatch an appropriate handler */
-- 
2.6.2.3.ga463a5b

  parent reply	other threads:[~2015-11-04  0:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04  0:20 [PATCH 0/9] tty: xuartps: Fix lock ups Soren Brinkmann
2015-11-04  0:20 ` [PATCH 1/9] tty: xuartps: Beautify read-modify writes Soren Brinkmann
2015-11-04  0:20 ` [PATCH 2/9] tty: xuartps: Use spinlock to serialize HW access Soren Brinkmann
2015-11-04  0:52   ` kbuild test robot
2015-11-04  0:20 ` [PATCH 3/9] tty: xuartps: Always enable transmitter in start_tx Soren Brinkmann
2015-11-04  0:20 ` [PATCH 4/9] tty: xuartps: Clear interrupt status register in shutdown Soren Brinkmann
2015-11-04  0:20 ` [PATCH 5/9] tty: xuartps: Improve startup function Soren Brinkmann
2015-11-04  0:20 ` Soren Brinkmann [this message]
2015-11-04  0:20 ` [PATCH 7/9] tty: xuartps: Acquire port lock for shutdown Soren Brinkmann
2015-11-04  0:20 ` [PATCH 8/9] tty: xuartps: Move RX path into helper function Soren Brinkmann
2015-11-04  0:20 ` [PATCH 9/9] tty: xuartps: Only handle RX IRQs when RX is enabled Soren Brinkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446596450-20918-7-git-send-email-soren.brinkmann@xilinx.com \
    --to=soren.brinkmann@xilinx.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).