linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux-kernel.bfrz@manchmal.in-ulm.de (Christoph Biedl)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] crypto: sun4i-ss: add missing statesize
Date: Sun, 8 Nov 2015 19:22:38 +0100	[thread overview]
Message-ID: <1447006457@msgid.manchmal.in-ulm.de> (raw)
In-Reply-To: <20151108175003.GT6114@lukather>

Maxime Ripard wrote...

> > > > This patch specifiy statesize for sha1 and md5.
> > > > 
> > > > Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> > > > Cc: stable at vger.kernel.org
> > > 
> > > Please also add a Fixes tag (and the stable version it applies to).
> > 
> > I don't see the point for a fixes tag as it would simply refer
> > to the original patch-set that added the driver.
> 
> What's the problem with that?

Fixes: should rather point to the commit that caused the breakage in my
opinion. Which did this by intention:

| commit 8996eafdcbad149ac0f772fb1649fbb75c482a6a
| Author: Russell King <rmk+kernel@arm.linux.org.uk>
| Date:   Fri Oct 9 20:43:33 2015 +0100
| 
|     crypto: ahash - ensure statesize is non-zero
(...)
+     This patch adds a check to prevent these drivers from registering
+     ahash algorithms until they are fixed.

Another crypto subsystem (mv_cesa) suffers from the same problem. I
have a patch ready but would prefer a consensus on these formalities
before submitting.

Aside from this, if you really need another Tested-by:, add me. And
also Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=107281

    Christoph
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151108/2e54c0cc/attachment.sig>

  reply	other threads:[~2015-11-08 18:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05  7:48 [PATCH] crypto: sun4i-ss: add missing statesize LABBE Corentin
2015-11-05 10:34 ` Chen-Yu Tsai
2015-11-05 16:07 ` Maxime Ripard
2015-11-06  4:56   ` Herbert Xu
2015-11-08 17:50     ` Maxime Ripard
2015-11-08 18:22       ` Christoph Biedl [this message]
2015-11-09  3:58         ` Herbert Xu
2015-11-11 22:22           ` Maxime Ripard
  -- strict thread matches above, loose matches on Subject: below --
2015-11-13 13:10 LABBE Corentin
2015-11-17 14:09 ` Herbert Xu
2015-11-17 14:26   ` LABBE Corentin
2015-11-17 14:27     ` Herbert Xu
2015-11-17 21:51       ` Greg KH
     [not found] <1447054026-4243-1-git-send-email-clabbe.montjoie@gmail.com>
2015-11-09  7:38 ` Herbert Xu
2015-10-20 18:05 LABBE Corentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447006457@msgid.manchmal.in-ulm.de \
    --to=linux-kernel.bfrz@manchmal.in-ulm.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).