linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: rockchip: pm: Fix PTR_ERR() argument
Date: Fri, 14 Aug 2015 19:37:13 +0200	[thread overview]
Message-ID: <1447521.3N0AVjqGBX@ubix> (raw)
In-Reply-To: <1439520199-16076-1-git-send-email-festevam@gmail.com>

On Thursday, August 13, 2015 11:43:19 PM Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> PTR_ERR should access the value just tested by IS_ERR.
> 
> The semantic patch that makes this change is available
> in scripts/coccinelle/tests/odd_ptr_err.cocci.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

>  arch/arm/mach-rockchip/pm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-rockchip/pm.c b/arch/arm/mach-rockchip/pm.c
> index 892bace..01123dd 100644
> --- a/arch/arm/mach-rockchip/pm.c
> +++ b/arch/arm/mach-rockchip/pm.c
> @@ -224,14 +224,14 @@ static int rk3288_suspend_init(struct device_node *np)
> "rockchip,rk3288-sgrf");
>  	if (IS_ERR(sgrf_regmap)) {
>  		pr_err("%s: could not find sgrf regmap\n", __func__);
> -		return PTR_ERR(pmu_regmap);
> +		return PTR_ERR(sgrf_regmap);
>  	}
> 
>  	grf_regmap = syscon_regmap_lookup_by_compatible(
>  				"rockchip,rk3288-grf");
>  	if (IS_ERR(grf_regmap)) {
>  		pr_err("%s: could not find grf regmap\n", __func__);
> -		return PTR_ERR(pmu_regmap);
> +		return PTR_ERR(grf_regmap);
>  	}
> 
>  	sram_np = of_find_compatible_node(NULL, NULL,

  reply	other threads:[~2015-08-14 17:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14  2:43 [PATCH] ARM: rockchip: pm: Fix PTR_ERR() argument Fabio Estevam
2015-08-14 17:37 ` Matthias Brugger [this message]
2015-08-24 10:40 ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447521.3N0AVjqGBX@ubix \
    --to=matthias.bgg@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).