From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3704C47074 for ; Thu, 4 Jan 2024 23:51:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2aj4Lz8srK68U0f8lkw4uhQc/KdUhv+enWqxPrI4HjQ=; b=m/QGyjdeDaH7P+ kDSmMJn0qnSg/SaWPrOHL5IfcjO0e/hCW1/DWgmW58EN3xoP72kVGAyc8iOAn/TnISxwjvEUQteWq 5ejX8lJQEyE7AedEEx+15NqmRdQ/T9EFeTlIfIAXBQjbp/d6+v0r2tcs1SDTpVauAsZhzpS4CPaNZ 9plWzB0oynoz4x7NdY0wTjsiuRLGiH0Hf/MY4lpV3V3xU0zasyHx60HIXBFp+i430X2408u4/qa/G KquirpBVdek8OHqxKbFwz2M0SP64QHU2AlrYzyzMetLvBt0K1WPPMcZGZsZl6eLdmuIZ4A3yWyvJb 6BPdl6aHJXpQS9jQHsUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rLXU8-00Fbff-1F; Thu, 04 Jan 2024 23:50:48 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rLXU5-00Fbel-2h for linux-arm-kernel@lists.infradead.org; Thu, 04 Jan 2024 23:50:47 +0000 Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-28bc870c540so812123a91.2 for ; Thu, 04 Jan 2024 15:50:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704412244; x=1705017044; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CXXgiy5l7dsn5zZazPKFMICjA/EobvOaiGmtDGKooKU=; b=OLgfi2lUHqlfjUYRe4EmPrKzB+HYHHF1Bu//jAKJyGoIMQhkuepTUWYkbiYx/tRlfB UC3wZ7Q0fuGbcZg1RTB5YlReh3GFEg9HcRU+0h+jUwEJqIaFfu+/RchXfrhTMbaEoHO6 Y+xS89i1CimjEfJNqAbrjcZPwZ140fvCcf97jQvfZBEhAwQKsFYBCJnWuentIf/avkkj o16xnNgAODZnFxD8LFzNvwedmlGwR8SMhtfp03cZQP/V4zdtSzZDrdVPGbqJaD76rJp9 a3m6SKwBjVWbRfgNWJtReqfLQNm5vtRKgV8ZzaljoDZmyLJLkSi3onhD4hJcBj5vIy2J UODA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704412244; x=1705017044; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CXXgiy5l7dsn5zZazPKFMICjA/EobvOaiGmtDGKooKU=; b=HT+6+VyXCz9dL6p6pahEXPcs28d5d+BI4kGLuC95fmrYbv58b61YmAmuc1CMMYhoQL hOx5A21cvFi83CDiPt5OGoLy71f14KgcKhqy6iCj2emIzpanD5tbluP0ShijGE1VBwJU kb3XcSRECDOjKDbG3TjH1AQthCbwRMlZ/GAWGzrVKdneyw34JFtOJaguaZgVA8fyyf1K +qk3zyEhip15uou/Pc3sSduZ41vEUc+gaCZd5iU44COUAi0VsBP5/lxXUnx0zpDGHlg3 80j4y6W0PV2Zvg79PyXU8gZSGhT6k8dlzUYiSXG3dQI1q9TxmnVrU3//QE8LBSBNsZSf 7tDg== X-Gm-Message-State: AOJu0YyQHYzXlI0Cm8vQmP9xZYc075Q9GvLpwrp1wogU8GREkin7BmV/ EKs/y6QKrk+Lp61doTRzKvg= X-Google-Smtp-Source: AGHT+IERz007exQ7MK7uKHw9u+YJxijfySORJ+qKi5+CbhkSrIwGM/eYRQLHVEQvj7f1JAdo7Fuidg== X-Received: by 2002:a17:90a:fb94:b0:28c:5391:7683 with SMTP id cp20-20020a17090afb9400b0028c53917683mr1207245pjb.65.1704412243933; Thu, 04 Jan 2024 15:50:43 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id f2-20020a17090ab94200b0028afd8b1e0bsm4222012pjw.57.2024.01.04.15.50.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 15:50:42 -0800 (PST) Message-ID: <1447ce09-f90e-4ba2-a6f7-e5cb23bf724f@gmail.com> Date: Thu, 4 Jan 2024 15:50:40 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 00/13] Introduce PHY listing and link_topology tracking Content-Language: en-US To: Jakub Kicinski , Maxime Chevallier Cc: "Russell King (Oracle)" , patchwork-bot+netdevbpf@kernel.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, andrew@lunn.ch, edumazet@google.com, pabeni@redhat.com, linux-arm-kernel@lists.infradead.org, christophe.leroy@csgroup.eu, herve.codina@bootlin.com, hkallweit1@gmail.com, vladimir.oltean@nxp.com, kory.maincent@bootlin.com, jesse.brandeburg@intel.com, corbet@lwn.net, kabel@kernel.org, piergiorgio.beruto@gmail.com, o.rempel@pengutronix.de, nicveronese@gmail.com, horms@kernel.org References: <20231221180047.1924733-1-maxime.chevallier@bootlin.com> <170413442779.30948.3175948839165575294.git-patchwork-notify@kernel.org> <20240102105125.77751812@kernel.org> <20240103153336.424dcfe3@device-28.home> <20240104154721.192694a8@kernel.org> From: Florian Fainelli In-Reply-To: <20240104154721.192694a8@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240104_155045_877922_05A99275 X-CRM114-Status: UNSURE ( 9.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/4/24 15:47, Jakub Kicinski wrote: > On Wed, 3 Jan 2024 15:33:36 +0100 Maxime Chevallier wrote: >> I think this could help in reviewing the overall design and identifying >> any glaring issue with this. > > The netlink handling looks a bit wobbly to me. > I commented best I could in the 20min I had to look at this code :( > I think it'd be best to revert, if you don't mind, because reviewing > incremental fixes will get even harder. +1 -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel