From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers/reset: appropriate __init annotation for const data
Date: Mon, 23 Nov 2015 16:21:19 +0100 [thread overview]
Message-ID: <1448292079.4008.50.camel@pengutronix.de> (raw)
In-Reply-To: <alpine.LFD.2.20.1511230943510.22569@knanqh.ubzr>
Hi Nicolas,
Am Montag, den 23.11.2015, 09:47 -0500 schrieb Nicolas Pitre:
> On Mon, 23 Nov 2015, Philipp Zabel wrote:
>
> > Hi Nicolas,
> >
> > Am Samstag, den 21.11.2015, 20:56 -0500 schrieb Nicolas Pitre:
> > > Init data marked const should be annotated with __initconst for
> > > correctness and not __initdata. This also fixes LTO builds that
> > > otherwise fail with section mismatch errors.
> > >
> > > Signed-off-by: Nicolas Pitre <nico@linaro.org>
> > > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > >
> > > diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c
> > > index 3d95c87160..9353b2dd15 100644
> > > --- a/drivers/reset/reset-sunxi.c
> > > +++ b/drivers/reset/reset-sunxi.c
> > > @@ -122,7 +122,7 @@ err_alloc:
> > > * our system, before we can even think of using a regular device
> > > * driver for it.
> > > */
> > > -static const struct of_device_id sunxi_early_reset_dt_ids[] __initdata = {
> > > +static const struct of_device_id sunxi_early_reset_dt_ids[] __initconst = {
> > > { .compatible = "allwinner,sun6i-a31-ahb1-reset", },
> > > { /* sentinel */ },
> > > };
> >
> > Thank you for the patch, this change is already contained in the latest
> > pull request sent to the arm-soc maintainers.
>
> OK. I initially posted it in July but it didn't show up in v4.2 nor in
> v4.3. I concluded it fell into a crack.
It did, I'm sorry. Please feel free to be more aggressive about
reminding me when you think I might have dropped something on the floor.
regards
Philipp
next prev parent reply other threads:[~2015-11-23 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-22 1:56 [PATCH] drivers/reset: appropriate __init annotation for const data Nicolas Pitre
2015-11-23 10:56 ` Philipp Zabel
2015-11-23 14:47 ` Nicolas Pitre
2015-11-23 15:21 ` Philipp Zabel [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-24 19:34 Nicolas Pitre
2015-07-25 6:33 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448292079.4008.50.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).