linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: anton.bondarenko.sama@gmail.com (Anton Bondarenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 7/7] spi: imx: defer spi initialization, if DMA engine is pending
Date: Sat, 28 Nov 2015 00:16:05 +0100	[thread overview]
Message-ID: <1448666165-7473-8-git-send-email-anton.bondarenko.sama@gmail.com> (raw)
In-Reply-To: <1448666165-7473-1-git-send-email-anton.bondarenko.sama@gmail.com>

If SPI device supports DMA mode, but DMA controller is not yet
available due to e.g. a delay in the corresponding kernel module
initialization, retry to initialize SPI driver later on instead of
falling back into PIO only mode.

Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Signed-off-by: Anton Bondarenko <anton.bondarenko.sama@gmail.com>
---
 drivers/spi/spi-imx.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index aaa32c2..c2edd0f 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -1341,9 +1341,15 @@ static int spi_imx_probe(struct platform_device *pdev)
 	 * Only validated on i.mx6 now, can remove the constrain if validated on
 	 * other chips.
 	 */
-	if (is_imx51_ecspi(spi_imx) &&
-	    spi_imx_sdma_init(&pdev->dev, spi_imx, master))
-		dev_err(&pdev->dev, "dma setup error,use pio instead\n");
+	if (is_imx51_ecspi(spi_imx)) {
+		ret = spi_imx_sdma_init(&pdev->dev, spi_imx, master);
+		if (ret == -EPROBE_DEFER)
+			goto out_clk_put;
+
+		if (ret < 0)
+			dev_err(&pdev->dev, "dma setup error %d, use pio\n",
+				ret);
+	}
 
 	spi_imx->devtype_data->reset(spi_imx);
 
-- 
2.6.3

      parent reply	other threads:[~2015-11-27 23:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27 23:15 [PATCH v4 0/7] Improvements for SPI IMX driver for Freescale IMX51, IMX53 and IMX6 Anton Bondarenko
2015-11-27 23:15 ` [PATCH v4 1/7] spi: imx: Fix DMA transfer Anton Bondarenko
2015-11-30  8:29   ` Sascha Hauer
2015-11-30 23:35     ` Anton Bondarenko
2015-11-27 23:16 ` [PATCH v4 2/7] spi: imx: replace fixed timeout with calculated one Anton Bondarenko
2015-11-27 23:16 ` [PATCH v4 3/7] spi: imx: add support for all SPI word width for DMA transfer Anton Bondarenko
2015-11-27 23:16 ` [PATCH v4 4/7] spi: imx: add function to check for IMX51 family controller Anton Bondarenko
2015-11-27 23:16 ` [PATCH v4 5/7] spi: imx: Add support for loopback for ECSPI controllers Anton Bondarenko
2015-11-27 23:16 ` [PATCH v4 6/7] spi: imx: return error from dma channel request Anton Bondarenko
2015-11-27 23:16 ` Anton Bondarenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448666165-7473-8-git-send-email-anton.bondarenko.sama@gmail.com \
    --to=anton.bondarenko.sama@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).