From: zohar@linux.vnet.ibm.com (Mimi Zohar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] evm: EVM_LOAD_X509 depends on EVM
Date: Mon, 30 Nov 2015 14:13:26 -0500 [thread overview]
Message-ID: <1448910806.12924.17.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <6677122.Oqut6OGZ1C@wuerfel>
On Fri, 2015-11-27 at 14:52 +0100, Arnd Bergmann wrote:
> The newly added EVM_LOAD_X509 code can be configured even if
> CONFIG_EVM is disabled, but that causes a link error:
>
> security/built-in.o: In function `integrity_load_keys':
> digsig_asymmetric.c:(.init.text+0x400): undefined reference to `evm_load_x509'
>
> This adds a Kconfig dependency to ensure it is only enabled when
> CONFIG_EVM is set as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7f753c992343 ("evm: load x509 certificate from the kernel")
Thanks for the patch!
Mimi
> ---
> Found on yesterday's linux-next with ARM randconfig builds
>
> diff --git a/security/integrity/evm/Kconfig b/security/integrity/evm/Kconfig
> index b1433e9cd8cb..87e83adf4c6e 100644
> --- a/security/integrity/evm/Kconfig
> +++ b/security/integrity/evm/Kconfig
> @@ -44,7 +44,7 @@ config EVM_EXTRA_SMACK_XATTRS
>
> config EVM_LOAD_X509
> bool "Load X509 certificate to the '.evm' trusted keyring"
> - depends on INTEGRITY_TRUSTED_KEYRING
> + depends on EVM && INTEGRITY_TRUSTED_KEYRING
> default n
> help
> Load X509 certificate to the '.evm' trusted keyring.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2015-11-30 19:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 13:52 [PATCH] evm: EVM_LOAD_X509 depends on EVM Arnd Bergmann
2015-11-30 19:13 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448910806.12924.17.camel@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).