* [PATCH] evm: EVM_LOAD_X509 depends on EVM
@ 2015-11-27 13:52 Arnd Bergmann
2015-11-30 19:13 ` Mimi Zohar
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-11-27 13:52 UTC (permalink / raw)
To: linux-arm-kernel
The newly added EVM_LOAD_X509 code can be configured even if
CONFIG_EVM is disabled, but that causes a link error:
security/built-in.o: In function `integrity_load_keys':
digsig_asymmetric.c:(.init.text+0x400): undefined reference to `evm_load_x509'
This adds a Kconfig dependency to ensure it is only enabled when
CONFIG_EVM is set as well.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 7f753c992343 ("evm: load x509 certificate from the kernel")
---
Found on yesterday's linux-next with ARM randconfig builds
diff --git a/security/integrity/evm/Kconfig b/security/integrity/evm/Kconfig
index b1433e9cd8cb..87e83adf4c6e 100644
--- a/security/integrity/evm/Kconfig
+++ b/security/integrity/evm/Kconfig
@@ -44,7 +44,7 @@ config EVM_EXTRA_SMACK_XATTRS
config EVM_LOAD_X509
bool "Load X509 certificate to the '.evm' trusted keyring"
- depends on INTEGRITY_TRUSTED_KEYRING
+ depends on EVM && INTEGRITY_TRUSTED_KEYRING
default n
help
Load X509 certificate to the '.evm' trusted keyring.
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] evm: EVM_LOAD_X509 depends on EVM
2015-11-27 13:52 [PATCH] evm: EVM_LOAD_X509 depends on EVM Arnd Bergmann
@ 2015-11-30 19:13 ` Mimi Zohar
0 siblings, 0 replies; 2+ messages in thread
From: Mimi Zohar @ 2015-11-30 19:13 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 2015-11-27 at 14:52 +0100, Arnd Bergmann wrote:
> The newly added EVM_LOAD_X509 code can be configured even if
> CONFIG_EVM is disabled, but that causes a link error:
>
> security/built-in.o: In function `integrity_load_keys':
> digsig_asymmetric.c:(.init.text+0x400): undefined reference to `evm_load_x509'
>
> This adds a Kconfig dependency to ensure it is only enabled when
> CONFIG_EVM is set as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7f753c992343 ("evm: load x509 certificate from the kernel")
Thanks for the patch!
Mimi
> ---
> Found on yesterday's linux-next with ARM randconfig builds
>
> diff --git a/security/integrity/evm/Kconfig b/security/integrity/evm/Kconfig
> index b1433e9cd8cb..87e83adf4c6e 100644
> --- a/security/integrity/evm/Kconfig
> +++ b/security/integrity/evm/Kconfig
> @@ -44,7 +44,7 @@ config EVM_EXTRA_SMACK_XATTRS
>
> config EVM_LOAD_X509
> bool "Load X509 certificate to the '.evm' trusted keyring"
> - depends on INTEGRITY_TRUSTED_KEYRING
> + depends on EVM && INTEGRITY_TRUSTED_KEYRING
> default n
> help
> Load X509 certificate to the '.evm' trusted keyring.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-30 19:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-27 13:52 [PATCH] evm: EVM_LOAD_X509 depends on EVM Arnd Bergmann
2015-11-30 19:13 ` Mimi Zohar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).