From mboxrd@z Thu Jan 1 00:00:00 1970 From: soren.brinkmann@xilinx.com (Soren Brinkmann) Date: Sat, 5 Dec 2015 20:39:22 -0800 Subject: [PATCH LINUX v4 06/13] tty: xuartps: Move request_irq to after setting up the HW In-Reply-To: <1449376769-13369-1-git-send-email-soren.brinkmann@xilinx.com> References: <1449376769-13369-1-git-send-email-soren.brinkmann@xilinx.com> Message-ID: <1449376769-13369-7-git-send-email-soren.brinkmann@xilinx.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Request_irq() should be _after_ h/w programming, otherwise an interrupt could be triggered and in-progress before the h/w has been setup. Reported-by: Peter Hurley Signed-off-by: Soren Brinkmann --- v4: - this patch has been added. Thanks to Peter for pointing it out and providing commit message --- drivers/tty/serial/xilinx_uartps.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 6ffd3bbe3e18..1e9053656610 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -759,12 +759,7 @@ static void cdns_uart_set_termios(struct uart_port *port, static int cdns_uart_startup(struct uart_port *port) { unsigned long flags; - unsigned int retval = 0, status = 0; - - retval = request_irq(port->irq, cdns_uart_isr, 0, CDNS_UART_NAME, - (void *)port); - if (retval) - return retval; + unsigned int status = 0; spin_lock_irqsave(&port->lock, flags); @@ -818,7 +813,7 @@ static int cdns_uart_startup(struct uart_port *port) spin_unlock_irqrestore(&port->lock, flags); - return retval; + return request_irq(port->irq, cdns_uart_isr, 0, CDNS_UART_NAME, port); } /** -- 2.6.3.3.g9bb996a