linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] ARM: dts: imx7d: add arch timer
@ 2015-12-10 23:12 Frank.Li at freescale.com
  2015-12-10 23:12 ` [PATCH 2/3] ARM: imx: select HAVE_ARM_ARCH_TIMER if selected i.MX7D Frank.Li at freescale.com
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Frank.Li at freescale.com @ 2015-12-10 23:12 UTC (permalink / raw)
  To: linux-arm-kernel

From: Frank Li <Frank.Li@freescale.com>

add cortex a7 arch timer.
uboot v2016.01-rc2 supported psci basic support.
smp can be supported by psci

Signed-off-by: Frank Li <Frank.Li@freescale.com>
---
 arch/arm/boot/dts/imx7d.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
index 489604a..a621af6 100644
--- a/arch/arm/boot/dts/imx7d.dtsi
+++ b/arch/arm/boot/dts/imx7d.dtsi
@@ -119,6 +119,15 @@
 		clock-output-names = "osc";
 	};
 
+	timer {
+		compatible = "arm,armv7-timer";
+		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
+			     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
+		interrupt-parent = <&intc>;
+	};
+
 	etr at 30086000 {
 		compatible = "arm,coresight-tmc", "arm,primecell";
 		reg = <0x30086000 0x1000>;
-- 
2.5.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/3] ARM: imx: select HAVE_ARM_ARCH_TIMER if selected i.MX7D
  2015-12-10 23:12 [PATCH 1/3] ARM: dts: imx7d: add arch timer Frank.Li at freescale.com
@ 2015-12-10 23:12 ` Frank.Li at freescale.com
  2015-12-21  6:48   ` Shawn Guo
  2015-12-10 23:12 ` [PATCH 3/3] arm: imx: config: enable psci default Frank.Li at freescale.com
  2015-12-17 20:45 ` [PATCH 1/3] ARM: dts: imx7d: add arch timer Stefan Agner
  2 siblings, 1 reply; 7+ messages in thread
From: Frank.Li at freescale.com @ 2015-12-10 23:12 UTC (permalink / raw)
  To: linux-arm-kernel

From: Frank Li <Frank.Li@freescale.com>

i.MX7D Supported ARCH Timer.

Signed-off-by: Frank Li <Frank.Li@freescale.com>
---
 arch/arm/mach-imx/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 0ac180f..061dea4 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -563,6 +563,7 @@ config SOC_IMX7D
 	select ARM_GIC
 	select HAVE_IMX_ANATOP
 	select HAVE_IMX_MMDC
+	select HAVE_ARM_ARCH_TIMER
 	help
 		This enables support for Freescale i.MX7 Dual processor.
 
-- 
2.5.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 3/3] arm: imx: config: enable psci default
  2015-12-10 23:12 [PATCH 1/3] ARM: dts: imx7d: add arch timer Frank.Li at freescale.com
  2015-12-10 23:12 ` [PATCH 2/3] ARM: imx: select HAVE_ARM_ARCH_TIMER if selected i.MX7D Frank.Li at freescale.com
@ 2015-12-10 23:12 ` Frank.Li at freescale.com
  2015-12-17 20:45 ` [PATCH 1/3] ARM: dts: imx7d: add arch timer Stefan Agner
  2 siblings, 0 replies; 7+ messages in thread
From: Frank.Li at freescale.com @ 2015-12-10 23:12 UTC (permalink / raw)
  To: linux-arm-kernel

From: Frank Li <Frank.Li@freescale.com>

i.MX7D uboot support psci firmware.
Enabled psci default.

Signed-off-by: Frank Li <Frank.Li@freescale.com>
---
 arch/arm/configs/imx_v6_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index 2d5253d..1e792ef 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -47,6 +47,7 @@ CONFIG_PCI=y
 CONFIG_PCI_MSI=y
 CONFIG_PCI_IMX6=y
 CONFIG_SMP=y
+CONFIG_ARM_PSCI=y
 CONFIG_PREEMPT_VOLUNTARY=y
 CONFIG_AEABI=y
 CONFIG_HIGHMEM=y
-- 
2.5.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 1/3] ARM: dts: imx7d: add arch timer
  2015-12-10 23:12 [PATCH 1/3] ARM: dts: imx7d: add arch timer Frank.Li at freescale.com
  2015-12-10 23:12 ` [PATCH 2/3] ARM: imx: select HAVE_ARM_ARCH_TIMER if selected i.MX7D Frank.Li at freescale.com
  2015-12-10 23:12 ` [PATCH 3/3] arm: imx: config: enable psci default Frank.Li at freescale.com
@ 2015-12-17 20:45 ` Stefan Agner
  2015-12-17 21:23   ` Zhi Li
  2 siblings, 1 reply; 7+ messages in thread
From: Stefan Agner @ 2015-12-17 20:45 UTC (permalink / raw)
  To: linux-arm-kernel

On 2015-12-10 15:12, Frank.Li at freescale.com wrote:
> From: Frank Li <Frank.Li@freescale.com>
> 
> add cortex a7 arch timer.
> uboot v2016.01-rc2 supported psci basic support.
> smp can be supported by psci

This sounds a bit overly simplified log message. I am not very into this
PSCI topic, is this a prerequisit for the ARM arch timers? Maybe you
could elaborate that a bit more.

Also, I would prefer full sentences and commonly used spellings such as
Cortex-A7, U-Boot etc...

--
Stefan

> 
> Signed-off-by: Frank Li <Frank.Li@freescale.com>
> ---
>  arch/arm/boot/dts/imx7d.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 489604a..a621af6 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -119,6 +119,15 @@
>  		clock-output-names = "osc";
>  	};
>  
> +	timer {
> +		compatible = "arm,armv7-timer";
> +		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
> +			     <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
> +			     <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
> +			     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
> +		interrupt-parent = <&intc>;
> +	};
> +
>  	etr at 30086000 {
>  		compatible = "arm,coresight-tmc", "arm,primecell";
>  		reg = <0x30086000 0x1000>;

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/3] ARM: dts: imx7d: add arch timer
  2015-12-17 20:45 ` [PATCH 1/3] ARM: dts: imx7d: add arch timer Stefan Agner
@ 2015-12-17 21:23   ` Zhi Li
  2015-12-21  6:44     ` Shawn Guo
  0 siblings, 1 reply; 7+ messages in thread
From: Zhi Li @ 2015-12-17 21:23 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Dec 17, 2015 at 2:45 PM, Stefan Agner <stefan@agner.ch> wrote:
> On 2015-12-10 15:12, Frank.Li at freescale.com wrote:
>> From: Frank Li <Frank.Li@freescale.com>
>>
>> add cortex a7 arch timer.
>> uboot v2016.01-rc2 supported psci basic support.
>> smp can be supported by psci
>
> This sounds a bit overly simplified log message. I am not very into this
> PSCI topic, is this a prerequisit for the ARM arch timers? Maybe you
> could elaborate that a bit more.

No.
But according to previous discussion. Shawn want us to use psci to enable
second core.  We need enable arch timer if second core enabled.

>
> Also, I would prefer full sentences and commonly used spellings such as
> Cortex-A7, U-Boot etc...
>
> --
> Stefan
>
>>
>> Signed-off-by: Frank Li <Frank.Li@freescale.com>
>> ---
>>  arch/arm/boot/dts/imx7d.dtsi | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
>> index 489604a..a621af6 100644
>> --- a/arch/arm/boot/dts/imx7d.dtsi
>> +++ b/arch/arm/boot/dts/imx7d.dtsi
>> @@ -119,6 +119,15 @@
>>               clock-output-names = "osc";
>>       };
>>
>> +     timer {
>> +             compatible = "arm,armv7-timer";
>> +             interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
>> +             interrupt-parent = <&intc>;
>> +     };
>> +
>>       etr at 30086000 {
>>               compatible = "arm,coresight-tmc", "arm,primecell";
>>               reg = <0x30086000 0x1000>;

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/3] ARM: dts: imx7d: add arch timer
  2015-12-17 21:23   ` Zhi Li
@ 2015-12-21  6:44     ` Shawn Guo
  0 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2015-12-21  6:44 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Dec 17, 2015 at 03:23:59PM -0600, Zhi Li wrote:
> On Thu, Dec 17, 2015 at 2:45 PM, Stefan Agner <stefan@agner.ch> wrote:
> > On 2015-12-10 15:12, Frank.Li at freescale.com wrote:
> >> From: Frank Li <Frank.Li@freescale.com>
> >>
> >> add cortex a7 arch timer.
> >> uboot v2016.01-rc2 supported psci basic support.
> >> smp can be supported by psci
> >
> > This sounds a bit overly simplified log message. I am not very into this
> > PSCI topic, is this a prerequisit for the ARM arch timers? Maybe you
> > could elaborate that a bit more.
> 
> No.
> But according to previous discussion. Shawn want us to use psci to enable
> second core.  We need enable arch timer if second core enabled.

I guess you can make the commit log a bit better by commenting
the relationship between the arch timer and secondary core.

Shawn

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/3] ARM: imx: select HAVE_ARM_ARCH_TIMER if selected i.MX7D
  2015-12-10 23:12 ` [PATCH 2/3] ARM: imx: select HAVE_ARM_ARCH_TIMER if selected i.MX7D Frank.Li at freescale.com
@ 2015-12-21  6:48   ` Shawn Guo
  0 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2015-12-21  6:48 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Dec 11, 2015 at 07:12:11AM +0800, Frank.Li at freescale.com wrote:
> From: Frank Li <Frank.Li@freescale.com>
> 
> i.MX7D Supported ARCH Timer.
> 
> Signed-off-by: Frank Li <Frank.Li@freescale.com>
> ---
>  arch/arm/mach-imx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 0ac180f..061dea4 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -563,6 +563,7 @@ config SOC_IMX7D
>  	select ARM_GIC
>  	select HAVE_IMX_ANATOP
>  	select HAVE_IMX_MMDC
> +	select HAVE_ARM_ARCH_TIMER

Please sort these selections alphabetically.

Shawn

>  	help
>  		This enables support for Freescale i.MX7 Dual processor.
>  
> -- 
> 2.5.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2015-12-21  6:48 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-10 23:12 [PATCH 1/3] ARM: dts: imx7d: add arch timer Frank.Li at freescale.com
2015-12-10 23:12 ` [PATCH 2/3] ARM: imx: select HAVE_ARM_ARCH_TIMER if selected i.MX7D Frank.Li at freescale.com
2015-12-21  6:48   ` Shawn Guo
2015-12-10 23:12 ` [PATCH 3/3] arm: imx: config: enable psci default Frank.Li at freescale.com
2015-12-17 20:45 ` [PATCH 1/3] ARM: dts: imx7d: add arch timer Stefan Agner
2015-12-17 21:23   ` Zhi Li
2015-12-21  6:44     ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).