* [PATCH 1/4] ARM: dts: sun7i: Enable touchscreen on Wexler TAB7200 tablet
2015-12-18 8:49 [PATCH 0/4] ARM: dts: sun7i: Devicetree improvements for the Wexler TAB7200 Aleksei Mamlin
@ 2015-12-18 8:51 ` Aleksei Mamlin
2015-12-18 21:25 ` Maxime Ripard
2015-12-21 15:44 ` Maxime Ripard
2015-12-18 8:52 ` [PATCH 2/4] ARM: dts: sun7i: Enable PWM controller " Aleksei Mamlin
` (2 subsequent siblings)
3 siblings, 2 replies; 12+ messages in thread
From: Aleksei Mamlin @ 2015-12-18 8:51 UTC (permalink / raw)
To: linux-arm-kernel
Add a node for the Goodix GT911 touchscreen found on the Wexler TAB7200 tablet
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
index 239b5d2..ec3b837 100644
--- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
+++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
@@ -102,6 +102,18 @@
pinctrl-names = "default";
pinctrl-0 = <&i2c2_pins_a>;
status = "okay";
+
+ gt911: touchscreen at 5d {
+ compatible = "goodix,gt911";
+ reg = <0x5d>;
+ interrupt-parent = <&pio>;
+ interrupts = <7 21 IRQ_TYPE_EDGE_FALLING>; /* EINT21 (PH21) */
+ pinctrl-names = "default";
+ pinctrl-0 = <&ts_reset_pin>;
+ irq-gpios = <&pio 7 21 GPIO_ACTIVE_HIGH>; /* INT (PH21) */
+ reset-gpios = <&pio 1 13 GPIO_ACTIVE_HIGH>; /* RST (PB13) */
+ touchscreen-swapped-x-y;
+ };
};
&lradc {
@@ -146,6 +158,13 @@
};
&pio {
+ ts_reset_pin: ts_reset_pin at 0 {
+ allwinner,pins = "PB13";
+ allwinner,function = "gpio_out";
+ allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+ allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+ };
+
usb0_id_detect_pin: usb0_id_detect_pin at 0 {
allwinner,pins = "PH4";
allwinner,function = "gpio_in";
--
2.4.10
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/4] ARM: dts: sun7i: Enable touchscreen on Wexler TAB7200 tablet
2015-12-18 8:51 ` [PATCH 1/4] ARM: dts: sun7i: Enable touchscreen on Wexler TAB7200 tablet Aleksei Mamlin
@ 2015-12-18 21:25 ` Maxime Ripard
[not found] ` <CAF==cZWcY=FH9Sr8RY4j4Ob8iuiYrBGkajZDWpNQzS-t4d074Q@mail.gmail.com>
2015-12-21 15:44 ` Maxime Ripard
1 sibling, 1 reply; 12+ messages in thread
From: Maxime Ripard @ 2015-12-18 21:25 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Fri, Dec 18, 2015 at 11:51:50AM +0300, Aleksei Mamlin wrote:
> Add a node for the Goodix GT911 touchscreen found on the Wexler TAB7200 tablet
>
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
> ---
> arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> index 239b5d2..ec3b837 100644
> --- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
> @@ -102,6 +102,18 @@
> pinctrl-names = "default";
> pinctrl-0 = <&i2c2_pins_a>;
> status = "okay";
> +
> + gt911: touchscreen at 5d {
> + compatible = "goodix,gt911";
> + reg = <0x5d>;
> + interrupt-parent = <&pio>;
> + interrupts = <7 21 IRQ_TYPE_EDGE_FALLING>; /* EINT21 (PH21) */
> + pinctrl-names = "default";
> + pinctrl-0 = <&ts_reset_pin>;
> + irq-gpios = <&pio 7 21 GPIO_ACTIVE_HIGH>; /* INT (PH21) */
It seems odd that you need both irq-gpios and interrupts. These two
are completely redundant, and you should even actually use only one in
your driver, since the second request_irq will fail.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151218/18d43e8e/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/4] ARM: dts: sun7i: Enable touchscreen on Wexler TAB7200 tablet
2015-12-18 8:51 ` [PATCH 1/4] ARM: dts: sun7i: Enable touchscreen on Wexler TAB7200 tablet Aleksei Mamlin
2015-12-18 21:25 ` Maxime Ripard
@ 2015-12-21 15:44 ` Maxime Ripard
1 sibling, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2015-12-21 15:44 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 18, 2015 at 11:51:50AM +0300, Aleksei Mamlin wrote:
> Add a node for the Goodix GT911 touchscreen found on the Wexler TAB7200 tablet
>
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151221/57134f80/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/4] ARM: dts: sun7i: Enable PWM controller on Wexler TAB7200 tablet
2015-12-18 8:49 [PATCH 0/4] ARM: dts: sun7i: Devicetree improvements for the Wexler TAB7200 Aleksei Mamlin
2015-12-18 8:51 ` [PATCH 1/4] ARM: dts: sun7i: Enable touchscreen on Wexler TAB7200 tablet Aleksei Mamlin
@ 2015-12-18 8:52 ` Aleksei Mamlin
2015-12-18 21:25 ` Maxime Ripard
2015-12-18 8:52 ` [PATCH 3/4] ARM: dts: sun7i: Add backlight node to " Aleksei Mamlin
2015-12-18 8:52 ` [PATCH 4/4] ARM: dts: sun7i: Add PA gpio pin " Aleksei Mamlin
3 siblings, 1 reply; 12+ messages in thread
From: Aleksei Mamlin @ 2015-12-18 8:52 UTC (permalink / raw)
To: linux-arm-kernel
Wexler TAB7200 tablet use channel 0 of the PWM controller for backlight dimming
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
index ec3b837..1dc9079 100644
--- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
+++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
@@ -173,6 +173,12 @@
};
};
+&pwm {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pwm0_pins_a>;
+ status = "okay";
+};
+
®_dcdc2 {
regulator-always-on;
regulator-min-microvolt = <1000000>;
--
2.4.10
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/4] ARM: dts: sun7i: Add backlight node to Wexler TAB7200 tablet
2015-12-18 8:49 [PATCH 0/4] ARM: dts: sun7i: Devicetree improvements for the Wexler TAB7200 Aleksei Mamlin
2015-12-18 8:51 ` [PATCH 1/4] ARM: dts: sun7i: Enable touchscreen on Wexler TAB7200 tablet Aleksei Mamlin
2015-12-18 8:52 ` [PATCH 2/4] ARM: dts: sun7i: Enable PWM controller " Aleksei Mamlin
@ 2015-12-18 8:52 ` Aleksei Mamlin
2015-12-18 21:27 ` Maxime Ripard
2015-12-21 15:45 ` Maxime Ripard
2015-12-18 8:52 ` [PATCH 4/4] ARM: dts: sun7i: Add PA gpio pin " Aleksei Mamlin
3 siblings, 2 replies; 12+ messages in thread
From: Aleksei Mamlin @ 2015-12-18 8:52 UTC (permalink / raw)
To: linux-arm-kernel
Add a backlight for controlling the lcd panel backlight on Wexler TAB7200 tablet
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
index 1dc9079..f47e5f1 100644
--- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
+++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
@@ -48,6 +48,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/input/input.h>
#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/pwm/pwm.h>
/ {
model = "Wexler TAB7200";
@@ -57,6 +58,16 @@
serial0 = &uart0;
};
+ backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm 0 50000 PWM_POLARITY_INVERTED>;
+ brightness-levels = <0 10 20 30 40 50 60 70 80 90 100>;
+ default-brightness-level = <8>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&bl_enable_pin>;
+ enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */
+ };
+
chosen {
stdout-path = "serial0:115200n8";
};
@@ -158,6 +169,13 @@
};
&pio {
+ bl_enable_pin: bl_enable_pin at 0 {
+ allwinner,pins = "PH7";
+ allwinner,function = "gpio_out";
+ allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+ allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+ };
+
ts_reset_pin: ts_reset_pin at 0 {
allwinner,pins = "PB13";
allwinner,function = "gpio_out";
--
2.4.10
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/4] ARM: dts: sun7i: Add backlight node to Wexler TAB7200 tablet
2015-12-18 8:52 ` [PATCH 3/4] ARM: dts: sun7i: Add backlight node to " Aleksei Mamlin
@ 2015-12-18 21:27 ` Maxime Ripard
2015-12-21 15:45 ` Maxime Ripard
1 sibling, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2015-12-18 21:27 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 18, 2015 at 11:52:22AM +0300, Aleksei Mamlin wrote:
> Add a backlight for controlling the lcd panel backlight on Wexler TAB7200 tablet
>
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
This one doesn't apply (probably because of some dependency on the
first patch).
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151218/0c2e7a50/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 3/4] ARM: dts: sun7i: Add backlight node to Wexler TAB7200 tablet
2015-12-18 8:52 ` [PATCH 3/4] ARM: dts: sun7i: Add backlight node to " Aleksei Mamlin
2015-12-18 21:27 ` Maxime Ripard
@ 2015-12-21 15:45 ` Maxime Ripard
1 sibling, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2015-12-21 15:45 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 18, 2015 at 11:52:22AM +0300, Aleksei Mamlin wrote:
> Add a backlight for controlling the lcd panel backlight on Wexler TAB7200 tablet
>
> Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151221/ee535b3b/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 4/4] ARM: dts: sun7i: Add PA gpio pin to Wexler TAB7200 tablet
2015-12-18 8:49 [PATCH 0/4] ARM: dts: sun7i: Devicetree improvements for the Wexler TAB7200 Aleksei Mamlin
` (2 preceding siblings ...)
2015-12-18 8:52 ` [PATCH 3/4] ARM: dts: sun7i: Add backlight node to " Aleksei Mamlin
@ 2015-12-18 8:52 ` Aleksei Mamlin
2015-12-21 15:45 ` Maxime Ripard
3 siblings, 1 reply; 12+ messages in thread
From: Aleksei Mamlin @ 2015-12-18 8:52 UTC (permalink / raw)
To: linux-arm-kernel
Add PA gpio pin for controlling power of two external amplifiers (NS4890) which are used on the Wexler TAB7200 tablet
Signed-off-by: Aleksei Mamlin <mamlinav@gmail.com>
---
arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
index f47e5f1..2f6b21a 100644
--- a/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
+++ b/arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dts
@@ -74,6 +74,9 @@
};
&codec {
+ pinctrl-names = "default";
+ pinctrl-0 = <&codec_pa_pin>;
+ allwinner,pa-gpios = <&pio 7 15 GPIO_ACTIVE_HIGH>; /* PH15 */
status = "okay";
};
@@ -176,6 +179,13 @@
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
};
+ codec_pa_pin: codec_pa_pin at 0 {
+ allwinner,pins = "PH15";
+ allwinner,function = "gpio_out";
+ allwinner,drive = <SUN4I_PINCTRL_10_MA>;
+ allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
+ };
+
ts_reset_pin: ts_reset_pin at 0 {
allwinner,pins = "PB13";
allwinner,function = "gpio_out";
--
2.4.10
^ permalink raw reply related [flat|nested] 12+ messages in thread