From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 67/69] clocksource/drivers/h8300: Simplify delta handling
Date: Fri, 18 Dec 2015 15:18:20 +0100 [thread overview]
Message-ID: <1450448302-27429-67-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1450448302-27429-1-git-send-email-daniel.lezcano@linaro.org>
From: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/clocksource/h8300_timer8.c | 40 ++++++--------------------------------
1 file changed, 6 insertions(+), 34 deletions(-)
diff --git a/drivers/clocksource/h8300_timer8.c b/drivers/clocksource/h8300_timer8.c
index aa4b2a98..1ba453b 100644
--- a/drivers/clocksource/h8300_timer8.c
+++ b/drivers/clocksource/h8300_timer8.c
@@ -36,57 +36,29 @@ struct timer8_priv {
unsigned int tcora;
};
-static unsigned long timer8_get_counter(struct timer8_priv *p)
-{
- unsigned long v1, v2, v3;
- int o1, o2;
-
- o1 = readb(p->mapbase + _8TCSR) & 0x20;
-
- /* Make sure the timer value is stable. Stolen from acpi_pm.c */
- do {
- o2 = o1;
- v1 = readw(p->mapbase + _8TCNT);
- v2 = readw(p->mapbase + _8TCNT);
- v3 = readw(p->mapbase + _8TCNT);
- o1 = readb(p->mapbase + _8TCSR) & 0x20;
- } while (unlikely((o1 != o2) || (v1 > v2 && v1 < v3)
- || (v2 > v3 && v2 < v1) || (v3 > v1 && v3 < v2)));
-
- v2 |= o1 << 10;
- return v2;
-}
-
static irqreturn_t timer8_interrupt(int irq, void *dev_id)
{
struct timer8_priv *p = dev_id;
- writeb(readb(p->mapbase + _8TCSR) & ~0x40,
- p->mapbase + _8TCSR);
-
- writew(p->tcora, p->mapbase + TCORA);
-
if (clockevent_state_oneshot(&p->ced))
writew(0x0000, p->mapbase + _8TCR);
p->ced.event_handler(&p->ced);
+ writeb(readb(p->mapbase + _8TCSR) & ~0x40,
+ p->mapbase + _8TCSR);
+
return IRQ_HANDLED;
}
static void timer8_set_next(struct timer8_priv *p, unsigned long delta)
{
- unsigned long now;
-
if (delta >= 0x10000)
pr_warn("delta out of range\n");
- now = timer8_get_counter(p);
- p->tcora = delta;
+ writeb(readb(p->mapbase + _8TCR) & ~0x40, p->mapbase + _8TCR);
+ writew(0, p->mapbase + _8TCNT);
+ writew(delta, p->mapbase + TCORA);
writeb(readb(p->mapbase + _8TCR) | 0x40, p->mapbase + _8TCR);
- if (delta > now)
- writew(delta, p->mapbase + TCORA);
- else
- writew(now + 1, p->mapbase + TCORA);
}
static int timer8_enable(struct timer8_priv *p)
--
1.9.1
next prev parent reply other threads:[~2015-12-18 14:18 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 14:50 [GIT PULL] clockevents for 4.5 Daniel Lezcano
2015-12-18 14:17 ` [PATCH 01/69] clocksource/drivers/mtk_timer: Add pr_fmt define Daniel Lezcano
2015-12-18 14:17 ` [PATCH 02/69] clocksource/drivers/mtk_timer: Fix pr_warn() messages in mtk_timer_init Daniel Lezcano
2015-12-30 18:15 ` Matthias Brugger
2015-12-18 14:17 ` [PATCH 03/69] clocksource/drivers/mtk_timer: Fix memleak in mtk_timer_init() Daniel Lezcano
2015-12-18 14:17 ` [PATCH 04/69] clocksource/drivers/tegra: Allow timer irq affinity change Daniel Lezcano
2015-12-18 14:17 ` [PATCH 05/69] clocksource/drivers/rockchip: Make the driver more readable Daniel Lezcano
2015-12-18 14:17 ` [PATCH 06/69] time: Define dummy functions for the generic sched clock Daniel Lezcano
2015-12-18 14:17 ` [PATCH 07/69] clocksource/drivers/rockchip: Remove dsb() usage Daniel Lezcano
2015-12-18 14:17 ` [PATCH 08/69] clocksource/drivers/qcom: Make COMPILE_TEST enabled for ARM architecture Daniel Lezcano
2015-12-18 14:17 ` [PATCH 09/69] clocksource/drivers/st_lpc: Fix Kconfig dependency Daniel Lezcano
2015-12-18 14:17 ` [PATCH 10/69] clocksource/drivers/st_lpc: Add the COMPILE_TEST option Daniel Lezcano
2015-12-18 14:17 ` [PATCH 11/69] clocksource/drivers/pxa_timer: Move the Kconfig rule Daniel Lezcano
2015-12-18 14:17 ` [PATCH 12/69] clocksource/drivers/pxa_timer: Add the COMPILE_TEST option Daniel Lezcano
2015-12-18 14:17 ` [PATCH 13/69] clocksource/drivers/tango: Add " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 14/69] clocksource/drivers/pistachio: Add the " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 15/69] clocksource/drivers/mediatek: " Daniel Lezcano
2015-12-30 18:16 ` Matthias Brugger
2015-12-18 14:17 ` [PATCH 16/69] clocksource/drivers/rockchip: Add " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 17/69] clocksource/drivers/armada-370-xp: Add the " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 18/69] clocksource/drivers/meson6: " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 19/69] clocksource/drivers/orion: " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 20/69] clocksource/drivers/digicolor: " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 21/69] clocksource/drivers/dw_apb: " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 22/69] clocksource/drivers/sun4i: " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 23/69] clocksource/drivers/sun5i: " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 24/69] clocksource/drivers/tegra2: " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 25/69] clocksource/drivers/vt8500: Remove unneeded header Daniel Lezcano
2015-12-18 14:17 ` [PATCH 26/69] clocksource/drivers/vt8500: Add the COMPILE_TEST option Daniel Lezcano
2015-12-18 14:17 ` [PATCH 27/69] clocksource/drivers/cadence_ttc: " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 28/69] clocksource/drivers/asm9260: " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 29/69] clocksource/drivers/lpc32xx: " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 30/69] clocksource/drivers/nomadik_mtu: " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 31/69] clocksource/drivers/prcmu: Fix Kconfig and add " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 32/69] clocksource/drivers/exynos_mct: " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 33/69] clocksource/drivers/samsung-pwm: Add the " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 34/69] clocksource/drivers/fsl-ftm: " Daniel Lezcano
2015-12-18 14:17 ` [PATCH 35/69] clocksource/drivers/Kconfig: Add missing GENERIC_CLOCKEVENTS dependency Daniel Lezcano
2015-12-18 14:17 ` [PATCH 36/69] clocksource/drivers/dw_apb_timer_of: Implement ARM delay timer Daniel Lezcano
2015-12-18 14:17 ` [PATCH 37/69] clocksource/drivers/h8300: Cleanup startup and remove module code Daniel Lezcano
2015-12-18 14:17 ` [PATCH 38/69] clocksource/drivers/h8300_timer8: Fix compilation error with dev_warn Daniel Lezcano
2015-12-18 14:17 ` [PATCH 39/69] clocksource/drivers/h8300_tpu: Remove unused macros Daniel Lezcano
2015-12-18 14:17 ` [PATCH 40/69] clocksource/drivers/h8300_tpu: Remove pointless headers for TPU Daniel Lezcano
2015-12-18 14:17 ` [PATCH 41/69] clocksource/drivers/h8300_timer8: Remove unused headers Daniel Lezcano
2015-12-18 14:17 ` [PATCH 42/69] clocksource/drivers/h8300_timer8: Remove unused macros Daniel Lezcano
2015-12-18 14:17 ` [PATCH 43/69] clocksource/drivers/h8300_timer8: Remove PERIODIC and ONESHOT macro Daniel Lezcano
2015-12-18 14:17 ` [PATCH 44/69] clocksource/drivers/h8300_timer8: Fix irq return value check Daniel Lezcano
2015-12-18 14:17 ` [PATCH 45/69] clocksource/drivers/h8300_timer8: Remove pointless irq re-entrant safe code Daniel Lezcano
2015-12-18 14:17 ` [PATCH 46/69] clocksource/drivers/h8300_timer8: Remove irq and lock legacy code Daniel Lezcano
2015-12-18 14:18 ` [PATCH 47/69] clocksource/drivers/h8300_timer8: Retrieve the clock rate at init time Daniel Lezcano
2015-12-18 14:18 ` [PATCH 48/69] clocksource/drivers/h8300_timer16: Remove pointless headers Daniel Lezcano
2015-12-18 14:18 ` [PATCH 49/69] clocksource/drivers/h8300_timer16: Remove unused macros Daniel Lezcano
2015-12-18 14:18 ` [PATCH 50/69] clocksource/drivers/h8300_timer16: Remove unused fields in timer16_priv Daniel Lezcano
2015-12-18 14:18 ` [PATCH 51/69] clocksource/drivers/h8300_timer16: Fix irq return value check Daniel Lezcano
2015-12-18 14:18 ` [PATCH 52/69] clocksource/drivers/h8300_timer16: Remove pointless lock Daniel Lezcano
2015-12-18 14:18 ` [PATCH 53/69] clocksource/drivers/timer_sun5i: Replace code by clocksource_mmio_init Daniel Lezcano
2015-12-18 14:18 ` [PATCH 54/69] clocksource/drivers/h8300_timer8: Separate the Kconfig option from the arch Daniel Lezcano
2015-12-18 14:18 ` [PATCH 55/69] h8300: Rename ctlr_out/in[bwl] to raw_read/write[bwl] Daniel Lezcano
2015-12-18 14:18 ` [PATCH 56/69] clocksource/drivers/h8300: Increase the compilation test coverage Daniel Lezcano
2015-12-18 14:18 ` [PATCH 57/69] clocksource/drivers/tango-xtal: Replace code by clocksource_mmio_init Daniel Lezcano
2015-12-18 14:18 ` [PATCH 58/69] clocksource/drivers/dw_apb_timer: Fix apbt_readl return types Daniel Lezcano
2015-12-18 14:18 ` [PATCH 59/69] clocksource/drivers/dw_apb_timer: Use {readl|writel}_relaxed in critical path Daniel Lezcano
2015-12-18 14:18 ` [PATCH 60/69] clocksource/drivers/dw_apb_timer: Inline apbt_readl and apbt_writel Daniel Lezcano
2015-12-18 14:18 ` [PATCH 61/69] clockevents/drivers/arm_global_timer: Use writel_relaxed in gt_compare_set Daniel Lezcano
2015-12-18 14:18 ` [PATCH 62/69] clocksource/drivers/pistachio: Fix wrong calculated clocksource read value Daniel Lezcano
2015-12-18 14:18 ` [PATCH 63/69] clocksource/drivers/arm_global_timer: Fix suspend resume Daniel Lezcano
2015-12-18 14:18 ` [PATCH 64/69] clocksource/drivers/lpc32: Correct pr_err() output format Daniel Lezcano
2015-12-18 14:18 ` [PATCH 65/69] clocksource/drivers/h8300: Change to overflow interrupt Daniel Lezcano
2015-12-18 14:18 ` [PATCH 66/69] clocksource/drivers/h8300: Fix timer not overflow case Daniel Lezcano
2015-12-18 14:18 ` Daniel Lezcano [this message]
2015-12-18 14:18 ` [PATCH 68/69] clocksource/drivers/h8300: Initializer cleanup Daniel Lezcano
2015-12-18 14:18 ` [PATCH 69/69] clocksource/drivers/h8300: Use ioread / iowrite Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450448302-27429-67-git-send-email-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).