* [RFC] arm: change to use generic sign_extend32() function
@ 2015-12-28 7:07 yalin wang
0 siblings, 0 replies; only message in thread
From: yalin wang @ 2015-12-28 7:07 UTC (permalink / raw)
To: linux-arm-kernel
change to use generic sign_extend32() to caaculate branch_displacement.
Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
---
arch/arm/probes/decode-arm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/probes/decode-arm.c b/arch/arm/probes/decode-arm.c
index f72c33a..ff794c0 100644
--- a/arch/arm/probes/decode-arm.c
+++ b/arch/arm/probes/decode-arm.c
@@ -20,13 +20,12 @@
#include <linux/module.h>
#include <linux/stddef.h>
#include <linux/ptrace.h>
+#include <linux/bitops.h>
#include "decode.h"
#include "decode-arm.h"
-#define sign_extend(x, signbit) ((x) | (0 - ((x) & (1 << (signbit)))))
-
-#define branch_displacement(insn) sign_extend(((insn) & 0xffffff) << 2, 25)
+#define branch_displacement(insn) sign_extend32(((insn) & 0xffffff) << 2, 25)
/*
* To avoid the complications of mimicing single-stepping on a
--
1.9.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-12-28 7:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-28 7:07 [RFC] arm: change to use generic sign_extend32() function yalin wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).