From: lftan@altera.com (Ley Foon Tan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] doc: PCI: altera: Fix the 'ranges' property in example
Date: Tue, 29 Dec 2015 15:48:33 +0800 [thread overview]
Message-ID: <1451375313.2990.8.camel@ubuntu> (raw)
In-Reply-To: <201512280926.53004.marex@denx.de>
On Mon, 2015-12-28 at 09:26 +0100, Marek Vasut wrote:
> On Monday, December 28, 2015 at 08:42:00 AM, Ley Foon Tan wrote:
> > On Mon, Dec 28, 2015 at 3:34 PM, Marek Vasut <marex@denx.de> wrote:
> > > On Monday, December 28, 2015 at 07:56:15 AM, Ley Foon Tan wrote:
> > >> On Thu, 2015-12-24 at 10:45 +0100, Marek Vasut wrote:
> > >> > The example does not work on real hardware with the PCIe HIP [1].
> > >> > The problem is with incorrect "ranges" property in the example, so
> > >> > one cannot just copy-paste the example into his DT and expect this
> > >> > to work. This patches aligns the "ranges" in the example with the
> > >> > reference FPGA design.
> > >>
> > >> Hi Marek
> > >
> > > Hi Ley,
> > >
> > >> The original "ranges" is working for me. What error did you encounter?
> > >
> > > Every time a driver accessed the Txs range, the system got stuck hard.
> > > The Cra access always worked fine though, so the PCIe devices were always
> > > detected.
> > >
> > > I checked with signaltap and my impression is that the wrong address
> > > propagated into the request passed to the Txs port of the HardIP block,
> > > unless I change the range configuration.
> > >
> > > Note that I tested Intel Centrino 6235 WiFi card and Atheros AR5006 WiFi
> > > card. The intel in particular uses both the Txs and even MSI , so to use
> > > the intel, the whole PCIe block has to work properly ; with this change,
> > > it does and I can use the intel card just fine.
> > >
> > >> Thanks.
> >
> > Hi Marek
> >
> > I tested two Ethernet adapters, one SSD NVMe and our custom endpoint
> > without the problem.
> > Can you please send me your dts file if possible?
> >
> > Do you use the latest Altera pcie driver in v4.4?
>
> I'm using next from 20151223, crude patch is attached.
>
Hi Marek
Your dts looks fine, same as mine; except the 'ranges' parameter. Not
sure why it is not working on your side.
I may try again with the linux-next later.
Regards
Ley Foon
next prev parent reply other threads:[~2015-12-29 7:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 9:45 [PATCH] doc: PCI: altera: Fix the 'ranges' property in example Marek Vasut
2015-12-28 6:56 ` Ley Foon Tan
2015-12-28 7:34 ` Marek Vasut
2015-12-28 7:42 ` Ley Foon Tan
2015-12-28 8:26 ` Marek Vasut
2015-12-29 7:48 ` Ley Foon Tan [this message]
2015-12-29 13:33 ` Marek Vasut
2015-12-31 3:09 ` Ley Foon Tan
2015-12-31 9:04 ` Marek Vasut
2016-01-03 23:29 ` Ley Foon Tan
2016-01-03 23:36 ` Marek Vasut
2016-01-04 0:10 ` Ley Foon Tan
2016-01-04 0:37 ` Marek Vasut
2016-01-04 0:53 ` Ley Foon Tan
2016-01-04 1:12 ` Marek Vasut
2016-01-05 0:45 ` Ley Foon Tan
2016-01-05 0:47 ` Marek Vasut
2016-01-05 1:18 ` Ley Foon Tan
2016-01-05 1:53 ` Marek Vasut
2016-01-05 13:49 ` Marek Vasut
2016-01-07 8:56 ` Ley Foon Tan
2016-01-07 16:05 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451375313.2990.8.camel@ubuntu \
--to=lftan@altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).