[PATCH] ARM: multi_v7_defconfig: MFD_DA9063 is boolean, not tristate

[PATCH] ARM: multi_v7_defconfig: MFD_DA9063 is boolean, not tristate

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>

The MFD_DA9063 Kconfig symbol is a boolean, not tristate, and therefore
m is not a valid value.

Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
Note that the driver builds fine as a module, but I suspect that there
was some other reason for making it boolean only.

 arch/arm/configs/multi_v7_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 3a4dafdf3b60..96c8a4c2ebcd 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -430,7 +430,7 @@ CONFIG_MFD_AXP20X_RSB=m
 CONFIG_MFD_CROS_EC=m
 CONFIG_MFD_CROS_EC_I2C=m
 CONFIG_MFD_CROS_EC_SPI=m
-CONFIG_MFD_DA9063=m
+CONFIG_MFD_DA9063=y
 CONFIG_MFD_MAX14577=y
 CONFIG_MFD_MAX77686=y
 CONFIG_MFD_MAX77693=y
-- 
2.5.0

[PATCH] ARM: multi_v7_defconfig: MFD_DA9063 is boolean, not tristate

[Geert Uytterhoeven]

Hi Thierry,

On Tue, Dec 29, 2015 at 11:34 AM, Thierry Reding
<thierry.reding@gmail.com> wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The MFD_DA9063 Kconfig symbol is a boolean, not tristate, and therefore
> m is not a valid value.
>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Note that the driver builds fine as a module, but I suspect that there
> was some other reason for making it boolean only.

The change to make it tristate is expected to go in through a different
tree, cfr. "[PATCH] mfd: da9063: Allow modular build"
(https://lkml.org/lkml/2015/12/7/759).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds