linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: contact@paulk.fr (Paul Kocialkowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support
Date: Tue, 29 Dec 2015 22:26:52 +0100	[thread overview]
Message-ID: <1451424412.13576.1.camel@collins> (raw)
In-Reply-To: <20151229200244.GA27426@rob-hp-laptop>

Le mardi 29 d?cembre 2015 ? 14:02 -0600, Rob Herring a ?crit :
> On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote:
> > LP872x regulators are made active via the EN pin, which might be hooked to a
> > GPIO. This adds support for driving the GPIO high when the driver is in use.
> > 
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > ---
> >  .../devicetree/bindings/regulator/lp872x.txt       |  1 +
> >  drivers/regulator/lp872x.c                         | 33 ++++++++++++++++++++--
> >  include/linux/regulator/lp872x.h                   |  2 ++
> >  3 files changed, 33 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/regulator/lp872x.txt b/Documentation/devicetree/bindings/regulator/lp872x.txt
> > index 7818318..0559c25 100644
> > --- a/Documentation/devicetree/bindings/regulator/lp872x.txt
> > +++ b/Documentation/devicetree/bindings/regulator/lp872x.txt
> > @@ -28,6 +28,7 @@ Optional properties:
> >    - ti,dvs-gpio: GPIO specifier for external DVS pin control of LP872x devices.
> >    - ti,dvs-vsel: DVS selector. 0 = SEL_V1, 1 = SEL_V2.
> >    - ti,dvs-state: initial DVS pin state. 0 = DVS_LOW, 1 = DVS_HIGH.
> > +  - ti,enable-gpio: GPIO specifier for EN pin control of LP872x devices.
> 
> Should be "-gpios" instead of "-gpio".

Care to comment why? There is only one GPIO that can be used here, since
there is only one single EN pin. I thought this matched what is done
already with "ti,dvs-gpio".

Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151229/e2fc963f/attachment.sig>

  reply	other threads:[~2015-12-29 21:26 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-23 10:58 [PATCH 0/6] LG Optimus Black (P970) codename sniper support and lp872x improvements Paul Kocialkowski
2015-12-23 10:58 ` [PATCH 1/6] regulator: lp872x: Add missing of_match in regulators descriptions Paul Kocialkowski
2015-12-28  1:04   ` Milo Kim
2015-12-23 10:58 ` [PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to DVS GPIO Paul Kocialkowski
2015-12-28  1:05   ` Milo Kim
2015-12-23 10:58 ` [PATCH 3/6] regulator: lp872x: Remove warning about invalid " Paul Kocialkowski
2015-12-23 11:41   ` Mark Brown
2015-12-23 11:50     ` Paul Kocialkowski
2015-12-23 11:58       ` Mark Brown
2015-12-23 10:58 ` [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski
2015-12-23 11:56   ` Mark Brown
2015-12-23 12:52     ` Paul Kocialkowski
2015-12-24 18:12     ` Paul Kocialkowski
2015-12-24 19:35       ` Mark Brown
2015-12-24 20:05         ` Paul Kocialkowski
2015-12-28  0:56     ` Milo Kim
2015-12-28 22:49       ` Paul Kocialkowski
2015-12-29  0:45         ` Milo Kim
2015-12-29 11:13           ` Paul Kocialkowski
2015-12-30  0:22             ` Milo Kim
2015-12-30  8:35               ` Paul Kocialkowski
2015-12-30 16:33                 ` Mark Brown
2015-12-30 18:37                   ` Paul Kocialkowski
2015-12-31 21:40                     ` Mark Brown
2015-12-31 21:59                       ` Paul Kocialkowski
2015-12-31 22:14                         ` Mark Brown
2016-01-03 10:19                           ` Paul Kocialkowski
2016-01-16  7:32                           ` Paul Kocialkowski
2016-01-18 16:32                             ` Mark Brown
2016-02-05 18:48                               ` Paul Kocialkowski
2015-12-28  0:34   ` Milo Kim
2016-02-05 18:49     ` Paul Kocialkowski
2015-12-29 20:02   ` Rob Herring
2015-12-29 21:26     ` Paul Kocialkowski [this message]
2015-12-29 21:55       ` Rob Herring
2016-02-05 18:48         ` Paul Kocialkowski
2015-12-23 10:58 ` [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features Paul Kocialkowski
2015-12-23 15:44   ` Tony Lindgren
2015-12-24 19:38     ` Paul Kocialkowski
2015-12-23 16:03   ` Javier Martinez Canillas
2015-12-24 19:38     ` Paul Kocialkowski
2015-12-23 10:58 ` [PATCH 6/6] ARM: multi_v7_defconfig: Enable LP872x regulator support Paul Kocialkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1451424412.13576.1.camel@collins \
    --to=contact@paulk.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).