linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: realview: set up cache correctly on the PB11MPCore
@ 2015-12-30 20:05 Linus Walleij
  2015-12-31 15:49 ` Arnd Bergmann
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2015-12-30 20:05 UTC (permalink / raw)
  To: linux-arm-kernel

The L2 cache comes up in a "safe mode" on the PB11MPCore, as
it has several issues. This sets it up properly with the right
size and associativity, also requiring the outer sync to be
disabled for the machine to boot properly.

Cc: Russell King <linux@arm.linux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ARM SoC folks: Russell has merged the outer cache sync disable
patch so it would be nice if you'd merge this directly on top
of the branch holding the PB11MPCore device tree, so that the
cache is feature complete for v4.5.
---
 arch/arm/boot/dts/arm-realview-pb11mp.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/arm-realview-pb11mp.dts b/arch/arm/boot/dts/arm-realview-pb11mp.dts
index 28bd5aea285f..3d9b1b0f4ffc 100644
--- a/arch/arm/boot/dts/arm-realview-pb11mp.dts
+++ b/arch/arm/boot/dts/arm-realview-pb11mp.dts
@@ -99,6 +99,19 @@
 			     <0 31 IRQ_TYPE_LEVEL_HIGH>;
 		cache-unified;
 		cache-level = <2>;
+		/*
+		 * Override default cache size, sets and
+		 * associativity as these may be erroneously set
+		 * up by boot loader(s), probably for safety
+		 * since th outer sync operation can cause the
+		 * cache to hang unless disabled.
+		 */
+		cache-size = <1048576>; // 1MB
+		cache-sets = <4096>;
+		cache-line-size = <32>;
+		arm,shared-override;
+		arm,parity-enable;
+		arm,outer-sync-disable;
 	};
 
 	scu at 1f000000 {
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: realview: set up cache correctly on the PB11MPCore
  2015-12-30 20:05 [PATCH] ARM: realview: set up cache correctly on the PB11MPCore Linus Walleij
@ 2015-12-31 15:49 ` Arnd Bergmann
  0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2015-12-31 15:49 UTC (permalink / raw)
  To: linux-arm-kernel

On Wednesday 30 December 2015 21:05:09 Linus Walleij wrote:
> The L2 cache comes up in a "safe mode" on the PB11MPCore, as
> it has several issues. This sets it up properly with the right
> size and associativity, also requiring the outer sync to be
> disabled for the machine to boot properly.
> 
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ARM SoC folks: Russell has merged the outer cache sync disable
> patch so it would be nice if you'd merge this directly on top
> of the branch holding the PB11MPCore device tree, so that the
> cache is feature complete for v4.5.

Applied on next/dt, thanks!

	Arnd

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-31 15:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-30 20:05 [PATCH] ARM: realview: set up cache correctly on the PB11MPCore Linus Walleij
2015-12-31 15:49 ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).