linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: v1ron@mail.ru (Roman Volkov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] clocksource/vt8500: Increase the minimum delta
Date: Fri,  1 Jan 2016 16:24:41 +0300	[thread overview]
Message-ID: <1451654683-2401-2-git-send-email-v1ron@mail.ru> (raw)
In-Reply-To: <1451654683-2401-1-git-send-email-v1ron@mail.ru>

From: Roman Volkov <rvolkov@v1ros.org>

The vt8500 clocksource driver declares itself as capable to handle the
minimum delay of 4 cycles by passing the value into
clockevents_config_and_register(). The vt8500_timer_set_next_event()
requires the passed cycles value to be at least 16. The impact is that
userspace hangs in nanosleep() calls with small delay intervals.

This problem is reproducible in Linux 4.2 starting from:
c6eb3f70d448 ('hrtimer: Get rid of hrtimer softirq')

Signed-off-by: Roman Volkov <rvolkov@v1ros.org>
Acked-by: Alexey Charkov <alchark@gmail.com>
---
 drivers/clocksource/vt8500_timer.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/clocksource/vt8500_timer.c b/drivers/clocksource/vt8500_timer.c
index a92e94b..dfc3bb4 100644
--- a/drivers/clocksource/vt8500_timer.c
+++ b/drivers/clocksource/vt8500_timer.c
@@ -50,6 +50,8 @@
 
 #define msecs_to_loops(t) (loops_per_jiffy / 1000 * HZ * t)
 
+#define MIN_OSCR_DELTA		16
+
 static void __iomem *regbase;
 
 static cycle_t vt8500_timer_read(struct clocksource *cs)
@@ -80,7 +82,7 @@ static int vt8500_timer_set_next_event(unsigned long cycles,
 		cpu_relax();
 	writel((unsigned long)alarm, regbase + TIMER_MATCH_VAL);
 
-	if ((signed)(alarm - clocksource.read(&clocksource)) <= 16)
+	if ((signed)(alarm - clocksource.read(&clocksource)) <= MIN_OSCR_DELTA)
 		return -ETIME;
 
 	writel(1, regbase + TIMER_IER_VAL);
@@ -151,7 +153,7 @@ static void __init vt8500_timer_init(struct device_node *np)
 		pr_err("%s: setup_irq failed for %s\n", __func__,
 							clockevent.name);
 	clockevents_config_and_register(&clockevent, VT8500_TIMER_HZ,
-					4, 0xf0000000);
+					MIN_OSCR_DELTA * 2, 0xf0000000);
 }
 
 CLOCKSOURCE_OF_DECLARE(vt8500, "via,vt8500-timer", vt8500_timer_init);
-- 
2.6.2

  reply	other threads:[~2016-01-01 13:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-01 13:24 [PATCH v3 0/3] clocksource/vt8500: Fix hangs in small delays Roman Volkov
2016-01-01 13:24 ` Roman Volkov [this message]
2016-01-05  9:01   ` [PATCH v3 1/3] clocksource/vt8500: Increase the minimum delta Daniel Lezcano
2016-01-05  9:42     ` Roman Volkov
2016-01-05 10:00       ` Russell King - ARM Linux
2016-01-05 10:31         ` Daniel Lezcano
2016-01-05 11:08           ` Roman Volkov
2016-01-05 10:09       ` Daniel Lezcano
2016-01-01 13:24 ` [PATCH v3 2/3] clocksource/vt8500: Remove the 'loops' variable Roman Volkov
2016-01-01 13:24 ` [PATCH v3 3/3] clocksource/vt8500: Add register R/W functions Roman Volkov
2016-01-06 14:24 ` [PATCH v3 0/3] clocksource/vt8500: Fix hangs in small delays Daniel Lezcano
2016-01-06 15:30   ` Roman Volkov
2016-01-07 10:49     ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1451654683-2401-2-git-send-email-v1ron@mail.ru \
    --to=v1ron@mail.ru \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).