linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] ARM: dts: rockchip: Adding LEDs handling via leds-gpio for the Radxa Rock2 Square
@ 2015-12-31  9:13 Romain Perier
  2016-01-04  9:10 ` Sjoerd Simons
  2016-01-09 22:38 ` Heiko Stuebner
  0 siblings, 2 replies; 3+ messages in thread
From: Romain Perier @ 2015-12-31  9:13 UTC (permalink / raw)
  To: linux-arm-kernel

Describe the two user-controllable LEDs on Rock2 Square boards.
All information have been retrieved from the schematics and the vendor
devicetree. The default-triggers mimic the behaviour of the vendor-kernel to
keep functionalities in sync.

Signed-off-by: Romain Perier <romain.perier@gmail.com>
---

Changes in v2:
- Changed labels according to what is defined in the schematics
- Added a long commit message describing this patch in details

 arch/arm/boot/dts/rk3288-rock2-square.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-rock2-square.dts b/arch/arm/boot/dts/rk3288-rock2-square.dts
index c5453a0..0813428 100644
--- a/arch/arm/boot/dts/rk3288-rock2-square.dts
+++ b/arch/arm/boot/dts/rk3288-rock2-square.dts
@@ -56,6 +56,23 @@
 		pinctrl-0 = <&ir_int>;
 	};
 
+	gpio-leds {
+		compatible = "gpio-leds";
+
+		heartbeat {
+			gpios = <&gpio7 15 GPIO_ACTIVE_LOW>;
+			label = "rock2:green:state1";
+			linux,default-trigger = "heartbeat";
+		};
+
+		mmc {
+			gpios = <&gpio0 11 GPIO_ACTIVE_LOW>;
+			label = "rock2:blue:state2";
+			linux,default-trigger = "mmc0";
+		};
+	};
+
+
 	sound {
 		compatible = "simple-audio-card";
 		simple-audio-card,name = "SPDIF";
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v2] ARM: dts: rockchip: Adding LEDs handling via leds-gpio for the Radxa Rock2 Square
  2015-12-31  9:13 [PATCH v2] ARM: dts: rockchip: Adding LEDs handling via leds-gpio for the Radxa Rock2 Square Romain Perier
@ 2016-01-04  9:10 ` Sjoerd Simons
  2016-01-09 22:38 ` Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Sjoerd Simons @ 2016-01-04  9:10 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, 2015-12-31 at 10:13 +0100, Romain Perier wrote:
> Describe the two user-controllable LEDs on Rock2 Square boards.
> All information have been retrieved from the schematics and the
> vendor
> devicetree. The default-triggers mimic the behaviour of the vendor-
> kernel to
> keep functionalities in sync.
> 
> Signed-off-by: Romain Perier <romain.perier@gmail.com>

Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

> ---
> 
> Changes in v2:
> - Changed labels according to what is defined in the schematics
> - Added a long commit message describing this patch in details
> 
> ?arch/arm/boot/dts/rk3288-rock2-square.dts | 17 +++++++++++++++++
> ?1 file changed, 17 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-rock2-square.dts
> b/arch/arm/boot/dts/rk3288-rock2-square.dts
> index c5453a0..0813428 100644
> --- a/arch/arm/boot/dts/rk3288-rock2-square.dts
> +++ b/arch/arm/boot/dts/rk3288-rock2-square.dts
> @@ -56,6 +56,23 @@
> ?		pinctrl-0 = <&ir_int>;
> ?	};
> ?
> +	gpio-leds {
> +		compatible = "gpio-leds";
> +
> +		heartbeat {
> +			gpios = <&gpio7 15 GPIO_ACTIVE_LOW>;
> +			label = "rock2:green:state1";
> +			linux,default-trigger = "heartbeat";
> +		};
> +
> +		mmc {
> +			gpios = <&gpio0 11 GPIO_ACTIVE_LOW>;
> +			label = "rock2:blue:state2";
> +			linux,default-trigger = "mmc0";
> +		};
> +	};
> +
> +
> ?	sound {
> ?		compatible = "simple-audio-card";
> ?		simple-audio-card,name = "SPDIF";

-- 
Sjoerd Simons
Collabora Ltd.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2] ARM: dts: rockchip: Adding LEDs handling via leds-gpio for the Radxa Rock2 Square
  2015-12-31  9:13 [PATCH v2] ARM: dts: rockchip: Adding LEDs handling via leds-gpio for the Radxa Rock2 Square Romain Perier
  2016-01-04  9:10 ` Sjoerd Simons
@ 2016-01-09 22:38 ` Heiko Stuebner
  1 sibling, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2016-01-09 22:38 UTC (permalink / raw)
  To: linux-arm-kernel

Am Donnerstag, 31. Dezember 2015, 10:13:52 schrieb Romain Perier:
> Describe the two user-controllable LEDs on Rock2 Square boards.
> All information have been retrieved from the schematics and the vendor
> devicetree. The default-triggers mimic the behaviour of the vendor-kernel
> to keep functionalities in sync.
> 
> Signed-off-by: Romain Perier <romain.perier@gmail.com>

applied to my dts32-branch for 4.6 with Sjoerd's Review


Thanks
Heiko

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-01-09 22:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-31  9:13 [PATCH v2] ARM: dts: rockchip: Adding LEDs handling via leds-gpio for the Radxa Rock2 Square Romain Perier
2016-01-04  9:10 ` Sjoerd Simons
2016-01-09 22:38 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).