* [PATCH RESEND] mpt3sas:Fix missing error checks for calls to _transport_phy_reset in mpt3sas_transport.c
@ 2016-01-11 19:10 Nicholas Krause
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas Krause @ 2016-01-11 19:10 UTC (permalink / raw)
To: linux-arm-kernel
This adds the missing error checks and paths for functions that
call _transport_phy_reset and do not correctly check that the
call to this particular function has succeeded by returning zero
in the file, mpt3sas_transport.c.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/scsi/mpt3sas/mpt3sas_transport.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_transport.c b/drivers/scsi/mpt3sas/mpt3sas_transport.c
index ca36d7e..bff5a11 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_transport.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_transport.c
@@ -1766,7 +1766,7 @@ _transport_phy_enable(struct sas_phy *phy, int enable)
/* link reset */
if (enable)
- _transport_phy_reset(phy, 0);
+ rc = _transport_phy_reset(phy, 0);
out:
kfree(sas_iounit_pg1);
@@ -1870,7 +1870,9 @@ _transport_phy_speed(struct sas_phy *phy, struct sas_phy_linkrates *rates)
}
/* link reset */
- _transport_phy_reset(phy, 0);
+ rc = _transport_phy_reset(phy, 0);
+ if (rc)
+ goto out;
/* read phy page 0, then update the rates in the sas transport phy */
if (!mpt3sas_config_get_phy_pg0(ioc, &mpi_reply, &phy_pg0,
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH RESEND] mpt3sas:Fix missing error checks for calls to _transport_phy_reset in mpt3sas_transport.c
@ 2016-07-02 19:21 Nicholas Krause
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas Krause @ 2016-07-02 19:21 UTC (permalink / raw)
To: linux-arm-kernel
This adds the missing error checks and paths for functions that
call _transport_phy_reset and do not correctly check that the
call to this particular function has succeeded by returning zero
in the file, mpt3sas_transport.c.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/scsi/mpt3sas/mpt3sas_transport.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_transport.c b/drivers/scsi/mpt3sas/mpt3sas_transport.c
index ca36d7e..bff5a11 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_transport.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_transport.c
@@ -1766,7 +1766,7 @@ _transport_phy_enable(struct sas_phy *phy, int enable)
/* link reset */
if (enable)
- _transport_phy_reset(phy, 0);
+ rc = _transport_phy_reset(phy, 0);
out:
kfree(sas_iounit_pg1);
@@ -1870,7 +1870,9 @@ _transport_phy_speed(struct sas_phy *phy, struct sas_phy_linkrates *rates)
}
/* link reset */
- _transport_phy_reset(phy, 0);
+ rc = _transport_phy_reset(phy, 0);
+ if (rc)
+ goto out;
/* read phy page 0, then update the rates in the sas transport phy */
if (!mpt3sas_config_get_phy_pg0(ioc, &mpi_reply, &phy_pg0,
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-02 19:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-11 19:10 [PATCH RESEND] mpt3sas:Fix missing error checks for calls to _transport_phy_reset in mpt3sas_transport.c Nicholas Krause
-- strict thread matches above, loose matches on Subject: below --
2016-07-02 19:21 Nicholas Krause
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).